Re: [PATCH] novatel: avoid calling qcdm_result_unref on NULL QcdmResult

2017-08-03 Thread Aleksander Morgado 
On 03/08/17 06:53, Ben Chan wrote:
> ---
>  plugins/novatel/mm-broadband-modem-novatel.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Pushed to git master, thanks.

> diff --git a/plugins/novatel/mm-broadband-modem-novatel.c 
> b/plugins/novatel/mm-broadband-modem-novatel.c
> index 88f0c36d..9c251573 100644
> --- a/plugins/novatel/mm-broadband-modem-novatel.c
> +++ b/plugins/novatel/mm-broadband-modem-novatel.c
> @@ -444,7 +444,6 @@ nw_snapshot_old_ready (MMPortSerialQcdm *port,
>  result = qcdm_cmd_nw_subsys_modem_snapshot_cdma_result ((const gchar *) 
> response->data, response->len, NULL);
>  g_byte_array_unref (response);
>  if (!result) {
> -qcdm_result_unref (result);
>  mm_dbg ("Failed to get QCDM Novatel Modem MSM6500 snapshot: %s", 
> error->message);
>  g_task_return_error (task, error);
>  g_object_unref (task);
> 


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH] novatel: avoid calling qcdm_result_unref on NULL QcdmResult

2017-08-02 Thread Ben Chan 
---
 plugins/novatel/mm-broadband-modem-novatel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/novatel/mm-broadband-modem-novatel.c 
b/plugins/novatel/mm-broadband-modem-novatel.c
index 88f0c36d..9c251573 100644
--- a/plugins/novatel/mm-broadband-modem-novatel.c
+++ b/plugins/novatel/mm-broadband-modem-novatel.c
@@ -444,7 +444,6 @@ nw_snapshot_old_ready (MMPortSerialQcdm *port,
 result = qcdm_cmd_nw_subsys_modem_snapshot_cdma_result ((const gchar *) 
response->data, response->len, NULL);
 g_byte_array_unref (response);
 if (!result) {
-qcdm_result_unref (result);
 mm_dbg ("Failed to get QCDM Novatel Modem MSM6500 snapshot: %s", 
error->message);
 g_task_return_error (task, error);
 g_object_unref (task);
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel