Re: [PATCH 2/5] broadband-modem: remove unused variables

[Aleksander Morgado]

On 03/08/17 06:53, Ben Chan wrote:
> ---
>  src/mm-broadband-modem.c | 12 
>  1 file changed, 12 deletions(-)
> 

Pushed to git master, thanks.

> diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c
> index eb127b58..2bfc3382 100644
> --- a/src/mm-broadband-modem.c
> +++ b/src/mm-broadband-modem.c
> @@ -1775,7 +1775,6 @@ signal_quality_csq_ready (MMBroadbandModem *self,
>GAsyncResult *res,
>GTask *task)
>  {
> -SignalQualityContext *ctx;
>  GError *error = NULL;
>  GVariant *result;
>  const gchar *result_str;
> @@ -1787,8 +1786,6 @@ signal_quality_csq_ready (MMBroadbandModem *self,
>  return;
>  }
>  
> -ctx = g_task_get_task_data (task);
> -
>  result_str = g_variant_get_string (result, NULL);
>  if (result_str) {
>  /* Got valid reply */
> @@ -1956,7 +1953,6 @@ signal_quality_qcdm_ready (MMPortSerialQcdm *port,
> GAsyncResult *res,
> GTask *task)
>  {
> -SignalQualityContext *ctx;
>  QcdmResult *result;
>  guint32 num = 0, quality = 0, i;
>  gfloat best_db = -28;
> @@ -1971,8 +1967,6 @@ signal_quality_qcdm_ready (MMPortSerialQcdm *port,
>  return;
>  }
>  
> -ctx = g_task_get_task_data (task);
> -
>  /* Parse the response */
>  result = qcdm_cmd_pilot_sets_result ((const gchar *) response->data,
>   response->len,
> @@ -6439,7 +6433,6 @@ list_parts_lock_storages_ready (MMBroadbandModem *self,
>  GAsyncResult *res,
>  GTask *task)
>  {
> -ListPartsContext *ctx;
>  GError *error = NULL;
>  
>  if (!mm_broadband_modem_lock_sms_storages_finish (self, res, &error)) {
> @@ -6450,8 +6443,6 @@ list_parts_lock_storages_ready (MMBroadbandModem *self,
>  return;
>  }
>  
> -ctx = g_task_get_task_data (task);
> -
>  /* Storage now set and locked */
>  
>  /* Get SMS parts from ALL types.
> @@ -8743,7 +8734,6 @@ enabling_modem_init_ready (MMBroadbandModem *self,
> GAsyncResult *res,
> GTask *task)
>  {
> -EnablingStartedContext *ctx;
>  GError *error = NULL;
>  
>  if (!MM_BROADBAND_MODEM_GET_CLASS (self)->enabling_modem_init_finish 
> (self, res, &error)) {
> @@ -8752,8 +8742,6 @@ enabling_modem_init_ready (MMBroadbandModem *self,
>  return;
>  }
>  
> -ctx = g_task_get_task_data (task);
> -
>  /* Specify that the modem init was run once */
>  self->priv->modem_init_run = TRUE;
>  
> 


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH 2/5] broadband-modem: remove unused variables

[Ben Chan]

---
 src/mm-broadband-modem.c | 12 
 1 file changed, 12 deletions(-)

diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c
index eb127b58..2bfc3382 100644
--- a/src/mm-broadband-modem.c
+++ b/src/mm-broadband-modem.c
@@ -1775,7 +1775,6 @@ signal_quality_csq_ready (MMBroadbandModem *self,
   GAsyncResult *res,
   GTask *task)
 {
-SignalQualityContext *ctx;
 GError *error = NULL;
 GVariant *result;
 const gchar *result_str;
@@ -1787,8 +1786,6 @@ signal_quality_csq_ready (MMBroadbandModem *self,
 return;
 }
 
-ctx = g_task_get_task_data (task);
-
 result_str = g_variant_get_string (result, NULL);
 if (result_str) {
 /* Got valid reply */
@@ -1956,7 +1953,6 @@ signal_quality_qcdm_ready (MMPortSerialQcdm *port,
GAsyncResult *res,
GTask *task)
 {
-SignalQualityContext *ctx;
 QcdmResult *result;
 guint32 num = 0, quality = 0, i;
 gfloat best_db = -28;
@@ -1971,8 +1967,6 @@ signal_quality_qcdm_ready (MMPortSerialQcdm *port,
 return;
 }
 
-ctx = g_task_get_task_data (task);
-
 /* Parse the response */
 result = qcdm_cmd_pilot_sets_result ((const gchar *) response->data,
  response->len,
@@ -6439,7 +6433,6 @@ list_parts_lock_storages_ready (MMBroadbandModem *self,
 GAsyncResult *res,
 GTask *task)
 {
-ListPartsContext *ctx;
 GError *error = NULL;
 
 if (!mm_broadband_modem_lock_sms_storages_finish (self, res, &error)) {
@@ -6450,8 +6443,6 @@ list_parts_lock_storages_ready (MMBroadbandModem *self,
 return;
 }
 
-ctx = g_task_get_task_data (task);
-
 /* Storage now set and locked */
 
 /* Get SMS parts from ALL types.
@@ -8743,7 +8734,6 @@ enabling_modem_init_ready (MMBroadbandModem *self,
GAsyncResult *res,
GTask *task)
 {
-EnablingStartedContext *ctx;
 GError *error = NULL;
 
 if (!MM_BROADBAND_MODEM_GET_CLASS (self)->enabling_modem_init_finish 
(self, res, &error)) {
@@ -8752,8 +8742,6 @@ enabling_modem_init_ready (MMBroadbandModem *self,
 return;
 }
 
-ctx = g_task_get_task_data (task);
-
 /* Specify that the modem init was run once */
 self->priv->modem_init_run = TRUE;
 
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel