Re: [PATCH 3/5] call-list: remove unused variables

[Aleksander Morgado]

On 03/08/17 06:53, Ben Chan wrote:
> ---
>  src/mm-call-list.c | 15 +--
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 

Pushed to git master, thanks.

> diff --git a/src/mm-call-list.c b/src/mm-call-list.c
> index 9457bb2b..3ca46bcc 100644
> --- a/src/mm-call-list.c
> +++ b/src/mm-call-list.c
> @@ -88,9 +88,8 @@ MMBaseCall* mm_call_list_get_new_incoming(MMCallList *self)
>  {
>  MMBaseCall *call = NULL;
>  GList *l;
> -guint i;
>  
> -for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
> +for (l = self->priv->list; l && !call; l = g_list_next (l)) {
>  
>  MMCallState state;
>  MMCallStateReason   reason;
> @@ -118,9 +117,8 @@ MMBaseCall* 
> mm_call_list_get_first_ringing_call(MMCallList *self)
>  {
>  MMBaseCall *call = NULL;
>  GList *l;
> -guint i;
>  
> -for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
> +for (l = self->priv->list; l && !call; l = g_list_next (l)) {
>  
>  MMCallState state;
>  
> @@ -143,9 +141,8 @@ MMBaseCall* 
> mm_call_list_get_first_outgoing_dialing_call(MMCallList *self)
>  {
>  MMBaseCall *call = NULL;
>  GList *l;
> -guint i;
>  
> -for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
> +for (l = self->priv->list; l && !call; l = g_list_next (l)) {
>  
>  MMCallState state;
>  MMCallDirection direct;
> @@ -170,9 +167,8 @@ MMBaseCall* 
> mm_call_list_get_first_non_terminated_call(MMCallList *self)
>  {
>  MMBaseCall *call = NULL;
>  GList *l;
> -guint i;
>  
> -for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
> +for (l = self->priv->list; l && !call; l = g_list_next (l)) {
>  
>  MMCallState state;
>  
> @@ -193,9 +189,8 @@ gboolean 
> mm_call_list_send_dtmf_to_active_calls(MMCallList *self, gchar *dtmf)
>  {
>  gboolean signaled = FALSE;
>  GList *l;
> -guint i;
>  
> -for (i = 0, l = self->priv->list; l; l = g_list_next (l)) {
> +for (l = self->priv->list; l; l = g_list_next (l)) {
>  
>  MMCallState state;
>  
> 


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH 3/5] call-list: remove unused variables

[Ben Chan]

---
 src/mm-call-list.c | 15 +--
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/mm-call-list.c b/src/mm-call-list.c
index 9457bb2b..3ca46bcc 100644
--- a/src/mm-call-list.c
+++ b/src/mm-call-list.c
@@ -88,9 +88,8 @@ MMBaseCall* mm_call_list_get_new_incoming(MMCallList *self)
 {
 MMBaseCall *call = NULL;
 GList *l;
-guint i;
 
-for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
+for (l = self->priv->list; l && !call; l = g_list_next (l)) {
 
 MMCallState state;
 MMCallStateReason   reason;
@@ -118,9 +117,8 @@ MMBaseCall* mm_call_list_get_first_ringing_call(MMCallList 
*self)
 {
 MMBaseCall *call = NULL;
 GList *l;
-guint i;
 
-for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
+for (l = self->priv->list; l && !call; l = g_list_next (l)) {
 
 MMCallState state;
 
@@ -143,9 +141,8 @@ MMBaseCall* 
mm_call_list_get_first_outgoing_dialing_call(MMCallList *self)
 {
 MMBaseCall *call = NULL;
 GList *l;
-guint i;
 
-for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
+for (l = self->priv->list; l && !call; l = g_list_next (l)) {
 
 MMCallState state;
 MMCallDirection direct;
@@ -170,9 +167,8 @@ MMBaseCall* 
mm_call_list_get_first_non_terminated_call(MMCallList *self)
 {
 MMBaseCall *call = NULL;
 GList *l;
-guint i;
 
-for (i = 0, l = self->priv->list; l && !call; l = g_list_next (l)) {
+for (l = self->priv->list; l && !call; l = g_list_next (l)) {
 
 MMCallState state;
 
@@ -193,9 +189,8 @@ gboolean mm_call_list_send_dtmf_to_active_calls(MMCallList 
*self, gchar *dtmf)
 {
 gboolean signaled = FALSE;
 GList *l;
-guint i;
 
-for (i = 0, l = self->priv->list; l; l = g_list_next (l)) {
+for (l = self->priv->list; l; l = g_list_next (l)) {
 
 MMCallState state;
 
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel