Re: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-07 Thread Aleksander Morgado
Hey Amol,

> After commenting PKG_FIXUP:=autoreconf, I'm getting below error:
>
> CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash 
> /home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing
>  aclocal-1.16 -I m4
> /home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing:
>  line 81: aclocal-1.16: command not found
>
> OpenWrt "master" has automake version 1.15.1.
>
> Any suggestion?
>

That may be due to these lines that modify configure.ac, which force
an autoreconf either way even if AUTORECONF=1 not given:

$(SED) 's|^\(GLIB_MKENUMS\)=.*|\1=$(STAGING_DIR_HOSTPKG)/bin/glib-mkenums|'
\
$(PKG_BUILD_DIR)/configure.ac
$(SED) 
's|^\(GDBUS_CODEGEN\)=.*|\1=$(STAGING_DIR_HOSTPKG)/bin/gdbus-codegen|'
\
$(PKG_BUILD_DIR)/configure.ac

Why are those lines in the Makefile? This looks like a hack to
workaround some build system error. Are we not using the correct
glib-mkenums or gdbus-codegen from staging if those lines are removed?

Both libmbim and libqmi also use glib-mkenums, and they don't have those lines.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


RE: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-07 Thread Amol Lad
Hi Aleksander, 

After commenting PKG_FIXUP:=autoreconf, I'm getting below error:

CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash 
/home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing
 aclocal-1.16 -I m4
/home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing:
 line 81: aclocal-1.16: command not found

OpenWrt "master" has automake version 1.15.1.

Any suggestion?

Amol

-Original Message-
From: ModemManager-devel  On 
Behalf Of Aleksander Morgado
Sent: Tuesday, 7 July 2020 12:20 PM
To: Nick 
Cc: ModemManager (development) 
Subject: Re: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

Hey Nick

> Fixed - Issue was resolved by including autoconf-archive in the Openwrt 
> toolchain, as demonstrated by this commit.
> https://github.com/openwrt/openwrt/commit/3c1d1d4332c7fbaccea01b92b28f
> 6d96f7222492
>

You're being forced to use autoconf-archive in the openwrt setup because the 
ModemManager package in openwrt has:
PKG_FIXUP:=autoreconf

None of libqmi, libmbim, ModemManager should require autoreconf if building 
from a source tarball, only when building from git. By explicitly running 
autoreconf, the build is trying to rebuild the configure script instead of 
using the provided one in the tarball.

I would definitely remove that line if possible. I think it was already removed 
from libqmi and libmbim packages.

--
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-07 Thread Aleksander Morgado
Hey Nick

> Fixed - Issue was resolved by including autoconf-archive in the Openwrt 
> toolchain, as demonstrated by this commit.
> https://github.com/openwrt/openwrt/commit/3c1d1d4332c7fbaccea01b92b28f6d96f7222492
>

You're being forced to use autoconf-archive in the openwrt setup
because the ModemManager package in openwrt has:
PKG_FIXUP:=autoreconf

None of libqmi, libmbim, ModemManager should require autoreconf if
building from a source tarball, only when building from git. By
explicitly running autoreconf, the build is trying to rebuild the
configure script instead of using the provided one in the tarball.

I would definitely remove that line if possible. I think it was
already removed from libqmi and libmbim packages.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel