Re: [ANNOUNCE] mod_perl-1.28
On Thu, 3 Jul 2003, Steve Hay wrote:
Philippe M. Chiasson wrote:
The URL
http://perl.apache.org/dist/mod_perl-1.28.tar.gz
has entered CPAN
I still get the same test failures that I reported before when
RC2 was announced:
modules/request...FAILED tests 3-8
Failed 6/10 tests, 40.00% okay
Setup: Windows XP, Perl 5.8.0, Apache 1.3.27, Apache-Test 1.03,
libapreq-1.2 (built/installed *after* mod_perl 1.28).
I used to have All tests successful under mp-1.27.
This may be a problem with libapreq - the mod_perl
t/modules/request.t tests, among other things, the sizes involved
with file uploads. The error log you posted earlier reported a
difference in these sizes for three (text) files, with a binary
(gif) file apparently OK (interestingly, with a patch I posted
earlier to allow Win32 ActivePerl 8xx to be used with mod_perl 1
(with LARGE_FILES support), I get a failure with the gif file,
but not the text files). Anyway, could you see if the following
helps (applied to the libapreq sources)? For me, this allows all
the mod_perl t/modules/request tests to pass.
Index: Request/Request.xs
===
RCS file: /home/cvs/httpd-apreq/Request/Request.xs,v
retrieving revision 1.36
diff -u -r1.36 Request.xs
--- Request/Request.xs 25 Jun 2003 07:59:37 - 1.36
+++ Request/Request.xs 4 Jul 2003 05:32:59 -
@@ -533,7 +533,7 @@
if (fd 0)
XSRETURN_UNDEF;
-if ( !(RETVAL = PerlIO_fdopen(fd, r)) )
+if ( !(RETVAL = PerlIO_fdopen(fd, rb)) )
XSRETURN_UNDEF;
#else
if ( ( RETVAL = PerlIO_importFILE(fp,0) ) == NULL )
@@ -558,7 +558,7 @@
PerlIO *fp;
fd = PerlLIO_dup(fd);
- if (!(fp = PerlIO_fdopen(fd, r))) {
+if (!(fp = PerlIO_fdopen(fd, rb))) {
PerlLIO_close(fd);
croak(fdopen failed!);
}
The first r - rb change (which affects the mod_perl tests)
is only relevant for Perl 5.7, which is why this problem didn't
arise on Win32 with Perl-5.6. Also, I think this r - rb
doesn't have any effect on Unix, but I haven't tested this.
--
best regards,
randy
Re: [ANNOUNCE] mod_perl-1.28
Hi Randy,
Randy Kobes wrote:
On Thu, 3 Jul 2003, Steve Hay wrote:
Philippe M. Chiasson wrote:
The URL
http://perl.apache.org/dist/mod_perl-1.28.tar.gz
has entered CPAN
I still get the same test failures that I reported before when
RC2 was announced:
modules/request...FAILED tests 3-8
Failed 6/10 tests, 40.00% okay
Setup: Windows XP, Perl 5.8.0, Apache 1.3.27, Apache-Test 1.03,
libapreq-1.2 (built/installed *after* mod_perl 1.28).
I used to have All tests successful under mp-1.27.
This may be a problem with libapreq - the mod_perl
t/modules/request.t tests, among other things, the sizes involved
with file uploads. The error log you posted earlier reported a
difference in these sizes for three (text) files, with a binary
(gif) file apparently OK (interestingly, with a patch I posted
earlier to allow Win32 ActivePerl 8xx to be used with mod_perl 1
(with LARGE_FILES support), I get a failure with the gif file,
but not the text files). Anyway, could you see if the following
helps (applied to the libapreq sources)? For me, this allows all
the mod_perl t/modules/request tests to pass.
Yes, this fixes it for me.
All the mod_perl 1.28 tests now pass (and all the libapreq 1.2 tests
still pass as well).
Thanks!
Steve
Index: Request/Request.xs
===
RCS file: /home/cvs/httpd-apreq/Request/Request.xs,v
retrieving revision 1.36
diff -u -r1.36 Request.xs
--- Request/Request.xs 25 Jun 2003 07:59:37 - 1.36
+++ Request/Request.xs 4 Jul 2003 05:32:59 -
@@ -533,7 +533,7 @@
if (fd 0)
XSRETURN_UNDEF;
-if ( !(RETVAL = PerlIO_fdopen(fd, r)) )
+if ( !(RETVAL = PerlIO_fdopen(fd, rb)) )
XSRETURN_UNDEF;
#else
if ( ( RETVAL = PerlIO_importFILE(fp,0) ) == NULL )
@@ -558,7 +558,7 @@
PerlIO *fp;
fd = PerlLIO_dup(fd);
- if (!(fp = PerlIO_fdopen(fd, r))) {
+if (!(fp = PerlIO_fdopen(fd, rb))) {
PerlLIO_close(fd);
croak(fdopen failed!);
}
The first r - rb change (which affects the mod_perl tests)
is only relevant for Perl 5.7, which is why this problem didn't
arise on Win32 with Perl-5.6. Also, I think this r - rb
doesn't have any effect on Unix, but I haven't tested this.
Re: [mp2 Patch] BUG with mod_deflate and $|=1 (20014:Error string not specified)
On Thu, 2003-07-03 at 01:24, Bill Marrs wrote:
This fixed the bug for me.
Great! Will commit it in the near future. (Can't seem to access the cvs
server right now, crappy internet cafe)
One thing that could help is if someone could take the time to write a
test for this bug.
Gozer out.
At 10:48 AM 7/2/2003, you wrote:
#define mpxs_output_flush(r, rcfg) \
/* if ($|) */ \
-if (IoFLUSH(PL_defoutgv)) { \
+if (bytes 0 IoFLUSH(PL_defoutgv)) { \
MP_FAILURE_CROAK(modperl_wbucket_flush(rcfg-wbucket, TRUE)); \
}
signature.asc
Description: This is a digitally signed message part
Re: [ANNOUNCE] mod_perl-1.28
On Thu, 2003-07-03 at 15:46, Steve Hay wrote: Hi Philippe, Philippe M. Chiasson wrote: The URL http://perl.apache.org/dist/mod_perl-1.28.tar.gz has entered CPAN I still get the same test failures that I reported before when RC2 was announced: modules/request...FAILED tests 3-8 Failed 6/10 tests, 40.00% okay Setup: Windows XP, Perl 5.8.0, Apache 1.3.27, Apache-Test 1.03, libapreq-1.2 (built/installed *after* mod_perl 1.28). I used to have All tests successful under mp-1.27. (I note that Apache::Reload didn't make it in either; I thought the plan was to put a backport of the version from mp2 into it?) After discussing this at length with Stas, we decided it would be simpler to release 1.28 as-is (since it's been almost a year since the last release) and quicken the release milestone of 1.29 to include Apache::Reltoad and a whole bunch of other 'controversial' unresolved issues. So, Apache::Reload did not make it, but: 1. it is on CPAN 2. Apache::StatINC is still in 3. mod_perl-1.29 will have Apache::Reload 4. mod_perl-1.29 will be released soon So, that's what it'll be for now folks ! Steve signature.asc Description: This is a digitally signed message part
Re: Content compression FAQ
Hi everyone, I've just updated the content at http://devl4.outlook.net/devdoc/FAQ/compression.html . It is supposed to be a final version, unless I missed something important. Please let me know then. Thanks, Slava
