Re: A year of accumulated patches

2000-01-14 Thread Tim Bunce

On Fri, Jan 14, 2000 at 07:28:22PM -0500, Daniel Jacobowitz wrote:
 
 The first really important one is a fix for the crashes I've been
 seeing in boot_DBI.  I can't find the exact message in the archive now,
 but anyone who reported that a problem was fixed by setting
 PERL_STARTUP_DONE_CHECK=1 in the environment probably wants this patch
 instead.  The problem was that a library (in this case libpg.so) called
 putenv() after perl was initialized but before perl's my_setenv got
 called.  Thus environ[] never got copied to malloc()'d memory, and
 trying to overwrite $ENV{TZ} caused a bogus free().  That's
 environment-mod_perl.c.

I've never looked at the mod_perl source code, but does it call
perl_parse() with a NULL for the env arg? If not it should.

Tim.



Re: A year of accumulated patches

2000-01-14 Thread Daniel Jacobowitz

On Sat, Jan 15, 2000 at 12:55:47AM +, Tim Bunce wrote:
 On Fri, Jan 14, 2000 at 07:28:22PM -0500, Daniel Jacobowitz wrote:
  
  The first really important one is a fix for the crashes I've been
  seeing in boot_DBI.  I can't find the exact message in the archive now,
  but anyone who reported that a problem was fixed by setting
  PERL_STARTUP_DONE_CHECK=1 in the environment probably wants this patch
  instead.  The problem was that a library (in this case libpg.so) called
  putenv() after perl was initialized but before perl's my_setenv got
  called.  Thus environ[] never got copied to malloc()'d memory, and
  trying to overwrite $ENV{TZ} caused a bogus free().  That's
  environment-mod_perl.c.
 
 I've never looked at the mod_perl source code, but does it call
 perl_parse() with a NULL for the env arg? If not it should.

Yes, it does.

Dan

/\  /\
|   Daniel Jacobowitz|__|SCS Class of 2002   |
|   Debian GNU/Linux Developer__Carnegie Mellon University   |
| [EMAIL PROTECTED] |  |   [EMAIL PROTECTED]  |
\/  \/