mod_perl.c:517: unterminated string or character constant

[Bill . Melvin]

Hi all ...

didnt know where else to send this so subscribed just now.
When compiling Apache 1.3.19 with mod_perl 1.25 and mod_ssl 2.8.1
I get the following:

...
=== src/modules/perl
gcc -fpic -O3 -I/usr/local/lib/perl5/5.00503/alpha-dec_osf/CORE -ansi
-I/usr/local/include -DLANGUAGE_C -DMOD_PERL_VERSION=\"1.25\"
-DMOD_PERL_STRING_VERSION=\"mod_perl/1.25\"  -I../../os/unix -I../../include
-DOSF1 -DMOD_SSL=208101 -DMOD_PERL -DUSE_HSREGEX -DEAPI -DUSE_EXPAT
-I../../lib/expat-lite `../../apaci` -c mod_perl.c  mv mod_perl.o mod_perl.lo
mod_perl.c:517: unterminated string or character constant
make[4]: *** [mod_perl.lo] Error 1
make[3]: *** [all] Error 1
make[2]: *** [subdirs] Error 1
make[2]: Leaving directory `/tmp/apache/build2/apache_1.3.19/src'
make[1]: *** [build-std] Error 2
make[1]: Leaving directory `/tmp/apache/build2/apache_1.3.19'
make: *** [build] Error 2

Particulars:
 perl 5.00503
 gcc 2.8.1
 Tru64 4.0F, no patches

A quick search on the geocrawler archive didnt turn up anything so
I decided to letter'rip. I know my gcc install is kinda funky but
it has installed mod_perl 3 times before w/out problems.

Anyway, stupid little patch that made it work for me is below.
It just brackets a comment in the #ifdef with /* ... */

So ... just in case anyone else searches the archives for this ...

/b

--- Begin Patch ---

# diff -c mod_perl.c.orig mod_perl.c
*** mod_perl.c.orig Mon Mar 12 16:43:25 2001
--- mod_perl.c  Mon Mar 12 16:39:04 2001
***
*** 510,520 
  array_header *librefs;

  #ifdef WIN32
! // This is here to stop a crash when bringing down
  // a service.  Apparently the dso is unloaded too early.
  // This if statement tests to see if we are running as a
  // service. apache does the same
! // see apache's isProcessService() in service.c
  if (AllocConsole()) {
  FreeConsole();
  return;
--- 510,520 
  array_header *librefs;

  #ifdef WIN32
! /* This is here to stop a crash when bringing down
  // a service.  Apparently the dso is unloaded too early.
  // This if statement tests to see if we are running as a
  // service. apache does the same
! // see apache's isProcessService() in service.c */
  if (AllocConsole()) {
  FreeConsole();
  return;
--- End Patch ---

Re: mod_perl.c:517: unterminated string or character constant

[sterling]

actually - with recent changes to the apache core, that patch doesn't work
any more.  we're working on a real fix - but in the mean time this one may
as well be removed.


sterling
_

Index: src/modules/perl/mod_perl.c
===
RCS file: /home/cvspublic/modperl/src/modules/perl/mod_perl.c,v
retrieving revision 1.135
diff -u -r1.135 mod_perl.c
--- src/modules/perl/mod_perl.c 2001/02/16 23:30:27 1.135
+++ src/modules/perl/mod_perl.c 2001/03/13 00:18:07
@@ -509,18 +509,6 @@
 { 
 array_header *librefs;
 
-#ifdef WIN32
-// This is here to stop a crash when bringing down
-// a service.  Apparently the dso is unloaded too early.
-// This if statement tests to see if we are running as a 
-// service. apache does the same
-// see apache's isProcessService() in service.c 
-if (AllocConsole()) {
-FreeConsole();
-return;
-} 
-#endif
-
 librefs = xs_dl_librefs((pool *)data);
 perl_shutdown(NULL, NULL);
 unload_xs_so(librefs);