Re: svn commit: r773881 - in /httpd/httpd/branches/2.2.x: CHANGES STATUS include/http_core.h modules/filters/mod_include.c server/config.c server/core.c

[Jeff Trawick]

On Thu, May 21, 2009 at 3:08 PM, William A. Rowe, Jr.
wrote:

> Jeff Trawick wrote:
> > Does somebody else care to share their opinion on this?  Which of these
> > are okay?
> >
> > - existing mod_perl releases (and potentially other third-party modules)
> > won't compile with 2.2.12
>
> CORE_PRIVATE may be broken from release to release, it's a necessary
> concession to prevent utter stagnation :(


The bits are not CORE_PRIVATE.

You can find sample Perl code on the web that even tests these bits, though
it isn't clear to me if that is a normal practice when using the
Perl/mod_include interface.

>
>
> I believe it was a mistake that this particular symbol/this particular
> directive is not a part of the mod_includes internals :(


Perhaps, though mod_include does have a plug-in interface and we have this
non-internal-detail-sounding function called ap_allow_options().  The
include option variants could be interesting to such a plug-in.



>
>
> So given we have a .23 mmn bump, perhaps document this in that section.
> But the actual behavior of this flag changes significantly and I can't
> see how to properly maintain mod_perl, deep internal compatibility.
>
>
The requirement is to fix combinations of option specifications in the main
conf file and .htaccess.  There's nothing incompatible with mod_perl there.
We just can't change the meaning of existing bits.

Re: svn commit: r773881 - in /httpd/httpd/branches/2.2.x: CHANGES STATUS include/http_core.h modules/filters/mod_include.c server/config.c server/core.c

[William A. Rowe, Jr.]

Jeff Trawick wrote:
> Does somebody else care to share their opinion on this?  Which of these
> are okay?
> 
> - existing mod_perl releases (and potentially other third-party modules)
> won't compile with 2.2.12

CORE_PRIVATE may be broken from release to release, it's a necessary
concession to prevent utter stagnation :(

I believe it was a mistake that this particular symbol/this particular
directive is not a part of the mod_includes internals :(

So given we have a .23 mmn bump, perhaps document this in that section.
But the actual behavior of this flag changes significantly and I can't
see how to properly maintain mod_perl, deep internal compatibility.

Re: svn commit: r773881 - in /httpd/httpd/branches/2.2.x: CHANGES STATUS include/http_core.h modules/filters/mod_include.c server/config.c server/core.c

[Jeff Trawick]

On Wed, May 20, 2009 at 8:53 AM, Joe Orton  wrote:

> On Sun, May 17, 2009 at 11:15:00AM -0400, Jeff Trawick wrote:
> > On Tue, May 12, 2009 at 9:17 AM,  wrote:
> >
> > > Author: covener
> > > Date: Tue May 12 13:17:29 2009
> > > New Revision: 773881
> > >
> > > URL: http://svn.apache.org/viewvc?rev=773881&view=rev
> > > Log:
> > > backport 772997, 773322, 773342 from trunk.
> > > Reviewed By: jorton, rpluem, covener
> > >
> > > Security fix for CVE-2009-1195: fix Options handling such that
> > > 'AllowOverride Options=IncludesNoExec' does not permit Includes with
> > > exec= enabled to be configured in an .htaccess file:
> > >
> > > * include/http_core.h: Change semantics of Includes/IncludeNoExec
> > >  options bits to be additive; OPT_INCLUDES now means SSI is enabled
> > >  without exec=.  OPT_INCLUDES|OPT_INC_WITH_EXEC means SSI is enabled
> > >  with exec=.
> >
> >
> > Current mod_perl tarballs reference OPT_INC_WITH_EXEC as part of mapping
> the
> > httpd API into perl, and the mod_perl build fails because of this.
> >
> > ("modperl_config.c", line 525: undefined symbol: OPT_INCNOEXEC)
>
> Ick :( For some reason I thought this was hidden by CORE_PRIVATE, for
> what little that's worth.
>
> > While I don't understand why the mod_perl mappings are created at release
> > time against who knows what httpd, it brings up an interesting httpd
> issue
> > anyway.
> >
> > If some module does have OPT_INCNOEXEC baked in (32), it matches what
> > 2.2.12+ thinks is OPT_INC_WITH_EXEC.  Similarly, the old
> OPT_INC_WITH_EXEC
> > (previously called OPT_INCLUDES), maps what 2.2.12+ thinks is
> > OPT_INCLUDES-without-exec.
> >
> > We could swap the values of OPT_INCLUDES and OPT_INC_WITH_EXEC to lessen
> the
> > chance of some theoretical module making the wrong decision.
> >
> > We can also define OPT_INCNOEXEC to something (either the new
> OPT_INCLUDES
> > or "Get your mod_perl patch at XXX").
>
> Given that the semantics of the options has changed, I don't think it's
> worth changing httpd to maintain any pretence of compile-time or
> run-time compatibility here.  Any code using the OPT_* constants as
> exposed by mod_perl cannot work as expected any more.
>
> Regards, Joe
>

Is the change in semantics required to fix the bug, or is it simply the
current implementation?

As these constants and the related ap_allow_options() have been exposed to
the C API for eons, and passed through in API mappings such as mod_perl, it
is worth making an alternate fix to avoid breaking module compiles and
(potentially) module misbehavior when upgrading from 2.2.11 to 2.2.12.

Unfortunately I don't have a patch :(

Does somebody else care to share their opinion on this?  Which of these are
okay?

- existing mod_perl releases (and potentially other third-party modules)
won't compile with 2.2.12
- existing Perl modules (and potentially other third-party modules) will
confuse include-with-exec and include-without-exec

Re: Problem with libapreq2-2.12

[Adam Prime]

There is a thread in apreq-dev about this issue:

http://marc.info/?l=apreq-dev&m=124276135127808&w=2

Apparently it has something to do with the machine that the tarball was 
built on.


Adam


mod_perl User wrote:

Hi,
 
While trying to install libapreq2-2.12 with mod_perl2/Apache2 in 
Solaris10, please help.
 
# make

Making all in .
Making all in include
make  all-am
Making all in library
make  all-am
Making all in module
Making all in apache2
make: Fatal error: Don't know how to make target `all-local'
Current working directory /export/home/webadm/libapreq2-2.12/module/apache2
*** Error code 1
The following command caused the error:
set fnord $MAKEFLAGS; amf=$2; \
dot_seen=no; \
target=`echo all-recursive | sed s/-recursive//`; \
list='apache2'; for subdir in $list; do \
  echo "Making $target in $subdir"; \
  if test "$subdir" = "."; then \
dot_seen=yes; \
local_target="$target-am"; \
  else \
local_target="$target"; \
  fi; \
  (cd $subdir && make  $local_target) \
   || case "$amf" in *=*) exit 1;; *k*) fail=yes;; *) exit 1;; esac; \
done; \
if test "$dot_seen" = "no"; then \
  make  "$target-am" || exit 1; \
fi; test -z "$fail"
make: Fatal error: Command failed for target `all-recursive'
Current working directory /export/home/webadm/libapreq2-2.12/module
*** Error code 1
The following command caused the error:
set fnord $MAKEFLAGS; amf=$2; \
dot_seen=no; \
target=`echo all-recursive | sed s/-recursive//`; \
list='. include library module glue'; for subdir in $list; do \
  echo "Making $target in $subdir"; \
  if test "$subdir" = "."; then \
dot_seen=yes; \
local_target="$target-am"; \
  else \
local_target="$target"; \
  fi; \
  (cd $subdir && make  $local_target) \
   || case "$amf" in *=*) exit 1;; *k*) fail=yes;; *) exit 1;; esac; \
done; \
if test "$dot_seen" = "no"; then \
  make  "$target-am" || exit 1; \
fi; test -z "$fail"
make: Fatal error: Command failed for target `all-recursive'



MSN Quiz Test your skill and wits on this revered battleground of 
knowledge IMing with Windows Live Messenger just got better. 

Problem with libapreq2-2.12

[mod_perl User]

Hi,

 

While trying to install libapreq2-2.12 with mod_perl2/Apache2 in Solaris10, 
please help.

 

# make
Making all in .
Making all in include
make  all-am
Making all in library
make  all-am
Making all in module
Making all in apache2
make: Fatal error: Don't know how to make target `all-local'
Current working directory /export/home/webadm/libapreq2-2.12/module/apache2
*** Error code 1
The following command caused the error:
set fnord $MAKEFLAGS; amf=$2; \
dot_seen=no; \
target=`echo all-recursive | sed s/-recursive//`; \
list='apache2'; for subdir in $list; do \
  echo "Making $target in $subdir"; \
  if test "$subdir" = "."; then \
dot_seen=yes; \
local_target="$target-am"; \
  else \
local_target="$target"; \
  fi; \
  (cd $subdir && make  $local_target) \
   || case "$amf" in *=*) exit 1;; *k*) fail=yes;; *) exit 1;; esac; \
done; \
if test "$dot_seen" = "no"; then \
  make  "$target-am" || exit 1; \
fi; test -z "$fail"
make: Fatal error: Command failed for target `all-recursive'
Current working directory /export/home/webadm/libapreq2-2.12/module
*** Error code 1
The following command caused the error:
set fnord $MAKEFLAGS; amf=$2; \
dot_seen=no; \
target=`echo all-recursive | sed s/-recursive//`; \
list='. include library module glue'; for subdir in $list; do \
  echo "Making $target in $subdir"; \
  if test "$subdir" = "."; then \
dot_seen=yes; \
local_target="$target-am"; \
  else \
local_target="$target"; \
  fi; \
  (cd $subdir && make  $local_target) \
   || case "$amf" in *=*) exit 1;; *k*) fail=yes;; *) exit 1;; esac; \
done; \
if test "$dot_seen" = "no"; then \
  make  "$target-am" || exit 1; \
fi; test -z "$fail"
make: Fatal error: Command failed for target `all-recursive'


_
Drag n’ drop—Get easy photo sharing with Windows Live™ Photos.

http://www.microsoft.com/india/windows/windowslive/photos.aspx