Re: Bug#509457: [BUG] mod_perl2 test failures (when building Debian package)
Adam Prime wrote: mod_perl 1 is affected by this as well. This is actually the same bug i ran reported in this thread: Attached is a patch against the 1.x svn branch which resolves the problem there as well using the same technique the Niko used for TestRequest.pm Committed 729185 http://svn.apache.org/viewvc?rev=729185&view=rev -- 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollu...@p6m7g8.com) c: 703.336.9354 Consultant - P6M7G8 Inc.http://p6m7g8.net Director IT - RideCharge, Inc. http://ridecharge.com Contractor - PositiveEnergyUSA http://positiveenergyusa.com ASF Member - Apache Software Foundation http://apache.org FreeBSD Committer - FreeBSD Foundation http://freebsd.org Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.
Re: Bug#509457: [BUG] mod_perl2 test failures (when building Debian package)
Philip M. Gollucci wrote:
Niko Tyni wrote:
On Mon, Dec 22, 2008 at 10:47:18AM -0600, Gunnar Wolf wrote:
The attached patch works around the problem by providing a credentials()
wrapper too. It's probably not quite correct, but the tests pass with
this on both libwww-perl 5.813 and 5.822.
Committed revision 728811.
http://svn.apache.org/viewvc?rev=728811&view=rev
Thanks!
mod_perl 1 is affected by this as well. This is actually the same bug i
ran reported in this thread:
http://marc.info/?l=apache-modperl&m=122886595126742&w=2
Attached is a patch against the 1.x svn branch which resolves the
problem there as well using the same technique the Niko used for
TestRequest.pm
Adam
Index: t/internal/auth.t
===
--- t/internal/auth.t (revision 729005)
+++ t/internal/auth.t (working copy)
@@ -28,6 +28,7 @@
@creds = qw(dougm mod_perl);
sub get_basic_credentials { shift->creds }
+sub credentials { shift->creds }
sub creds {
shift;
Re: Bug#509457: [BUG] mod_perl2 test failures (when building Debian package)
Niko Tyni wrote: On Mon, Dec 22, 2008 at 10:47:18AM -0600, Gunnar Wolf wrote: The attached patch works around the problem by providing a credentials() wrapper too. It's probably not quite correct, but the tests pass with this on both libwww-perl 5.813 and 5.822. Committed revision 728811. http://svn.apache.org/viewvc?rev=728811&view=rev Thanks! -- Philip M. Gollucci (pgollu...@p6m7g8.com) c: 703.336.9354 Consultant - P6M7G8 Inc. http://p6m7g8.net Senior System Admin - RideCharge, Inc. http://ridecharge.com 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.
Re: Bug#509457: [BUG] mod_perl2 test failures (when building Debian package)
On Mon, Dec 22, 2008 at 10:47:18AM -0600, Gunnar Wolf wrote:
> I am a member of the Debian pkg-perl group [1]. I stumbled upon a test
> failure when rebuilding - For further information on my build
> environment, please refer to the bug report in the Debian BTS [2].
>
> The test failure appears on hooks/authz.t:
>
> Test Summary Report
> ---
> t/hooks/authz (Wstat: 0 Tests: 4 Failed: 1)
> Failed test: 4
This broke when libwww-perl was upgraded from 5.813 to 5.820.
It still happens with the current version, 5.822.
This changelog entry seems relevant:
2008-09-24 Release 5.815
[...]
Also thanks to contributions by Bron Gondwana LWP's Basic/Digest
authenticate modules now registers handlers which allow them to
automatically fill in the Authorization headers without first taking
the round-trip of a 401 response when LWP knows the credentials for a
given realm.
My limited understanding of this is that it's a bug in LWP: the
new handler installed by LWP::Authen::Basic::authenticate() uses
$ua->credentials() instead of $ua->get_basic_credentials(). However,
the LWP::UserAgent documentation recommends that subclasses override
just get_basic_credentials(), and that's what Apache::TestRequest
currently does.
The attached patch works around the problem by providing a credentials()
wrapper too. It's probably not quite correct, but the tests pass with
this on both libwww-perl 5.813 and 5.822.
--
Niko Tyni nt...@debian.org
Index: Apache-Test/lib/Apache/TestRequest.pm
===
--- Apache-Test/lib/Apache/TestRequest.pm (revision 28483)
+++ Apache-Test/lib/Apache/TestRequest.pm (working copy)
@@ -256,6 +256,11 @@
$self;
}
+sub credentials {
+my $self = shift;
+return $self->get_basic_credentials(@_);
+}
+
sub get_basic_credentials {
my($self, $realm, $uri, $proxy) = @_;
