Re: cvs commit: modperl/t/net/perl util.pl

2002-03-25 Thread Eric Cholet

--On Sunday, March 24, 2002 21:57:54 + [EMAIL PROTECTED] wrote:

 dougm   02/03/24 13:57:53

   Modified:.Changes STATUS
src/modules/perl Util.xs
t/net/perl util.pl
   Log:
   Submitted by:   Geoff Young [EMAIL PROTECTED]
   Reviewed by:dougm
   properly escape highbit chars in Apache::Utils::escape_html

This is uncool for those of us using a non-ASCII encoding and sending
out lots of characters with the 8th bit set, e.g. in a French page
many accented characters will be replaced by 6-byte sequences.
If I'm sending out Content-type: text/html; charset=ISO-8859-1,
and calling escape_html to escape '', '' and the like, I'm going
to be serving quite a lot more bytes than before this patch.

However escape_html () has no clue as to what the character set is,
and whether it has been correctly specified in the Content-Type.
It has also be mentionned here that escape_html is only valid for
single-byte encodings.

So this patch does the right thing to escape the odd 8 bit char in
a mostly ASCII output, but users of other charsets should be warned
not to use it. I use HTML::Entities::encode($_[0], '') myself.

Therefore I propose a doc patch to clear this up:

Index: Util.pm
===
RCS file: /home/cvs/modperl/Util/Util.pm,v
retrieving revision 1.8
diff -u -r1.8 Util.pm
--- Util.pm 4 Mar 2000 20:55:47 -   1.8
+++ Util.pm 25 Mar 2002 18:19:37 -
@@ -68,6 +68,13 @@

  my $esc = Apache::Util::escape_html($html);

+This function is unaware of its argument's character set and encoding.
+It assumes a single-byte encoding and escapes all characters with the
+8th bit set. Do not use it with multi-byte encodings such as utf8.
+When using a single byte non-ASCII encoding such as ISO-8859-1,
+consider specifying the character set in the Content-Type header,
+and using HTML::Entities to avoid unnecessary escaping.
+
 =item escape_uri

 This function replaces all unsafe characters in the $string with their


--
Eric Cholet




Re: cvs commit: modperl/t/net/perl util.pl

2002-03-25 Thread Eric Cholet



--On Monday, March 25, 2002 10:29:11 -0800 Doug MacEachern 
[EMAIL PROTECTED] wrote:

 i had a bad feeling about this.  we should not be implementing
 escape_html  to begin with, the functionality should all be in apache.
 i'm going to  back out the patch.  anybody care to make a doc patch to
 explain the  problems with escape_html before the patch went in?  thanks.

I believe the patch is useful though, in cases where the charset is not 
explicitely
specified and there's an odd character with the 8th bit set it will now do 
the
right thing. I guess a lot of US coders would fall in that situation... I 
suppose
it's faster than HTML::Entities (I haven't benchmarked it though).
So I suspect the patch will fix more situations than it breaks: if using
a single-byte non-ASCII encoding, it doesn't actually break anything, just 
adds
bloat. If using a multi-byte encoding escape_html was broken/inapplicable 
already.


--
Eric Cholet




cvs commit: modperl/Apache Apache.pm

2001-12-28 Thread cholet

cholet  01/12/28 02:25:48

  Modified:Apache   Apache.pm
  Log:
  more docco
  
  Revision  ChangesPath
  1.66  +23 -7 modperl/Apache/Apache.pm
  
  Index: Apache.pm
  ===
  RCS file: /home/cvs/modperl/Apache/Apache.pm,v
  retrieving revision 1.65
  retrieving revision 1.66
  diff -u -r1.65 -r1.66
  --- Apache.pm 2001/12/27 15:44:33 1.65
  +++ Apache.pm 2001/12/28 10:25:48 1.66
  @@ -650,15 +650,29 @@
   authentication realm, from C$r-Egtauth_name, to determine which set of
   credentials to authenticate.
   
  -=item $r-document_root
  +=item $r-document_root ( [$docroot] )
   
  -Returns a reference to the current value of the per server
  -configuration directive BDocumentRoot. To quote the Apache server
  -documentation, Unless matched by a directive like Alias, the server
  -appends the path from the requested URL to the document root to make
  -the path to the document.  This same value is passed to CGI
  +When called with no argument, returns a reference to the current value
  +of the per server configuration directive BDocumentRoot. To quote the
  +Apache server documentation, Unless matched by a directive like Alias,
  +the server appends the path from the requested URL to the document root
  +to make the path to the document.  This same value is passed to CGI
   scripts in the CDOCUMENT_ROOT environment variable.
   
  +You can also set this value by providing an argument to it. The following
  +example dynamically sets the document root based on the request's
  +Host: header:
  +
  +   sub trans_handler
  + {
  +my $r = shift;
  +my ($user) = ($r-header_in('Host') =~ /^[^\.]+/);
  +$r-document_root(/home/$user/www);
  +return DECLINED;
  + }
  +
  +   PerlTransHandler trans_handler
  +
   =item $r-allow_options
   
   The C$r-Egtallow_options method can be used for
  @@ -960,7 +974,9 @@
   =item $r-no_cache( $boolean )
   
   This is a flag that indicates that the data being returned is volatile
  -and the client should be told not to cache it.
  +and the client should be told not to cache it. C$r-Egtno_cache(1)
  +adds the headers Pragma: no-cache and Cache-control: no-cache to
  +the reponse, therefore it must be called before C$r-Egtsend_http_header.
   
   =item $r-print( @list )
   
  
  
  



cvs commit: modperl/Apache Apache.pm

2001-12-27 Thread cholet

cholet  01/12/27 07:44:33

  Modified:Apache   Apache.pm
  Log:
  document current_callback()
  
  Revision  ChangesPath
  1.65  +9 -0  modperl/Apache/Apache.pm
  
  Index: Apache.pm
  ===
  RCS file: /home/cvs/modperl/Apache/Apache.pm,v
  retrieving revision 1.64
  retrieving revision 1.65
  diff -u -r1.64 -r1.65
  --- Apache.pm 2001/05/01 17:28:34 1.64
  +++ Apache.pm 2001/12/27 15:44:33 1.65
  @@ -776,6 +776,15 @@
   
$r-push_handlers( PerlHandler = \footer);
   
  +=item $r-current_callback
  +
  +Returns the name of the handler currently being run. This method is most
  +useful to PerlDispatchHandlers who wish to only take action for certain phases.
  +
  + if($r-current_callback eq PerlLogHandler) {
  + $r-warn(Logging request);
  + }
  +
   =back
   
   =head1 SETTING UP THE RESPONSE
  
  
  



Re: cvs commit: modperl-site/guide download.html

2001-07-17 Thread Eric Cholet
  modperl-site/guide/download.html

   Index: download.html
   ===
   RCS file: /home/cvs/modperl-site/guide/download.html,v
   retrieving revision 1.16
   retrieving revision 1.17
   diff -u -r1.16 -r1.17
   --- download.html   2001/04/27 16:57:12 1.16
   +++ download.html   2001/07/17 15:16:38 1.17
   @@ -172,9 +172,9 @@
P
Every Apache project rolls a new tar.gz snapshot of the latest CVS
version every 6 hours. You can grab the latest mod_perl CVS snapshot
from A
   -HREF=http://perl.apache.org/from-cvs/modperl/;http://perl.apache.org
   /from-cvs/modperl//A,
   +HREF=http:/cvs.apache.org/snapshots/modperl/http:/cvs.apache.org/sn
   apshots/modperl//A, all the mod_perl related projects are available
from A
   -HREF=http://perl.apache.org/from-cvs.;http://perl.apache.org/from-cv
   s./A
   +HREF=http:/cvs.apache.org/snapshots.http:/cvs.apache.org/snapshots.
   /A


P






--
Eric Cholet
B995 E519 1594 10D0 4271 1EA5 8DF3 8004



cvs commit: modperl/t/net/perl/io redir1.pl redir2.pl

2001-07-16 Thread cholet

cholet  01/07/16 10:11:04

  Modified:t/internal redirect.t
  Added:   t/net/perl/io redir1.pl redir2.pl
  Log:
  add internal_redirect test
  
  Revision  ChangesPath
  1.5   +12 -3 modperl/t/internal/redirect.t
  
  Index: redirect.t
  ===
  RCS file: /home/cvs/modperl/t/internal/redirect.t,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- redirect.t1999/02/23 19:21:38 1.4
  +++ redirect.t2001/07/16 17:11:04 1.5
  @@ -22,7 +22,7 @@
   
   my($request,$response);
   
  -my $tests = 3;
  +my $tests = 4;
   
   $CGI::VERSION ||= 0;
   
  @@ -64,6 +64,15 @@
   
   print content=`, $response-content, '\n;
   
  +#test internal redirect
  +$request = HTTP::Request-new(GET = 
http://$net::httpserver$net::perldir/io/redir1.pl;);
  +$response = $ua-request($request, undef, undef);
  +unless ($response-content eq 'OK') {
  +print not ;
  +}
  +print ok 4\n;
  +print content=`, $response-content, '\n;
  +
   if ($qredirect) {
   
   $request = HTTP::Request-new(GET = $qredirect);
  @@ -73,7 +82,7 @@
   print not ;
   }
   
  -print ok 4\n;
  +print ok 5\n;
   
   print content=`, $response-content, '\n;
   
  @@ -85,7 +94,7 @@
   print not ;
   }
   
  -print ok 5\n;
  +print ok 6\n;
   
   print content=`, $response-content, '\n;
   
  
  
  
  1.1  modperl/t/net/perl/io/redir1.pl
  
  Index: redir1.pl
  ===
  use strict;
  my $r = shift;
  $r-internal_redirect('/perl/io/redir2.pl');
  
  
  
  1.1  modperl/t/net/perl/io/redir2.pl
  
  Index: redir2.pl
  ===
  use strict;
  my $r = shift;
  $r-send_http_header('text/plain');
  print OK;
  
  
  



cvs commit: modperl apache-modlist.html

2001-02-13 Thread cholet

cholet  01/02/13 07:52:56

  Modified:.apache-modlist.html
  Log:
  remove unreleased module
  
  Revision  ChangesPath
  1.80  +1 -2  modperl/apache-modlist.html
  
  Index: apache-modlist.html
  ===
  RCS file: /home/cvs/modperl/apache-modlist.html,v
  retrieving revision 1.79
  retrieving revision 1.80
  diff -u -r1.79 -r1.80
  --- apache-modlist.html   2000/10/13 16:44:46 1.79
  +++ apache-modlist.html   2001/02/13 15:52:55 1.80
  @@ -6,7 +6,7 @@
   h1The Apache/Perl Module List/h1
   
   Maintained by a href="mailto:[EMAIL PROTECTED]"Doug MacEachern/a,
  -bri $Revision: 1.79 $ $Date: 2000/10/13 16:44:46 $/i
  +bri $Revision: 1.80 $ $Date: 2001/02/13 15:52:55 $/i
   
   h3Contents/h3
   a href="#intro"Introduction/abr
  @@ -66,7 +66,6 @@
   Apache::
   
   * PerlHandler's
  -AdBanner cdpfAd banner server    CHOLET
   AddrMungebdpfMunge email addresses in webpages   MJD
   AutoIndexRdcfLists directory content GOZER
   Archive  bdpfMake linked contents pages of .tar(.gz) JPETERSON
  
  
  



cvs commit: modperl-site/dist apache-modlist.html

2001-02-13 Thread cholet

cholet  01/02/13 07:54:05

  Modified:dist apache-modlist.html
  Log:
  remove unreleased module
  
  Revision  ChangesPath
  1.19  +1 -2  modperl-site/dist/apache-modlist.html
  
  Index: apache-modlist.html
  ===
  RCS file: /home/cvs/modperl-site/dist/apache-modlist.html,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- apache-modlist.html   2000/10/13 16:49:07 1.18
  +++ apache-modlist.html   2001/02/13 15:54:05 1.19
  @@ -6,7 +6,7 @@
   h1The Apache/Perl Module List/h1
   
   Maintained by a href="mailto:[EMAIL PROTECTED]"Doug MacEachern/a,
  -bri $Revision: 1.18 $ $Date: 2000/10/13 16:49:07 $/i
  +bri $Revision: 1.19 $ $Date: 2001/02/13 15:54:05 $/i
   
   h3Contents/h3
   a href="#intro"Introduction/abr
  @@ -66,7 +66,6 @@
   Apache::
   
   * PerlHandler's
  -AdBanner cdpfAd banner server    CHOLET
   AddrMungebdpfMunge email addresses in webpages   MJD
   AutoIndexRdcfLists directory content GOZER
   Archive  bdpfMake linked contents pages of .tar(.gz) JPETERSON
  
  
  



cvs snapshots

2000-08-17 Thread Eric Cholet

We no longer have cvs snapshots in http://dev.apache.org/from-cvs/
There's only httpd in there.
(we link to this from http://perl.apache.org/distributions.html)

--
Eric Cholet





cvs commit: modperl/src/modules/perl Apache.xs

2000-07-25 Thread cholet

cholet  00/07/25 10:59:49

  Modified:.Changes
   src/modules/perl Apache.xs
  Log:
  return code from stat() call was being ignored
  
  Revision  ChangesPath
  1.502 +3 -0  modperl/Changes
  
  Index: Changes
  ===
  RCS file: /home/cvs/modperl/Changes,v
  retrieving revision 1.501
  retrieving revision 1.502
  diff -u -r1.501 -r1.502
  --- Changes   2000/07/24 13:22:50 1.501
  +++ Changes   2000/07/25 17:59:45 1.502
  @@ -10,6 +10,9 @@
   
   =item 1.24_01-dev
   
  +flush r-finfo cache if r-filename fails
  +[Roger Espel Llima [EMAIL PROTECTED]]
  +
   fix per-dir merging of PerlSetupEnv [Eric Cholet [EMAIL PROTECTED]]
   
   INSTALL.raven update [Adam Qualset [EMAIL PROTECTED]]
  
  
  
  1.99  +3 -1  modperl/src/modules/perl/Apache.xs
  
  Index: Apache.xs
  ===
  RCS file: /home/cvs/modperl/src/modules/perl/Apache.xs,v
  retrieving revision 1.98
  retrieving revision 1.99
  diff -u -r1.98 -r1.99
  --- Apache.xs 2000/06/05 18:18:49 1.98
  +++ Apache.xs 2000/07/25 17:59:48 1.99
  @@ -1870,7 +1870,9 @@
   get_set_PVp(r-filename,r-pool);
   #ifndef WIN32
   if(items  1)
  - stat(r-filename, r-finfo);
  + if ((laststatval = stat(r-filename, r-finfo))  0) {
  +r-finfo.st_mode = 0;
  + }
   #endif
   
   OUTPUT:
  
  
  



cvs commit: modperl/src/modules/perl mod_perl.h perl_config.c

2000-07-24 Thread cholet

cholet  00/07/24 06:33:03

  Modified:src/modules/perl mod_perl.h perl_config.c
  Log:
  revert my latest change, my editor suddenly decided to untabify everything, burying 
the actual change
  
  Revision  ChangesPath
  1.100 +34 -34modperl/src/modules/perl/mod_perl.h
  
  Index: mod_perl.h
  ===
  RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.h,v
  retrieving revision 1.99
  retrieving revision 1.100
  diff -u -r1.99 -r1.100
  --- mod_perl.h2000/07/24 13:22:55 1.99
  +++ mod_perl.h2000/07/24 13:33:00 1.100
  @@ -64,7 +64,7 @@
   #include malloc.h
   #include win32.h
   #include win32iop.h
  -#include fcntl.h  // For O_BINARY
  +#include fcntl.h   // For O_BINARY
   #include "EXTERN.h"
   #include "perl.h"
   #include iperlsys.h
  @@ -195,7 +195,7 @@
   #endif
   
   #ifndef AvFILLp
  -#define AvFILLp(av) ((XPVAV*)  SvANY(av))-xav_fill
  +#define AvFILLp(av)  ((XPVAV*)  SvANY(av))-xav_fill
   #endif
   
   #ifdef eval_pv
  @@ -300,7 +300,7 @@
   #define av_copy_array(av) av_make(av_len(av)+1, AvARRAY(av))  
   
   #ifndef newRV_noinc
  -#define newRV_noinc(sv) ((Sv = newRV(sv)), --SvREFCNT(SvRV(Sv)), Sv)
  +#define newRV_noinc(sv)  ((Sv = newRV(sv)), --SvREFCNT(SvRV(Sv)), Sv)
   #endif
   
   #ifndef SvTAINTED_on
  @@ -349,14 +349,14 @@
   
   #define mp_debug mod_perl_debug_flags
   
  -extern U32  mp_debug;
  +extern U32   mp_debug;
   
   #ifdef PERL_TRACE
  -#define MP_TRACE(a)   if (mp_debug)  a
  -#define MP_TRACE_d(a) if (mp_debug  1)  a /* directives */
  -#define MP_TRACE_s(a) if (mp_debug  2)  a /* perl sections */
  -#define MP_TRACE_h(a) if (mp_debug  4)  a /* handlers */
  -#define MP_TRACE_g(a) if (mp_debug  8)  a /* globals and allocation */
  +#define MP_TRACE(a)   if (mp_debug)   a
  +#define MP_TRACE_d(a) if (mp_debug  1)   a /* directives */
  +#define MP_TRACE_s(a) if (mp_debug  2)   a /* perl sections */
  +#define MP_TRACE_h(a) if (mp_debug  4)   a /* handlers */
  +#define MP_TRACE_g(a) if (mp_debug  8)   a /* globals and allocation */
   #define MP_TRACE_c(a) if (mp_debug  16) a /* directive handlers */
   #ifndef PERL_MARK_WHERE
   #define PERL_MARK_WHERE
  @@ -405,14 +405,14 @@
   #define MPf_Off -1
   #define MPf_None 0
   
  -#define MPf_INCPUSH 0x0100 /* use lib split ":", $ENV{PERL5LIB} */
  -#define MPf_SENDHDR 0x0200 /* is PerlSendHeader On? */
  -#define MPf_SENTHDR 0x0400 /* has PerlSendHeader sent the headers? */
  -#define MPf_ENV 0x0800 /* PerlSetupEnv */
  -#define MPf_HASENV  0x1000 /* do we have any PerlSetEnv's? */
  -#define MPf_DSTDERR 0x2000 /* redirect stderr to error_log */
  -#define MPf_CLEANUP 0x4000 /* did we register our cleanup ? */
  -#define MPf_RCLEANUP0x8000 /* for $r-register_cleanup */
  +#define MPf_INCPUSH  0x0100 /* use lib split ":", $ENV{PERL5LIB} */
  +#define MPf_SENDHDR  0x0200 /* is PerlSendHeader On? */
  +#define MPf_SENTHDR  0x0400 /* has PerlSendHeader sent the headers? */
  +#define MPf_ENV  0x0800 /* PerlSetupEnv */
  +#define MPf_HASENV   0x1000 /* do we have any PerlSetEnv's? */
  +#define MPf_DSTDERR  0x2000 /* redirect stderr to error_log */
  +#define MPf_CLEANUP  0x4000 /* did we register our cleanup ? */
  +#define MPf_RCLEANUP 0x8000 /* for $r-register_cleanup */
   
   #define MP_FMERGE(new,add,base,f) \
   if((add-flags  f) || (base-flags  f)) \
  @@ -442,7 +442,7 @@
   #define MP_ENV_off(d)(d-flags  = ~MPf_ENV)
   #endif
   
  -#define MP_ENV(d)   (d-SetupEnv != MPf_Off)
  +#define MP_ENV(d)   (d-SetupEnv == MPf_On)
   #define MP_ENV_on(d)(d-SetupEnv = MPf_On)
   #define MP_ENV_off(d)   (d-SetupEnv = MPf_Off)
   
  @@ -535,13 +535,13 @@
   
   #define HAS_CONTEXT MODULE_MAGIC_AT_LEAST(MMN_136,2)
   #if HAS_CONTEXT
  -#define CAN_SELF_BOOT_SECTIONS  (PERL_SECTIONS_SELF_BOOT)
  -#define SECTION_ALLOWED OR_ALL
  -#define USABLE_CONTEXT  parms-context
  -#else
  -#define CAN_SELF_BOOT_SECTIONS  ((parms-path==NULL)PERL_SECTIONS_SELF_BOOT)
  -#define SECTION_ALLOWED RSRC_CONF
  -#define USABLE_CONTEXT  parms-server-lookup_defaults
  +#define CAN_SELF_BOOT_SECTIONS   (PERL_SECTIONS_SELF_BOOT)
  +#define SECTION_ALLOWED  OR_ALL
  +#define USABLE_CONTEXT   parms-context
  +#else
  +#define CAN_SELF_BOOT_SECTIONS   ((parms-path==NULL)PERL_SECTIONS_SELF_BOOT)
  +#define SECTION_ALLOWED  RSRC_CONF
  +#define USABLE_CONTEXT   parms-server-lookup_defaults
   #endif
   
   #define APACHE_SSL_12X (defined(APACHE_SSL)  (MODULE_MAGIC_NUMBER  MMN_130))
  @@ -598,7 +598,7 @@
   "access to %s failed for %s, reason: %s", \
   file, \
   get_remote_host(r-connection, \
  -r-per_dir_config, REMOTE_NAME), \
  +

Re: jim's design

2000-06-18 Thread Eric Cholet

On Sun, Jun 18, 2000 at 03:02:25AM -0700, brian moseley wrote:
 
 .. is ready to go. i can go ahead and update index.html, and
 jim's also updated several of the pages linked from there.
 but some of the others haven't been updated - should i do
 them all, or should i just do index.html and see what people
 think, or..?
 
 speaking of which - is there an automated process that
 updates /www/perl.apache.org from the modperl-site cvs
 module? or do i need to copy things by hand?

cd /da1/www/perl.apache.org  cvs update

 
 -- Forwarded message --
 Date: Fri, 16 Jun 2000 14:25:47 -0700
 From: James Home [EMAIL PROTECTED]
 To: [EMAIL PROTECTED]
 Subject: did I send you this?
 
 
 http://thisishomemade.com/clients/modperl/site

very nice, +1

 let me know if you need something more from me with regards to this!
 
   - J.
 -- 
 
  James Home - [EMAIL PROTECTED]
  http://www.superdeluxe.com
  http://www.vagabondage.com
 
 "There is absolutely no inevitability as long as there is a 
 willingness to contemplate what is happening." - Marshall McLuhan
 
 

-- 
Eric Cholet



cvs commit: modperl/Apache Apache.pm

2000-06-15 Thread cholet

cholet  00/06/15 01:13:37

  Modified:Apache   Apache.pm
  Log:
  backing out $Apache::Server::ConfigTestOnly documentation
  
  Revision  ChangesPath
  1.51  +0 -17 modperl/Apache/Apache.pm
  
  Index: Apache.pm
  ===
  RCS file: /home/cvs/modperl/Apache/Apache.pm,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -r1.50 -r1.51
  --- Apache.pm 2000/05/19 10:06:07 1.50
  +++ Apache.pm 2000/06/15 08:13:36 1.51
  @@ -1128,23 +1128,6 @@
   
   Set to true when the server is starting.
   
  -=item $Apache::Server::ConfigTestOnly
  -
  -Set to true when the server is running in configuration test mode
  -(Chttpd -t).
  -
  -   Perl
  -# don't continue if it's a config test!
  -print("Skipping the Perl code!\n"),
  -return if $Apache::Server::ConfigTestOnly;
  -   
  -print "Running the Perl code!\n"
  -# some code here
  -   
  -   /Perl
  -
  -This variable is not available under Win32.
  -
   =back
   
   =head1 SEE ALSO
  
  
  



cvs commit: modperl Changes

2000-06-05 Thread cholet

cholet  00/06/05 08:42:06

  Modified:.Changes
  Log:
  document my latest fix
  
  Revision  ChangesPath
  1.496 +3 -0  modperl/Changes
  
  Index: Changes
  ===
  RCS file: /home/cvs/modperl/Changes,v
  retrieving revision 1.495
  retrieving revision 1.496
  diff -u -r1.495 -r1.496
  --- Changes   2000/06/01 21:17:44 1.495
  +++ Changes   2000/06/05 15:41:50 1.496
  @@ -10,6 +10,9 @@
   
   =item 1.24_01-dev
   
  +fix for 'sub handler : method {}' support when method is not found
  +[Eric Cholet [EMAIL PROTECTED]]
  +
   Apache::ExtUtils will now generate and END routine to call
   ap_remove_module() [Christopher Chan-N [EMAIL PROTECTED]]
   
  
  
  



Re: cvs commit: modperl/src/modules/perl mod_perl.c

2000-06-03 Thread Eric Cholet

On Sat, Jun 03, 2000 at 01:57:26PM -0700, Ask Bjoern Hansen wrote:
 On 2 Jun 2000 [EMAIL PROTECTED] wrote:
 
Modified:src/modules/perl mod_perl.c
Log:
fix segfault
 
 Don't forget to update Changes.
 

I need some help explaining this change. 
Here's what happened:

% cat t/docs/Foo.pm
package foo;
sub handler { warn 'foo' } 
1;

notice the typo, the package declaration says 'foo' instead of 'Foo'

% cat t/conf/httpd.conf
Location /foo
PerlHandler Foo
SetHandler perl-script
/Location

GET /foo will trigger the segfault. Well, under 5.00502 it does, but under 5.6
I get an (expected) 500 internal server error. 

-- 
Eric Cholet



cvs commit: modperl SUPPORT

2000-06-02 Thread cholet

cholet  00/06/02 10:06:39

  Modified:.SUPPORT
  Log:
  add Doug's snippet about spinning processes
  
  Revision  ChangesPath
  1.15  +11 -0 modperl/SUPPORT
  
  Index: SUPPORT
  ===
  RCS file: /home/cvs/modperl/SUPPORT,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- SUPPORT   2000/03/03 00:30:52 1.14
  +++ SUPPORT   2000/06/02 17:06:38 1.15
  @@ -157,5 +157,16 @@
   
   Rebuild httpd/mod_perl with PERL_DEBUG=1, let's see a new backtrace.
   
  +
  +=item SPINNING PROCESSES
  +
  +If a process is spinning (seemingly stuck in an endless loop, eating
  +up all cpu), you can use gdb to find which Perl code is causing the
  +spin:
  +
  +% gdb httpd pid of spinning process
  +(gdb) source modperl_x.xx/.gdbinit
  +(gdb) curinfo
  +
   =back
   
  
  
  



cvs commit: modperl-2.0/pod - New directory

2000-05-30 Thread cholet

cholet  00/05/30 15:00:02

  modperl-2.0/pod - New directory



cvs commit: modperl-site index.html

2000-05-21 Thread cholet

cholet  00/05/21 15:45:50

  Modified:.index.html
  Log:
  typos
  
  Revision  ChangesPath
  1.57  +4 -4  modperl-site/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/modperl-site/index.html,v
  retrieving revision 1.56
  retrieving revision 1.57
  diff -u -r1.56 -r1.57
  --- index.html2000/05/15 21:06:21 1.56
  +++ index.html2000/05/21 22:45:49 1.57
  @@ -380,7 +380,7 @@
  hr width="40%" align="left"
   
  pa name="general-list"/a
  - bmod_perl mailing list/b is available for
  + The bmod_perl mailing list/b is available for
mod_perl users and developers to share ideas, solve problems and discuss
things related to mod_perl and the CODEApache::*/CODE modules.
br
  @@ -456,8 +456,8 @@
  hr width="40%" align="left"
   
  pa name="advocacy-list"/a
  - A mailing list for bmod_perl advocacy issues/b, discussions about site 
and
  - etc. 
  + A mailing list for bmod_perl advocacy issues/b,
  + discussions about the site, etc. 
br
The list address for posting is a
href="mailto:[EMAIL PROTECTED]"[EMAIL PROTECTED]/a.
  @@ -720,7 +720,7 @@
  /p
   
  p
  - Check out yet another syrvey by
  + Check out yet another survey by
a href="http://www.e-softinc.com/survey/data/index.html"
  E-Soft 
/a. (Hint: click on "Apache Module Report")
  
  
  



cvs commit: modperl Changes

2000-05-19 Thread cholet

cholet  00/05/19 09:01:24

  Modified:.Changes
  Log:
  document the fact that I fixed what I'd just broken
  
  Revision  ChangesPath
  1.488 +3 -0  modperl/Changes
  
  Index: Changes
  ===
  RCS file: /home/cvs/modperl/Changes,v
  retrieving revision 1.487
  retrieving revision 1.488
  diff -u -r1.487 -r1.488
  --- Changes   2000/05/19 10:06:04 1.487
  +++ Changes   2000/05/19 16:01:22 1.488
  @@ -10,6 +10,9 @@
   
   =item 1.24_01-dev
   
  +fix broken Win32 build (unresolved external symbol _ap_configtestonly)
  +[Eric Cholet [EMAIL PROTECTED]]
  +
   =item 1.24 - May 16, 2000
   
   'sub handler : method {}' is now treated as a method handler
  
  
  



cvs commit: modperl-site index.html

2000-04-10 Thread cholet

cholet  00/04/10 03:15:12

  Modified:.index.html
  Log:
  Better link for modperl distro
  
  Revision  ChangesPath
  1.49  +3 -3  modperl-site/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/modperl-site/index.html,v
  retrieving revision 1.48
  retrieving revision 1.49
  diff -u -r1.48 -r1.49
  --- index.html2000/04/09 19:07:04 1.48
  +++ index.html2000/04/10 10:15:11 1.49
  @@ -1,8 +1,8 @@
   html
   head
   titleApache/Perl Integration Project/title
  -!-- Last changed: $Id: index.html,v 1.48 2000/04/09 19:07:04 cholet Exp $ --
  -!-- Last changed: $Id: index.html,v 1.48 2000/04/09 19:07:04 cholet Exp $ --
  +!-- Last changed: $Id: index.html,v 1.49 2000/04/10 10:15:11 cholet Exp $ --
  +!-- Last changed: $Id: index.html,v 1.49 2000/04/10 10:15:11 cholet Exp $ --
   !-- Last changed: Gerald Richter: 31-Mar-1999 --
   
STYLE type="text/css"!--
  @@ -49,7 +49,7 @@
   
   p
   
  -Latest stable release is 1.22, get it from a href="dist/"this site/a or from a 
href="http://www.cpan.org/"CPAN/a.
  +Latest stable release is 1.22, get it from a href="dist/"this site/a or from a 
href="http://www.cpan.org/modules/by-module/Apache"CPAN/a.
   
   p
   
  
  
  



cvs commit: modperl Changes

2000-04-10 Thread cholet

cholet  00/04/10 07:13:42

  Modified:.Changes
  Log:
  document change to Apache::URI::port()
  
  Revision  ChangesPath
  1.462 +3 -0  modperl/Changes
  
  Index: Changes
  ===
  RCS file: /home/cvs/modperl/Changes,v
  retrieving revision 1.461
  retrieving revision 1.462
  diff -u -r1.461 -r1.462
  --- Changes   2000/04/05 06:19:33 1.461
  +++ Changes   2000/04/10 14:13:41 1.462
  @@ -10,6 +10,9 @@
   
   =item 1.22_01-dev
   
  +Apache::URI::port wasn't setting the port correctly, thanks
  +to Zeqing Xia for the sport [Eric Cholet [EMAIL PROTECTED]]
  +
   $Apache::Registry::NameWithVirtualHost fix take 2
   (move is_virtual logic from mod_perl.c to Registry.pm)
   [John Hughes [EMAIL PROTECTED]]
  
  
  



cvs commit: modperl Changes

2000-04-10 Thread cholet

cholet  00/04/10 07:16:11

  Modified:.Changes
  Log:
  typo
  
  Revision  ChangesPath
  1.463 +1 -1  modperl/Changes
  
  Index: Changes
  ===
  RCS file: /home/cvs/modperl/Changes,v
  retrieving revision 1.462
  retrieving revision 1.463
  diff -u -r1.462 -r1.463
  --- Changes   2000/04/10 14:13:41 1.462
  +++ Changes   2000/04/10 14:16:11 1.463
  @@ -11,7 +11,7 @@
   =item 1.22_01-dev
   
   Apache::URI::port wasn't setting the port correctly, thanks
  -to Zeqing Xia for the sport [Eric Cholet [EMAIL PROTECTED]]
  +to Zeqing Xia for the spot [Eric Cholet [EMAIL PROTECTED]]
   
   $Apache::Registry::NameWithVirtualHost fix take 2
   (move is_virtual logic from mod_perl.c to Registry.pm)