Re: RFC WWW::Arbeitsagentur

[Thomas Wittek]

First of all, great idea :)

Ingo Wiarda schrieb:
 =head1 SYNOPSIS
  ...
   path= download/,
   # where to save the job descriptions

I personally find it more easy to understand to place the comments
_above_ the code, as the reader then first sees _what_ you're doing and
after that _how_ you're doing it. The details should follow the overview
and not vice versa IMHO.

 Search results are collected and may be filtered and stored 
 temporarily for offline-use. 

_May_ be stored or _must_ be stored on disk? As you supply a storage
path in the example in the synopsis, it does a bit look like that it has
to be done like this.
Are there also options to just get everything in a perl data structure
without storing it in a directory on disk? This way one could e.g. save
it in a database instead of some files on a disk.

-Thomas

Re: RFC WWW::Arbeitsagentur

[Thomas Wittek]

Ingo Wiarda wrote:
 Results may be stored on disk, the path is not mandatory. Is it better to 
 write more examples in the Synopsis (one with, another one without a path 
 argument) or just to expand the comment like:
 
# where to save your files (optional)
   path= download/?

Should be enough, if the full documentation of the method
WWW::Arbeitsagentur::Search::FastSearchForWork-new makes it clear.

 Another question is how to name variables / attributes.  The web forms on 
 the site have german strings:
 input type=text name=eintrittsterminString ...
 
 So, should I use this so we get 
   $applicant-eintrittstermin 
 or translate it to something like
$applicant-date_of_entry?

That's a good question. On the one hand, CPAN is an international place
and using german method/attribute names might not be a good idea. On the
other hand it's relatively unlikely that any non-German would use this
module. To be consistent with the other modules on CPAN, i'd personally
prefer using english names, especially as you're already using english
words in your package names (..::Search::FastSearchForWork).

-Thomas