Re: [Mojolicious] Form validation and redirects
Sorry about the bad chose of words. The only reason is not correct. There are always exceptions, but in your case it's still valid: 1) You go to /login 2) You enter invalid login credentials and submit to /login 3) Mojolicious render /login 4) You enter correct login credentials and submit to /login 5) Mojolicious redirect you to /profile (or something else that's not /login) Step #5 redirects and avoids the do you want to repost the form issue. You do not want to redirect on step #3, since that will make it much harder to prefill the form. In addition it adds extra load to the webserver, without adding any value. (At least I don't see any added value) Here is another case: 1) You go to /profile, but you're not logged in 2) Mojolicious render the login form, with a hidden field with the original path /profile. 3) You enter correct login credentials and submit to /login 4) Mojolicious redirect you to /profile Step #4 redirects and avoids the do you want to repost the form issue. You might also want to do a redirect on step #1 to /login?redirect_uri=/profile. This redirect will be done anyway, if you use third party login services. On Tuesday, July 28, 2015 at 1:37:41 AM UTC+2, Stefan Adams wrote: On Fri, Jul 24, 2015 at 4:07 AM, Jan Henning Thorsen jan.henn...@thorsen.pm wrote: The only reason to do a redirect is when you want to avoid the do you want to repost the form when someone click the refresh wheel or F5. Or if you care about the URL. Is this a stupid reason? If I find myself doing redirects instead of renders for this reason too frequently am I doing it wrong? That is, do I really need my users seeing the URL as /login as opposed to /profile if they aren't logged in? Or, is this off topic from form validation? -- You received this message because you are subscribed to the Google Groups Mojolicious group. To unsubscribe from this group and stop receiving emails from it, send an email to mojolicious+unsubscr...@googlegroups.com. To post to this group, send email to mojolicious@googlegroups.com. Visit this group at http://groups.google.com/group/mojolicious. For more options, visit https://groups.google.com/d/optout.
Re: [Mojolicious] Automatically extend user session expiration when active websocket connection only
Finally I got the new computer set up :-) Anyway... Here is the code: https://ssl.thorsen.pm/paste/4313bc059551 On Saturday, July 25, 2015 at 7:06:49 AM UTC+2, Александр Грошев wrote: I will wait. Thanks -- You received this message because you are subscribed to the Google Groups Mojolicious group. To unsubscribe from this group and stop receiving emails from it, send an email to mojolicious+unsubscr...@googlegroups.com. To post to this group, send email to mojolicious@googlegroups.com. Visit this group at http://groups.google.com/group/mojolicious. For more options, visit https://groups.google.com/d/optout.
[Mojolicious] File descriptor leak?
The following code demonstrates a server that leaks a file descriptor.
We cannot figure out how to fix that. Could you please provide some
guidance where the problem lies and what the correct way to deal with
it is?
To understand the problem we need three things:
- a mojo server with
-- an asset handler
-- a write callback (a subscriber to the Mojo::IOLoop::Stream write event)
- a mojo client that only takes a partial response
- a tool that watches the behaviour of the server
Let's start with the tool. I used inotifywait to watch the open
filehandles on the path and lsof to see the open filehandles on the
process.
Inotify shows me
% inotifywait -m /var/tmp/zero --format %T %e %f --timefmt %FT%T
[...]
2015-07-28T12:31:03 OPEN
2015-07-28T12:31:03 ACCESS
2015-07-28T12:31:03 ACCESS
2015-07-28T12:31:03 ACCESS
and no close. lsof shows me
% lsof -p 1643 | grep zero
perl1643k5r REG 254,8 409600 75 /var/tmp/zero
The server never closes the file according to these two tools, so
something in the program below must be wrong.
As the downloading client we use this small tool on github:
https://gist.github.com/53b164655b57deb993e1 . We call that program simply
as
% perl streamres.pl -s 20 http://127.0.0.1:3000/welcome
It downloads 20 byte and then closes the connection without
waiting for the end of the connection.
The server side code is below. We have already identified two
places that that make the server work without an FD leak. The two lines
are:
# [1] weaken $s;
# [2] undef $s;
Either of the two will do to close the FD leak. Note that the server
works well when
- the client downloads the full file or
- there is no write_cb to unsubscribe from
What is the recommended approach, when we want to count the written
bytes and need to deal with clients that close their connections
prematurely?
% MOJO_IOLOOP_DEBUG=1 perl -Ilib -e '
use Scalar::Util qw(weaken);
0 == system dd = if=/dev/zero, of=/var/tmp/zero, bs=4096,
count=100 or die;
{ package MyApp;
use Mojo::Base Mojolicious;
sub startup {
my $self = shift;
$self-routes-get(/welcome)-to(foo#hello);
$self-hook(after_build_tx = sub {
my ($tx, $app) = @_;
$tx-on(connection = sub {
my ($tx, $connection) = @_;
my $s = Mojo::IOLoop-stream($connection);
# [1] weaken $s;
my $sent_bytes = 0;
my $write_cb = $s-on(
write = sub {
$sent_bytes += length $_[1];
warn +++ Total bytes sent: $sent_bytes;
});
$tx-on(finish = sub {
$s-unsubscribe(write = $write_cb);
# [2] undef $s;
});
});
});
}
}
{ package MyApp::Controller::Foo;
use Mojo::Base Mojolicious::Controller;
sub hello {
my $self = shift;
open my $fh, /var/tmp/zero;
my $asset = Mojo::Asset::File-new(
path = /var/tmp/zero, handle = $fh
);
$self-res-content-asset($asset);
$self-rendered($self-res-code);
}
}
package main;
require Mojolicious::Commands;
Mojolicious::Commands-start_app(MyApp);
' daemon
-- Reactor initialized (Mojo::Reactor::EV)
100+0 records in
100+0 records out
409600 bytes (410 kB) copied, 0.000488926 s, 838 MB/s
[Tue Jul 28 13:59:16 2015] [info] Listening at http://*:3000;
Server available at http://127.0.0.1:3000
-- 821cfc3bf5c6d3914d29873d6eeb2308 9004 (1)
[Tue Jul 28 13:59:21 2015] [debug] Your secret passphrase needs to be
changed
[Tue Jul 28 13:59:21 2015] [debug] GET /welcome
[Tue Jul 28 13:59:21 2015] [debug] Routing to controller
MyApp::Controller::Foo and action hello
[Tue Jul 28 13:59:21 2015] [debug] 200 OK (0.000527s, 1897.533/s)
+++ Total bytes sent: 131199 at -e line 16.
+++ Total bytes sent: 262271 at -e line 16.
-- 821cfc3bf5c6d3914d29873d6eeb2308 9004 (0)
Thank you,
--
You received this message because you are subscribed to the Google Groups
Mojolicious group.
To unsubscribe from this group and stop receiving emails from it, send an email
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at http://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.
