[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c31 Thomas Wiest [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #31 from Thomas Wiest [EMAIL PROTECTED] 2008-07-25 10:57:21 MDT --- Using the original testcase, I verified that this is fixed in Mono 2.0p1 on SLED 10 sp2 i586. Output of test case on Mono 1.9.1: doc = 'testdate2007-06-15T10:30:10.5/date/test' docm = '?xml version=1.0 encoding=utf-8?test xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd=http://www.w3.org/2001/XMLSchema;date2007-06-15T10:30:10.5-06:00/date/test' doc2m = '?xml version=1.0 encoding=utf-8?test xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd=http://www.w3.org/2001/XMLSchema;date2007-06-15T16:30:10.5-06:00/date/test' doc3m = '?xml version=1.0 encoding=utf-8?test xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd=http://www.w3.org/2001/XMLSchema;date2007-06-15T22:30:10.5-06:00/date/test' Output of test case on Mono 2.0p1: doc = 'testdate2007-06-15T10:30:10.5/date/test' docm = '?xml version=1.0 encoding=utf-8?test xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd=http://www.w3.org/2001/XMLSchema;date2007-06-15T10:30:10.5/date/test' doc2m = '?xml version=1.0 encoding=utf-8?test xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd=http://www.w3.org/2001/XMLSchema;date2007-06-15T10:30:10.5/date/test' doc3m = '?xml version=1.0 encoding=utf-8?test xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd=http://www.w3.org/2001/XMLSchema;date2007-06-15T10:30:10.5/date/test' -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 Thomas Wiest [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] URL| |http://www.go-mono.com/archive/2.0/ -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c30 Roei Erez [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #30 from Roei Erez [EMAIL PROTECTED] 2008-03-02 02:33:53 MST --- commited -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c28 --- Comment #28 from Roei Erez [EMAIL PROTECTED] 2008-02-28 08:46:34 MST --- Hi, Can I commit? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added Attachment #197416|application/octet-stream|text/plain mime type|| Attachment #197416|0 |1 is patch|| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c29 --- Comment #29 from Atsushi Enomoto [EMAIL PROTECTED] 2008-02-28 10:48:12 MST --- Yes please - tried corlib, System.XML and Mono.Security, and no regression alarm was fired. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c20 --- Comment #20 from Roei Erez [EMAIL PROTECTED] 2008-02-27 02:05:57 MST --- Created an attachment (id=197343) -- (https://bugzilla.novell.com/attachment.cgi?id=197343) XmlConvert patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c18 Roei Erez [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #18 from Roei Erez [EMAIL PROTECTED] 2008-02-27 02:03:25 MST --- James, We have worked on a patch for DateTime that is based on the first patch that you have attached. We have revised it to handle also the following: 1. DateTimeStyles.RoundTripKind formatting 2. Handle illegal style combinations. 3. fix some additional bugs that are reflect in the added test cases These test cases fails with the current DateTime implementation, and this patch fixes them. The regression in System.Xml regarding the roundtrip formatting is not due to a bug in System.DateTime, but due to a bug in XmlConvert itself that should use the DateTimeStyles.RoundTripKind when invoking ParseExact method. Also attached is a patch for this bug. Please review this patch, and make a suggestion for how to continue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c19 --- Comment #19 from Roei Erez [EMAIL PROTECTED] 2008-02-27 02:05:17 MST --- Created an attachment (id=197342) -- (https://bugzilla.novell.com/attachment.cgi?id=197342) DateTime patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c21 --- Comment #21 from Roei Erez [EMAIL PROTECTED] 2008-02-27 03:23:46 MST --- I have noticed that the DateTime patch is not good for NET_1_1, I am working on fixing this, and will provide a newer patch today. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 Roei Erez [EMAIL PROTECTED] changed: What|Removed |Added Attachment #197342|0 |1 is obsolete|| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c23 --- Comment #23 from Roei Erez [EMAIL PROTECTED] 2008-02-27 04:43:37 MST --- I have attached the final patch which works also in NET_2_0 NET_1_1. Waiting for your review. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c22 --- Comment #22 from Roei Erez [EMAIL PROTECTED] 2008-02-27 04:42:19 MST --- Created an attachment (id=197382) -- (https://bugzilla.novell.com/attachment.cgi?id=197382) DateTimePatch_revised -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c24 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #24 from Atsushi Enomoto [EMAIL PROTECTED] 2008-02-27 05:04:11 MST --- mmm, it resulted in following test failures on my machine: 1) MonoTests.System.DateTimeTest.TestRoundTrip : expected:633392144582721262 but was:633391892582721262 at MonoTests.System.DateTimeTest.TestRoundTrip () [0x00057] in /svn/mcs/class/corlib/Test/System/DateTimeTest.cs:2276 at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[]) at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00055] in /svn/mcs/class/corlib/System.Reflection/MonoMethod.cs:149 2) MonoTests.System.DateTimeTest.TestRegularStyle : expected:633392144582721262 but was:633391892582721262 at MonoTests.System.DateTimeTest.TestRegularStyle () [0x00053] in /svn/mcs/class/corlib/Test/System/DateTimeTest.cs:2299 at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[]) at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00055] in /svn/mcs/class/corlib/System.Reflection/MonoMethod.cs:149 3) MonoTests.System.DateTimeTest.TestAssumeLocal : expected:633392144582721262 but was:633391892582721262 at MonoTests.System.DateTimeTest.TestAssumeLocal () [0x00054] in /svn/mcs/class/corlib/Test/System/DateTimeTest.cs:2321 at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[]) at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00055] in /svn/mcs/class/corlib/System.Reflection/MonoMethod.cs:149 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c27 Roei Erez [EMAIL PROTECTED] changed: What|Removed |Added Attachment #197405|0 |1 is obsolete|| --- Comment #27 from Roei Erez [EMAIL PROTECTED] 2008-02-27 06:12:03 MST --- Created an attachment (id=197416) -- (https://bugzilla.novell.com/attachment.cgi?id=197416) DateTimePatch_revised_3 The test cases were fixed to compare universally and are not affected by the current TimeZone. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c26 --- Comment #26 from Roei Erez [EMAIL PROTECTED] 2008-02-27 05:56:49 MST --- Sorry, The test cases are TimeZone sensitive. I still need to correct the test cases, will do so today. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c25 Roei Erez [EMAIL PROTECTED] changed: What|Removed |Added Attachment #197382|0 |1 is obsolete|| --- Comment #25 from Roei Erez [EMAIL PROTECTED] 2008-02-27 05:49:40 MST --- Created an attachment (id=197405) -- (https://bugzilla.novell.com/attachment.cgi?id=197405) DateTimePatch_revised_2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c16 --- Comment #16 from Atsushi Enomoto [EMAIL PROTECTED] 2008-02-26 01:34:55 MST --- I've applied the patch too. Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c17 --- Comment #17 from James Purcell [EMAIL PROTECTED] 2008-02-26 22:28:42 MST --- Well, the other test is still failing. Are you still working on a fix Eyal? I found the real cause of the problem now so I can see about fixing it if necessary, but it might take a bit of effort so if you're close I won't worry about it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c14 --- Comment #14 from Eyal Alaluf [EMAIL PROTECTED] 2008-02-25 01:01:40 MST --- Hi, Atsushi. We have applied the patch to Grasshopper sources and saw issues with DateTime rountrip (seen in XML tests). We are working on an update to this patch that we will post for review today or tomorrow (dependig on our build results). I propose to wait for the consolidated patch. Eyal. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c15 --- Comment #15 from James Purcell [EMAIL PROTECTED] 2008-02-25 07:55:19 MST --- Created an attachment (id=196938) -- (https://bugzilla.novell.com/attachment.cgi?id=196938) patch There was a fix for the round-trip stuff in comment #9, I guess I should have made a patch for that, see attachment. This fixes the XmlDateTimeSerializationModeRountripKind failure, and although I'm unable to reproduce the XmlDateTimeSerializationModeSeveralFormats failure I believe that will be fixed as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c13 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #13 from Atsushi Enomoto [EMAIL PROTECTED] 2008-02-24 23:48:12 MST --- Let's apply the patch and see what happpens on the buildbot. (Will reopen it if it failed and is reverted.) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c12 --- Comment #12 from Eyal Alaluf [EMAIL PROTECTED] 2008-02-10 05:44:29 MST --- At least for my part (the changes to .Net 2.0 and flexible parsing) the patch passes well my review. I must also say that when working with the code it was evident to me that we don't behave very well about the kind property and I am glad we have now good test cases to define the correct behavior. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c10 --- Comment #10 from Atsushi Enomoto [EMAIL PROTECTED] 2008-02-05 01:48:59 MST --- (Assuming that you is me from #mono) I never said that I cannot reproduce anything concrete. What I said was about our NUnit tests. Those tests had better become NUnit tests too (at least it should be, before your fixes are checked in). Anyways I cannot try your fixes as on my machine some tests do not fail which failed on the buildbot. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c11 --- Comment #11 from James Purcell [EMAIL PROTECTED] 2008-02-05 11:07:29 MST --- Created an attachment (id=193262) -- (https://bugzilla.novell.com/attachment.cgi?id=193262) nunit tests Atsushi, I am able to reproduce the following failures in corlib and Mono.Security with the DateTime code checked in a month ago to fix this bug: MonoTests.System.DateTimeTest.X509Certificate : #7 MonoTests.Mono.Security.ASN1ConvertTest.ConvertDateTimeBefore2000 : Kind MonoTests.Mono.Security.ASN1ConvertTest.ConvertDateTimeAfter2000 : Kind MonoTests.Mono.Security.ASN1ConvertTest.ConvertDateTimeAfter2050 : Kind MonoTests.Mono.Security.ASN1ConvertTest.ConvertDateTimeInvalidButExistingFormat : Kind These tests all pass with the new patch. Also I have created a NUnit test (see attachment) to check for some of the other issues fixed by the patch. These all pass in MS.NET 2.0 and 1.0 of course. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 Eric Butler [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c8 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #8 from Atsushi Enomoto [EMAIL PROTECTED] 2008-02-04 21:43:37 MST --- There are some changes that Eyal had better take a look. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210
User [EMAIL PROTECTED] added comment
https://bugzilla.novell.com/show_bug.cgi?id=352210#c9
--- Comment #9 from James Purcell [EMAIL PROTECTED] 2008-02-04 23:35:31 MST
---
Created an attachment (id=193152)
-- (https://bugzilla.novell.com/attachment.cgi?id=193152)
tests
As requested I have attached some examples to demonstrate the bugs I'm aware of
in Mono's current DateTime parsing. Please see the comments in the code for
descriptions of the differences in output between MS.NET and Mono.
I believe you said you were unable to reproduce the issue of parsing returning
Local kind when it should return Unspecified. I don't understand how this is
possible after reading the code:
result = new DateTime (false, new TimeSpan (newticks));
if (explicit_kind != DateTimeKind.Unspecified)
result.kind = explicit_kind;
else if (use_localtime)
result = result.ToLocalTime ();
else
result.kind = DateTimeKind.Utc;
This is where the result is finally set for NET_2_0, where it will always be
caught by one of the branches of the 'if'. In the first case .kind is set and
will obviously never be set to Unspecified, in the second case case
ToLocalTime is used which always sets Kind to Local, and in the third case
it's set to UTC. So there is no way that _DoParse can return successfully with
Kind set to Unspecified.
Regarding the KindPattern test, you can make it pass by adding style |=
DateTimeStyles.AdjustToUniversal; to my patch inside case 'K': if (s
[valuePos] == 'Z') {.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
You are the assignee for the bug.
___
mono-bugs maillist - mono-bugs@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210
User [EMAIL PROTECTED] added comment
https://bugzilla.novell.com/show_bug.cgi?id=352210#c7
--- Comment #7 from James Purcell [EMAIL PROTECTED] 2008-02-03 13:48:16 MST
---
Created an attachment (id=192962)
-- (https://bugzilla.novell.com/attachment.cgi?id=192962)
patch
I've created a patch that fixes several issues with DateTime parsing having the
wrong time zone or the wrong DateTimeKind.
DateTime.cs:
1) Simplified the useutc, use_localtime, explicit_kind stuff. This fixes
returning the wrong DateTimeKind and a bug where AssumeUniversal forced useutc
even if a timezone was specified in the date/time string. Probably fixes some
other stuff too, to be honest the old code was quite confusing so I'm not sure
what it did.
2) Fixed handling of GMT in format or date/time string. For the part where
it checked with CompareInfo.IndexOf, I don't know if that was being used
because it was only for !exact and I don't think the predefined format strings
have GMT in them. Even so, this code was incorrect because you should be
able to use a single quoted GMT (i.e. 'GMT' ) in the format string without
it affecting useutc. But this is now handled properly inside the parse loop,
and it also corrects a bug with ParseExact not setting useutc when GMT was in
the format string. Note that this needs to be a case sensitive comparison, so
_ParseString shouldn't be used, unlike checking the date/time string with
flexibleTwoPartsParsing for GMT where it is correct to ignore case. Speaking
of the flexibleTwoPartsParsing GMT parsing code, it should actually behave
different in .NET 2.0 to allow the GMT to appear before the time part (e.g.
GMT date time, date GMT time, GMT time date, etc), which is included in
the patch.
DateTimeUtils.cs
1) For the 'u' format string, it should not set useutc unless being used in the
context of DateTimeOffset.
2) MSDN says 'o', 's', and 'u' use invariant culture. This doesn't seem to
make any difference but I think it's a good idea to set it anyway.
3) Uppercase 'o' ('O') should be allowed as well.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
You are the assignee for the bug.
___
mono-bugs maillist - mono-bugs@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 James Purcell [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c6 --- Comment #6 from Mads Dydensborg [EMAIL PROTECTED] 2008-01-21 13:29:09 MST --- Hi. I really would like this issue to be resolved Any advice on it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c1 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Atsushi Enomoto [EMAIL PROTECTED] 2008-01-08 00:17:22 MST --- The cause of the issue is summarized within this one-liner example: Console.WriteLine (DateTime.ParseExact (2007-06-15T10:30:10.5, -MM-ddTHH:mm:ss.f, null).Kind); .. and DateTime.ParseExact() is used in XmlConvert.ToDateTime() : Console.WriteLine (XmlConvert.ToDateTime (2007-06-15T10:30:10.5, XmlDateTimeSerializationMode.RoundtripKind).Kind); .. and it is used in XmlSerializer. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c4 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added CC|[EMAIL PROTECTED] | Status|RESOLVED|REOPENED Component|System |CORLIB Resolution|FIXED | --- Comment #4 from Atsushi Enomoto [EMAIL PROTECTED] 2008-01-09 10:45:29 MST --- The fix caused regression on the buildbot, so it is reverted. Strangely it's perfectly working on my box so I wonder if I can fix this WORKSFORME issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c5 --- Comment #5 from Mads Dydensborg [EMAIL PROTECTED] 2008-01-09 11:13:01 MST --- (In reply to comment #4 from Atsushi Enomoto) The fix caused regression on the buildbot, so it is reverted. Strangely it's perfectly working on my box so I wonder if I can fix this WORKSFORME issue. Hmm. I tested svn this morning, with your changes, and they made my problem go away. On my setup there are differences: the linux box outputs what I reported, the Windows something else. Your fix changed this, such that the linux outputted the same as the Windows box, and the date did not shift. I tried running my testprogram again on another box. Here are some results: box 1: Linux 2 core Intel Xeon, running Kubuntu Gutsy, under vmware box 2: Linux 8 core AMD opteron, running debian 4.0 mono --version | box | result 1.2.4 tarball| 1 | OK 1.2.6 tarball| 1 | NOT OK 1.2.6 svn r92488 | 1 | OK 1.2.2.1 package | 2 | OK 1.2.6 tarball| 2 | NOT OK I did not note the version I ran on prior to your patches, but it was SVN as of the morning I wrote my first mail: Monday the 6/1, at about 04:00 UTC. Please advise on how to provide more data/information to support my case. Did you try running the testprogram on a pure 1.2.6 tarball? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c2 --- Comment #2 from Mads Dydensborg [EMAIL PROTECTED] 2008-01-08 00:30:47 MST --- (In reply to comment #1 from Atsushi Enomoto) The cause of the issue is summarized within this one-liner example: So, does this mean that you confirm it is a bug? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added Attachment #189674|text/x-java |text/plain mime type|| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
[Mono-bugs] [Bug 352210] Serialization and deserialization of datetime to and from xml, shifts the time with the timezone
https://bugzilla.novell.com/show_bug.cgi?id=352210 User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=352210#c3 Atsushi Enomoto [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Atsushi Enomoto [EMAIL PROTECTED] 2008-01-08 23:53:53 MST --- (Without adding obvious comment and hence not spreading extraneous bugzilla emails) it is fixed in svn. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. You are the assignee for the bug. ___ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
