Re: [Mono-dev] problem: Invalidate does not propagate correctly invalidation to nested controls (+patch)
Hey, The reason that this code was changed is because on MS.NET Refresh isn't called recursively and some controls override it and do not expect that it will be called again and end up in an endless loop. I think this was also the case with some Mono WinForms controls especially in MDI forms. It would be best if you can write an unit test to verify that on MS.NET when you call Invalidate (true) it recursively calls the same on the child controls. While you are at it you can also write one that shows that Refresh() is not called recursively as well which I should have done myself (sorry). I am sure Calberto will be happy to review with a test that passes and a patch that also causes no fails on our test suite. Kind Regards, Ivan Zlatev http://ivanz.com On Thu, Dec 17, 2009 at 10:19 PM, matteo tesser wrote: > Hi, > I noticed that both mono 2.6 and mono 2.4.3 introduce a problem in > windows.form apps (in all versions linuxes and os x) : In some > situations, invalidate and subsequent painting is not propagated > correctly to nested controls. > > > The problem is due to the following change in the Control.Refresh method. > http://anonsvn.mono-project.com/viewvc/trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs?r1=140535&r2=141744&sortby=date > > The old version called Control.Refresh method recursively for all > child controls . The new version changes strategy and - correctly - > call Update method telling to invalidate childrend controls too. > > The problem is in the implementation of method Control.Invalidate . I > noticed that in mono 2.6 (2.4.3), when a control contains more than > one level of nested controls, only first level controls are > refreshed/painted. > > I think that method invalidate, when InvalidateChildren parameter is > true, should propagate recursively the invalidation to all nested > controls. > > I send you a patch, which corrects the problem in the apps I'm working. > > Thanks, > Matteo > > ___ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] problem: Invalidate does not propagate correctly invalidation to nested controls (+patch)
Hi,
I noticed that both mono 2.6 and mono 2.4.3 introduce a problem in
windows.form apps (in all versions linuxes and os x) : In some
situations, invalidate and subsequent painting is not propagated
correctly to nested controls.
The problem is due to the following change in the Control.Refresh method.
http://anonsvn.mono-project.com/viewvc/trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs?r1=140535&r2=141744&sortby=date
The old version called Control.Refresh method recursively for all
child controls . The new version changes strategy and - correctly -
call Update method telling to invalidate childrend controls too.
The problem is in the implementation of method Control.Invalidate . I
noticed that in mono 2.6 (2.4.3), when a control contains more than
one level of nested controls, only first level controls are
refreshed/painted.
I think that method invalidate, when InvalidateChildren parameter is
true, should propagate recursively the invalidation to all nested
controls.
I send you a patch, which corrects the problem in the apps I'm working.
Thanks,
Matteo
Index: class/Managed.Windows.Forms/System.Windows.Forms/Control.cs
===
--- class/Managed.Windows.Forms/System.Windows.Forms/Control.cs (revision 148705)
+++ class/Managed.Windows.Forms/System.Windows.Forms/Control.cs (working copy)
@@ -4015,7 +4015,7 @@
if (invalidateChildren) {
Control [] controls = child_controls.GetAllControls ();
for (int i=0; i___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] VS 2008 required for building mono 2. 6?
Hi *, Congratulations on releasing 2.6. On the other note. I didn't find anything in the docs or on the mailing list, that the required version of Visual Studio to build mono changed for 2.6 version. Looking at sln and vcproj files it seems that they are all from VS 2008. If that is the case please also update the compling manual [1] On the other hand looking at the SVN under /tags/mono-2-6/mono I can see that there is also msvc05 dir present and msvc dir itself also contains some files that are not in official 2.6 bz2 file. This seems like you have some source packaging problem. [1] - http://www.mono-project.com/Compiling_Mono_VSNET Regards, Miha -- It's time to get rid of your current e-mail client ... ... and start using si.Mail. It's small & free. ( http://www.simail.si/ ) ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Mono 2.6 / AOT on Windows with Cygwin 1.7
Hi, AOT is not currently supported on windows. Zoltan On Thu, Dec 17, 2009 at 6:13 PM, Dan Shechter wrote: > Hi all, > I'm trying to compile some simple SIMD examples (the one miguel posted > a while back) > using AOT on Mono on Windows. > > I have cygwin 1.7 installed, and therefore, as --version looks like this: > $ as --version > GNU assembler (GNU Binutils) 2.19.51.20090704 > Copyright 2008 Free Software Foundation, Inc. > This program is free software; you may redistribute it under the terms of > the GNU General Public License version 3 or later. > This program has absolutely no warranty. > This assembler was configured for a target of `i686-cygwin'. > > When I try to aot compile simple.cs: > /c/dev/Mono/bin/mono --aot simple1.exe > > I get: > Mono Ahead of Time compiler - compiling assembly > C:\temp\simd-tests-1\simple1.exe > Code: 3473 Info: 67 Ex Info: 79 Unwind Info: 54 Class Info: 173 PLT: > 15 GOT Info: 247 GOT Info Off > Executing the native assembler: as C:\TEMP\mono_aot_MWK34U -o > C:\TEMP\mono_aot_MWK34U.o > cygwin warning: > MS-DOS style path detected: C:\TEMP\mono_aot_MWK34U.o > Preferred POSIX equivalent is: /c/TEMP/mono_aot_MWK34U.o > CYGWIN environment variable option "nodosfilewarning" turns off this > warning. > Consult the user's guide for more details about POSIX paths: >http://cygwin.com/cygwin-ug-net/using.html#using-pathnames > C:\TEMP\mono_aot_MWK34U: Assembler messages: > C:\TEMP\mono_aot_MWK34U:168: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:187: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:187: Error: junk at end of line, first > unrecognized character is `P' > C:\TEMP\mono_aot_MWK34U:193: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:204: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:204: Error: junk at end of line, first > unrecognized character is `P' > C:\TEMP\mono_aot_MWK34U:210: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:218: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:218: Error: junk at end of line, first > unrecognized character is `P' > C:\TEMP\mono_aot_MWK34U:224: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:235: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:235: Error: junk at end of line, first > unrecognized character is `F' > C:\TEMP\mono_aot_MWK34U:241: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:251: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:251: Error: junk at end of line, first > unrecognized character is `F' > C:\TEMP\mono_aot_MWK34U:257: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:263: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:263: Error: junk at end of line, first > unrecognized character is `I' > C:\TEMP\mono_aot_MWK34U:269: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:275: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:275: Error: junk at end of line, first > unrecognized character is `E' > C:\TEMP\mono_aot_MWK34U:281: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:292: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:292: Error: junk at end of line, first > unrecognized character is `E' > C:\TEMP\mono_aot_MWK34U:298: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:304: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:304: Error: junk at end of line, first > unrecognized character is `R' > C:\TEMP\mono_aot_MWK34U:310: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:336: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:336: Error: junk at end of line, first > unrecognized character is `R' > C:\TEMP\mono_aot_MWK34U:342: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:358: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:358: Error: junk at end of line, first > unrecognized character is `R' > C:\TEMP\mono_aot_MWK34U:364: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:383: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:383: Error: junk at end of line, first > unrecognized character is `R' > C:\TEMP\mono_aot_MWK34U:389: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:447: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:447: Error: junk at end of line, first > unrecognized character is `R' > C:\TEMP\mono_aot_MWK34U:453: Error: unknown pseudo-op: `.local' > C:\TEMP\mono_aot_MWK34U:459: Warning: .size pseudo-op used outside of > .def/.endef ignored. > C:\TEMP\mono_aot_MWK34U:459: Err
Re: [Mono-dev] ASP.NET website fails after update to 2.4.3
On Tue, 15 Dec 2009 17:18:32 -0700 Robert Abram wrote: Hello, > I believe my error after upgrading from 2.4.2.3 to 2.4.3 on a test > server is a similar problem. Please see attached test app. Excellent! It does reproduce the issue. I filed a bug report (https://bugzilla.novell.com/show_bug.cgi?id=565547) so that it doesn't skip my mind and will try to work on fixing it later tonight. thanks a lot, best marek > > On the page, I have an ObjectDataSource which read two parameter values > from controls on the page. > > > TypeName="App.Test.ECCN" > SelectMethod="GetECCNSummaryWithFilter" > SelectCountMethod="GetECCNSummaryCountWithFilter" > EnablePaging="true"> > > Name="year" Type="Int32" /> > Name="eccn" Type="String" /> > > > > > Changing the control parameters to simple default parameters makes the > page work. > >DefaultValue="2009"/> > > > This is code is right out of production that was working fine on 2.4.2.3 > > Regards, > > Robert > > > > System.NotSupportedException: CollectionConverter cannot convert from > System.String. > > at System.ComponentModel.TypeConverter.GetConvertFromException > (System.Object value) [0x0001d] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System/System.ComponentModel/TypeConverter.cs:161 > at System.ComponentModel.TypeConverter.ConvertFrom (ITypeDescriptorContext > context, > System.Globalization.CultureInfo culture, System.Object value) [0x00017] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System/System.ComponentModel/TypeConverter.cs:79 > at System.Web.UI.ObjectStateFormatter+TypeConverterFormatter.Read (Byte token, > System.IO.BinaryReader r, System.Web.UI.ReaderContext ctx) [0x00030] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:1019 > at System.Web.UI.ObjectStateFormatter+ObjectFormatter.ReadObject > (System.IO.BinaryReader r, > System.Web.UI.ReaderContext ctx) [0xf] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:467 > at System.Web.UI.ObjectStateFormatter+TripletFormatter.Read (Byte token, > System.IO.BinaryReader > r, System.Web.UI.ReaderContext ctx) [0x6] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:715 > at System.Web.UI.ObjectStateFormatter+ObjectFormatter.ReadObject > (System.IO.BinaryReader r, > System.Web.UI.ReaderContext ctx) [0xf] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:467 > at System.Web.UI.ObjectStateFormatter+ObjectArrayFormatter.Read (Byte token, > System.IO.BinaryReader r, System.Web.UI.ReaderContext ctx) [0x00016] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:806 > at System.Web.UI.ObjectStateFormatter+ObjectFormatter.ReadObject > (System.IO.BinaryReader r, > System.Web.UI.ReaderContext ctx) [0xf] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:467 > at System.Web.UI.ObjectStateFormatter+PairFormatter.Read (Byte token, > System.IO.BinaryReader r, > System.Web.UI.ReaderContext ctx) [0x00013] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:692 > at System.Web.UI.ObjectStateFormatter+ObjectFormatter.ReadObject > (System.IO.BinaryReader r, > System.Web.UI.ReaderContext ctx) [0xf] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:467 > at System.Web.UI.ObjectStateFormatter+ObjectArrayFormatter.Read (Byte token, > System.IO.BinaryReader r, System.Web.UI.ReaderContext ctx) [0x00016] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:806 > at System.Web.UI.ObjectStateFormatter+ObjectFormatter.ReadObject > (System.IO.BinaryReader r, > System.Web.UI.ReaderContext ctx) [0xf] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:467 > at System.Web.UI.ObjectStateFormatter+TripletFormatter.Read (Byte token, > System.IO.BinaryReader > r, System.Web.UI.ReaderContext ctx) [0x6] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:715 > at System.Web.UI.ObjectStateFormatter+ObjectFormatter.ReadObject > (System.IO.BinaryReader r, > System.Web.UI.ReaderContext ctx) [0xf] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:467 > at System.Web.UI.ObjectStateFormatter+ArrayListFormatter.Read (Byte token, > System.IO.BinaryReader > r, System.Web.UI.ReaderContext ctx) [0x00016] > in > /home/build/mono.2.4.3/mono-2.4.3/mcs/class/System.Web/System.Web.UI/ObjectStateFormatter.cs:744 > at
Re: [Mono-dev] [PATCH] XSP: Reliable socket closure on FastCGI Backend
On Wed, 16 Dec 2009 14:57:15 -0600 "Tiaan Geldenhuys" wrote: Hello, > The attached path fixes an issue where XSP's FastCGI Backend would sometimes > close sockets before all data has made it to the FastCGI Server (web > server), which leaves the FastCGI protocol in a bad state and can even > truncate content to the web client prematurely. Committed (with a small cosmetic change - there's no point in catching ObjectDisposedException and ignoring it, as socket.Close () will throw it anyway as it should) in r148675 (trunk), r148676 (2.6 branch) and r148677 (2.4 branch). Thanks! best, marek ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
