Re: [Mono-dev] Proposed changes to mono/mcs/class/corlib/Mono/DataConverter.cs

2014-12-17 Thread Michael McGlothlin
How would I access your new version (In a different branch or such?)? How long 
until the changes will filter through to the NuGet package!

Thanks,
Sent from my iPad

 On Dec 9, 2014, at 8:25 AM, Miguel de Icaza mig...@xamarin.com wrote:
 
 Hey,
 
 I have a variation of this patch now.   I need to rebuild my Mono before i 
 can commit it.
 
 It will use a conditional compiler directive to use this other system
 
 On Mon, Dec 8, 2014 at 11:53 PM, Stephen Shaw ss...@decriptor.com wrote:
 I can't comment on the code changes themselves, but it would be helpful to 
 fork mono on github and then create a Pull Request (PR) with your changes.
 
 Cheers,
 Stephen
 
 On Mon, Dec 8, 2014 at 8:54 PM, Michael McGlothlin 
 mike.mcgloth...@gmail.com wrote:
 Couldn't figure out how to get Xamarin Studio to create an actual patch 
 file after trying, and failing, to push a change with git. It appears this 
 is the correct place to post this?
 
 I usually put most of my code in PCL and then call it from platform 
 specific code so I'm trying to make DataConverter happy as PCL.
 
 To make DataConverter compile as PCL I had to change Encoding.UTF7 to 
 Encoding.GetEncoding ( utf-7 ) and the numeric calls to 12000 and 12001 
 on GetEncoding() to the string-based utf-32 and uff-32BE. These three 
 changes had to be made twice as there are two variants using this same 
 code. I also changed ArrayList to Listobject to make PCL happy.
 
 
 
 case '7':
 e = Encoding.GetEncoding (utf-7);
 n = 1;
 break;
 case '3':
 e = Encoding.GetEncoding (utf-32);
 n = 4;
 break;
 case '4':
 e = Encoding.GetEncoding (utf-32BE);
 n = 4;
 break;
 
 
 
 static public IList Unpack (string description, byte[] buffer, 
 int startIndex)
 {
 DataConverter conv = CopyConv;
 var result = new Listobject ();
 int idx = startIndex;
 bool align = false;
 int repeat = 0, n;
 
 
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 
 
 
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 
 
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Open source .Net, and TLS 1.1 1.2

2014-12-17 Thread Edward Ned Harvey (mono)
I was able to trim this down to a specific subset and make a unit test out of 
it.  Although SslStream has compatibility problems communicating with other 
implementations (such as .Net), mono SslStream also has a problem talking to 
*itself*.  The root causes are the same for both the internal compatibility 
problem, and the external problems.  So the internal problem is demonstrated in 
 the SslStreamTest here:
https://github.com/rahvee/mono/commit/b0362fe70fb445f90197eab712b8d995f88d78e1

Should I submit a pull request?  Note:  This test currently passes on .Net, and 
fails on mono.  I don't know if you guys want me submitting a test that is 
known to fail on mono.

Should I file a bug in bugzilla?  (I'm not sure if I have sufficient 
permission).

And as a matter of style, in the above commit I needed to use some classes that 
weren't available in the MonoTest namespace, so I used global::System. in 
several places.  Is this the correct and/or best way to deal with it?  Or is 
there a better way to handle that?

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list