Re: [Mono-dev] End line/column information in symbol files

2015-01-05 Thread Marek Safar
Hello,

I am seeing the starting line and column numbers, just not the ending ones.
 You are saying that the compiler is not providing these values? The place
 exists where to put these values in the symbol file but they always seem to
 be -1.


Correct, it's one of not implemented compiler features.



 Is there a reason this is not supported? Would a patch to fix this to
 welcomed?


Yes, why not?

Thanks
Marek

*From:* Zoltan Varga [mailto:var...@gmail.com]
 *Sent:* Monday, January 5, 2015 4:23 PM
 *To:* Zinkevicius, Matt
 *Cc:* mono-devel-list@lists.ximian.com
 *Subject:* Re: [Mono-dev] End line/column information in symbol files



 Hi,



   There is a tool named mdbdump in mcs/class/lib/net_4_5/mdbdumb.exe which
 can be used to dump the contents of .mdb files. In this case, mcs currently
 doesn't generate column numbers, so sdb cannot return them.



   Zoltan



 On Mon, Jan 5, 2015 at 6:12 PM, Zinkevicius, Matt matt.zinkevic...@hp.com
 wrote:

  Hello,



 When debugging our program on Linux with Mono 3.10, I’ve noticed that the
 source code sequence points that the soft debugger gives never include
 valid end line or end column numbers. They are always set to -1. Is this
 because the mono compiler doesn’t include these values in the mdb symbol
 files? Perhaps I’m doing something wrong when invoking the soft debugger
 library?



 Thanks,

 Matt Zinkevicius




 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list



 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list


___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] If you accept pull requests on Mono's github

2015-01-05 Thread Eberhard Beilharz

 

Andres G. Aragoneses kno...@gmail.com wrote on 2015-01-03 at 21:51 +0100:
 On 03/01/15 21:42, Edward Ned Harvey (mono) wrote:
 I don't know if you want tests that are known to fail.

 If it fails, you can decorate it with the attribute
 [Category(NotWorking)], but AFAICT contributing a failing test
 doesn't increase the chances of finding a contributor that has the
 time to fix it.
IMO it might still be helpful to submit the test even if it doesn't
increase the chance of somebody fixing it in the near future - creating
a unit test is often half of the work.

Eberhard
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


[Mono-dev] WIP: Microsoft's System.Runtime.Serialization

2015-01-05 Thread Miguel de Icaza
Hey guys,

My work is described here:

https://trello.com/c/L6jkUdOQ/12-system-runtime-serialization

The status of this patch is:

Work in progress to bring Microsoft System.Runtime.Serialization to Mono



The current code compiles by replacing existing Mono code with

Microsoft code (without actually deleting the unreferenced files -

purely to use them as a roadmap for things that we should do to make

the code MOBILE and AOT friendly).



Currently this does not compile the mobile profile assembly, nor has

the code been tested yet.



The code also brings an extensive tracing/logging system that wont

work on Unix as it is based on Window's Event Tracing facility.



We should consider a few options:



   * Allow for the code to be disabled (for release builds on Mobile,

 or for an initial delivery that does not support any tracing

 capabilities).



   * Allow for the tracing framework to be replaced with some other

 logging framework.
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Porting System.Numerics from referencesource, approaches for copying code?

2015-01-05 Thread Alexander Köplinger
Anything left for me to do on this one? :)
-- Alex
 
From: mig...@xamarin.com
Date: Wed, 3 Dec 2014 13:34:47 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

Got it.
Miguel
On Wed, Dec 3, 2014 at 11:13 AM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



To make this 100% clear: .NET implements locale aware number formatting in the 
VM, e.g. for format specifiers like 'e' (exponential) or 'f' (fixed-point)  it 
calls into the VM for formatting.
We don't have this in Mono atm., so the only way is to restrict it to the 
invariant format specifiers (which doesn't hurt existing Mono users, since it 
didn't work before too).

-- Alex
 
From: alex.koeplin...@outlook.com
To: mig...@xamarin.com
Date: Wed, 3 Dec 2014 17:01:42 +0100
CC: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?




Hey,
we need to ensure we only continue for the format specifiers used in 
decimalFmt. Any other format specifier (i.e. culture-specific ones) would 
result in a call into unmanaged code later on 
(https://github.com/akoeplinger/referencesource/blob/mono/System.Numerics/System/Numerics/BigNumber.cs#L611-L634)
 which we of course don't have implemented.
 
Note that it only throws an exception when decimalFmt == false, i.e. when any 
of the culture-specific specifiers was used (which is *not* a common code 
path). This is exactly what the current Mono code also does: 
https://github.com/mono/mono/blob/f8a517624de3fdfc070d2f0660fce1b62d41bc4c/mcs/class/System.Numerics/System.Numerics/BigInteger.cs#L1470
 
-- Alex
 
From: mig...@xamarin.com
Date: Wed, 3 Dec 2014 10:52:04 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

Hello Alex,
I am not sure I am understanding this.
This looks like we are choosing to not bring features that we are missing?   
Why would we want to do that?
Miguel
On Wed, Dec 3, 2014 at 10:33 AM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



Mono today also only supports the format specifiers used in decimalFmt: 
https://github.com/mono/mono/blob/f8a517624de3fdfc070d2f0660fce1b62d41bc4c/mcs/class/System.Numerics/System.Numerics/BigInteger.cs#L1458-L1471
 
So using this #if for Mono is the correct way to go.
 
(reposted, seems like the mailing list ate my previous mail) 

-- Alex
 
From: mig...@xamarin.com
Date: Sat, 29 Nov 2014 12:06:20 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

Can you explain the rationale for the #if used with the same SILVERLIGHT 
setting?
It seems like it limits the code.
On Sat, Nov 29, 2014 at 12:03 PM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



Yeah, that was what I was doing.
 
I created these PRs:
https://github.com/mono/referencesource/pull/1
https://github.com/mono/mono/pull/1433 

-- Alex
 
From: mig...@xamarin.com
Date: Sat, 29 Nov 2014 11:23:01 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

I just realized it might not have been 100% clear what I think we should do.
We would in this case replace the references to our mono/mcs/class/XX/*/*cs 
source files, with the ../../external/referencesource/... files, and then 
alter the original referencesource file with the #if statements.
We have done that already in a couple of places.
(More to come, last night we got XML working, but needs some work)
On Sat, Nov 29, 2014 at 11:21 AM, Miguel de Icaza mig...@xamarin.com wrote:
Thanks Alex.
I do not think that we will have a strict rule for when to copy and when to 
reference.  
There are scenarios where we will want to keep a lot of the code in one of our 
files, and pull code from the referencesource.   At that point, we will have to 
determine whether the use of #ifdefs or partial classes is a better long-term 
maintenance approach than copying the source.
In this particular case, I feel that we can modify the reference source, and 
add the #if MONO around it.
The reason is that the changes are pretty straight forward, it is mostly about 
disabling code, and not about picking some specific bits of code and putting 
them on our tree.   So an #if would be nice, since we can do a few things (a) 
we can later find out what code is being disabled by the port (looking at work 
we can do in the future to import new versions, or contribute back to .NET) and 
(b) the changes are minimal right now.
Miguel
On Sat, Nov 29, 2014 at 10:59 AM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



Here's the diff between my trimmed version and the original: 

Re: [Mono-dev] Porting System.Numerics from referencesource, approaches for copying code?

2015-01-05 Thread Miguel de Icaza
Hey,

Sorry, really poor email on my part.

You answered my concern to my satisfaction, so this is good to go.

Miguel

On Mon, Jan 5, 2015 at 12:09 PM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:

 Anything left for me to do on this one? :)

 -- Alex

 --
 From: mig...@xamarin.com
 Date: Wed, 3 Dec 2014 13:34:47 -0500

 Subject: Re: [Mono-dev] Porting System.Numerics from referencesource,
 approaches for copying code?
 To: alex.koeplin...@outlook.com
 CC: mono-devel-list@lists.ximian.com

 Got it.

 Miguel

 On Wed, Dec 3, 2014 at 11:13 AM, Alexander Köplinger 
 alex.koeplin...@outlook.com wrote:

 To make this 100% clear: .NET implements locale aware number formatting in
 the VM, e.g. for format specifiers like 'e' (exponential) or 'f'
 (fixed-point)  it calls into the VM for formatting.
 We don't have this in Mono atm., so the only way is to restrict it to the
 invariant format specifiers (which doesn't hurt existing Mono users, since
 it didn't work before too).

 -- Alex

 --
 From: alex.koeplin...@outlook.com
 To: mig...@xamarin.com
 Date: Wed, 3 Dec 2014 17:01:42 +0100
 CC: mono-devel-list@lists.ximian.com

 Subject: Re: [Mono-dev] Porting System.Numerics from referencesource,
 approaches for copying code?

 Hey,
 we need to ensure we only continue for the format specifiers used in
 decimalFmt. Any other format specifier (i.e. culture-specific ones) would
 result in a call into unmanaged code later on (
 https://github.com/akoeplinger/referencesource/blob/mono/System.Numerics/System/Numerics/BigNumber.cs#L611-L634)
 which we of course don't have implemented.

 Note that it only throws an exception when decimalFmt == false, i.e. when
 any of the culture-specific specifiers was used (which is *not* a common
 code path). This is exactly what the current Mono code also does:
 https://github.com/mono/mono/blob/f8a517624de3fdfc070d2f0660fce1b62d41bc4c/mcs/class/System.Numerics/System.Numerics/BigInteger.cs#L1470

 -- Alex

 --
 From: mig...@xamarin.com
 Date: Wed, 3 Dec 2014 10:52:04 -0500
 Subject: Re: [Mono-dev] Porting System.Numerics from referencesource,
 approaches for copying code?
 To: alex.koeplin...@outlook.com
 CC: mono-devel-list@lists.ximian.com

 Hello Alex,

 I am not sure I am understanding this.

 This looks like we are choosing to not bring features that we are missing?
   Why would we want to do that?

 Miguel

 On Wed, Dec 3, 2014 at 10:33 AM, Alexander Köplinger 
 alex.koeplin...@outlook.com wrote:

 Mono today also only supports the format specifiers used in decimalFmt:
 https://github.com/mono/mono/blob/f8a517624de3fdfc070d2f0660fce1b62d41bc4c/mcs/class/System.Numerics/System.Numerics/BigInteger.cs#L1458-L1471

 So using this #if for Mono is the correct way to go.

 (reposted, seems like the mailing list ate my previous mail)

 -- Alex

 --
 From: mig...@xamarin.com
 Date: Sat, 29 Nov 2014 12:06:20 -0500

 Subject: Re: [Mono-dev] Porting System.Numerics from referencesource,
 approaches for copying code?
 To: alex.koeplin...@outlook.com
 CC: mono-devel-list@lists.ximian.com

 Can you explain the rationale for the #if used with the same SILVERLIGHT
 setting?

 It seems like it limits the code.

 On Sat, Nov 29, 2014 at 12:03 PM, Alexander Köplinger 
 alex.koeplin...@outlook.com wrote:

 Yeah, that was what I was doing.

 I created these PRs:
 https://github.com/mono/referencesource/pull/1
 https://github.com/mono/mono/pull/1433

 -- Alex

 --
 From: mig...@xamarin.com
 Date: Sat, 29 Nov 2014 11:23:01 -0500

 Subject: Re: [Mono-dev] Porting System.Numerics from referencesource,
 approaches for copying code?
 To: alex.koeplin...@outlook.com
 CC: mono-devel-list@lists.ximian.com

 I just realized it might not have been 100% clear what I think we should
 do.

 We would in this case replace the references to our
 mono/mcs/class/XX/*/*cs source files, with the
 ../../external/referencesource/... files, and then alter the original
 referencesource file with the #if statements.

 We have done that already in a couple of places.

 (More to come, last night we got XML working, but needs some work)

 On Sat, Nov 29, 2014 at 11:21 AM, Miguel de Icaza mig...@xamarin.com
 wrote:

 Thanks Alex.

 I do not think that we will have a strict rule for when to copy and when
 to reference.

 There are scenarios where we will want to keep a lot of the code in one of
 our files, and pull code from the referencesource.   At that point, we will
 have to determine whether the use of #ifdefs or partial classes is a better
 long-term maintenance approach than copying the source.

 In this particular case, I feel that we can modify the reference source,
 and add the #if MONO around it.

 The reason is that the changes are pretty straight forward, it is mostly
 about disabling code, and not about picking some specific bits of code and
 putting them on our tree.   

[Mono-dev] End line/column information in symbol files

2015-01-05 Thread Zinkevicius, Matt
Hello,

When debugging our program on Linux with Mono 3.10, I've noticed that the 
source code sequence points that the soft debugger gives never include valid 
end line or end column numbers. They are always set to -1. Is this because the 
mono compiler doesn't include these values in the mdb symbol files? Perhaps I'm 
doing something wrong when invoking the soft debugger library?

Thanks,
Matt Zinkevicius

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


[Mono-dev] Mono.Posix Cross Compiling

2015-01-05 Thread Greg Young
Have anyone used mono.posix or mono.unix.native in a cross compiling
scenario where you have to support visual studio builds? How did you
handle this? I don't seem to be able to do a platform specific
reference.

I am not using much out of it and it seems like just copy/pasting the
extern definitions to monoposixhelper might be the easiest way.

Any ideas?

Greg

-- 
Studying for the Turing test
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Open source .Net, and TLS 1.1 1.2

2015-01-05 Thread Edward Ned Harvey (mono)
 From: Miguel de Icaza [mailto:mig...@xamarin.com]
 
 We have implemented TLS 1.1 and 1.2 on top of the not yet open sourced
 networking stack and will be publishing it as soon as Microsoft open sources
 the .NET networking stack.

Have there been unpublished changes to Mono.Security.X509.X509Chain?

Something I think I could reasonably do, if it's not a waste of time, is to 
improve the Build() method, so it will build a chain using both the roots 
store, and the intermediates store.  And come up with a way of populating the 
intermediates store.  (Such as improvement on mozroots.)

I wouldn't want to work on that, if it's obsoleted by code that will hopefully 
be published soon...
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] End line/column information in symbol files

2015-01-05 Thread Zinkevicius, Matt
I am seeing the starting line and column numbers, just not the ending ones. You 
are saying that the compiler is not providing these values? The place exists 
where to put these values in the symbol file but they always seem to be -1.

Is there a reason this is not supported? Would a patch to fix this to welcomed?

--Matt

From: Zoltan Varga [mailto:var...@gmail.com]
Sent: Monday, January 5, 2015 4:23 PM
To: Zinkevicius, Matt
Cc: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] End line/column information in symbol files

Hi,

  There is a tool named mdbdump in mcs/class/lib/net_4_5/mdbdumb.exe which can 
be used to dump the contents of .mdb files. In this case, mcs currently doesn't 
generate column numbers, so sdb cannot return them.

  Zoltan

On Mon, Jan 5, 2015 at 6:12 PM, Zinkevicius, Matt 
matt.zinkevic...@hp.commailto:matt.zinkevic...@hp.com wrote:
Hello,

When debugging our program on Linux with Mono 3.10, I’ve noticed that the 
source code sequence points that the soft debugger gives never include valid 
end line or end column numbers. They are always set to -1. Is this because the 
mono compiler doesn’t include these values in the mdb symbol files? Perhaps I’m 
doing something wrong when invoking the soft debugger library?

Thanks,
Matt Zinkevicius


___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.commailto:Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Mono.Posix Cross Compiling

2015-01-05 Thread David Curylo
Greg,

If you edit the .csproj file, you can have a platform-specific reference 
Mono.Posix like this:

Reference Include=Mono.Posix Condition= '$(OS)' != 'Windows_NT'  /

On Windows with Visual Studio or msbuild, the reference will be ignored.  
Building under mono with Xamarin Studio, Monodevelop, or xbuild, the reference 
will be included.

-Dave

On Jan 5, 2015, at 6:08 PM, Greg Young gregoryyou...@gmail.com wrote:

 Have anyone used mono.posix or mono.unix.native in a cross compiling
 scenario where you have to support visual studio builds? How did you
 handle this? I don't seem to be able to do a platform specific
 reference.
 
 I am not using much out of it and it seems like just copy/pasting the
 extern definitions to monoposixhelper might be the easiest way.
 
 Any ideas?
 
 Greg
 
 -- 
 Studying for the Turing test
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Mono.Posix Cross Compiling

2015-01-05 Thread Greg Young
Ah nice I didn't know you could do that. Thanks! Saves me the trouble
of copying bunches of externs :)

Greg

On Tue, Jan 6, 2015 at 5:01 AM, David Curylo cury...@asme.org wrote:
 Greg,

 If you edit the .csproj file, you can have a platform-specific reference 
 Mono.Posix like this:

 Reference Include=Mono.Posix Condition= '$(OS)' != 'Windows_NT'  /

 On Windows with Visual Studio or msbuild, the reference will be ignored.  
 Building under mono with Xamarin Studio, Monodevelop, or xbuild, the 
 reference will be included.

 -Dave

 On Jan 5, 2015, at 6:08 PM, Greg Young gregoryyou...@gmail.com wrote:

 Have anyone used mono.posix or mono.unix.native in a cross compiling
 scenario where you have to support visual studio builds? How did you
 handle this? I don't seem to be able to do a platform specific
 reference.

 I am not using much out of it and it seems like just copy/pasting the
 extern definitions to monoposixhelper might be the easiest way.

 Any ideas?

 Greg

 --
 Studying for the Turing test
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list




-- 
Studying for the Turing test
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Porting System.Numerics from referencesource, approaches for copying code?

2015-01-05 Thread Alexander Köplinger
Thanks Miguel, I merged the referencesource PR in and it seems the Mono PR 
which replaces existing implementation is green now on Jenkins: 
https://github.com/mono/mono/pull/1433
Just wanted to confirm you're OK with merging that one in as well :)
 
-- Alex
 
From: mig...@xamarin.com
Date: Mon, 5 Jan 2015 12:10:39 -0200
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

Hey,
Sorry, really poor email on my part.
You answered my concern to my satisfaction, so this is good to go.
Miguel
On Mon, Jan 5, 2015 at 12:09 PM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



Anything left for me to do on this one? :)

-- Alex
 
From: mig...@xamarin.com
Date: Wed, 3 Dec 2014 13:34:47 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

Got it.
Miguel
On Wed, Dec 3, 2014 at 11:13 AM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



To make this 100% clear: .NET implements locale aware number formatting in the 
VM, e.g. for format specifiers like 'e' (exponential) or 'f' (fixed-point)  it 
calls into the VM for formatting.
We don't have this in Mono atm., so the only way is to restrict it to the 
invariant format specifiers (which doesn't hurt existing Mono users, since it 
didn't work before too).

-- Alex
 
From: alex.koeplin...@outlook.com
To: mig...@xamarin.com
Date: Wed, 3 Dec 2014 17:01:42 +0100
CC: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?




Hey,
we need to ensure we only continue for the format specifiers used in 
decimalFmt. Any other format specifier (i.e. culture-specific ones) would 
result in a call into unmanaged code later on 
(https://github.com/akoeplinger/referencesource/blob/mono/System.Numerics/System/Numerics/BigNumber.cs#L611-L634)
 which we of course don't have implemented.
 
Note that it only throws an exception when decimalFmt == false, i.e. when any 
of the culture-specific specifiers was used (which is *not* a common code 
path). This is exactly what the current Mono code also does: 
https://github.com/mono/mono/blob/f8a517624de3fdfc070d2f0660fce1b62d41bc4c/mcs/class/System.Numerics/System.Numerics/BigInteger.cs#L1470
 
-- Alex
 
From: mig...@xamarin.com
Date: Wed, 3 Dec 2014 10:52:04 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

Hello Alex,
I am not sure I am understanding this.
This looks like we are choosing to not bring features that we are missing?   
Why would we want to do that?
Miguel
On Wed, Dec 3, 2014 at 10:33 AM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



Mono today also only supports the format specifiers used in decimalFmt: 
https://github.com/mono/mono/blob/f8a517624de3fdfc070d2f0660fce1b62d41bc4c/mcs/class/System.Numerics/System.Numerics/BigInteger.cs#L1458-L1471
 
So using this #if for Mono is the correct way to go.
 
(reposted, seems like the mailing list ate my previous mail) 

-- Alex
 
From: mig...@xamarin.com
Date: Sat, 29 Nov 2014 12:06:20 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

Can you explain the rationale for the #if used with the same SILVERLIGHT 
setting?
It seems like it limits the code.
On Sat, Nov 29, 2014 at 12:03 PM, Alexander Köplinger 
alex.koeplin...@outlook.com wrote:



Yeah, that was what I was doing.
 
I created these PRs:
https://github.com/mono/referencesource/pull/1
https://github.com/mono/mono/pull/1433 

-- Alex
 
From: mig...@xamarin.com
Date: Sat, 29 Nov 2014 11:23:01 -0500
Subject: Re: [Mono-dev] Porting System.Numerics from referencesource, 
approaches for copying code?
To: alex.koeplin...@outlook.com
CC: mono-devel-list@lists.ximian.com

I just realized it might not have been 100% clear what I think we should do.
We would in this case replace the references to our mono/mcs/class/XX/*/*cs 
source files, with the ../../external/referencesource/... files, and then 
alter the original referencesource file with the #if statements.
We have done that already in a couple of places.
(More to come, last night we got XML working, but needs some work)
On Sat, Nov 29, 2014 at 11:21 AM, Miguel de Icaza mig...@xamarin.com wrote:
Thanks Alex.
I do not think that we will have a strict rule for when to copy and when to 
reference.  
There are scenarios where we will want to keep a lot of the code in one of our 
files, and pull code from the referencesource.   At that point, we will have to 
determine whether the use of #ifdefs or partial classes is a better long-term 
maintenance approach than copying the source.
In this particular