Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-12-02 Thread Arina Itkes 
The previous code:

public string Url {
-   get { return url; }
-   set {
-   url = value;
-   uri = new Uri (url);
-   }

can cause inconsistent values of uri and Url with multithreading work.

-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Atsushi
Eno
Sent: Thursday, November 29, 2007 11:07 PM
To: mono-devel
Subject: Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety
fix.

Well, I'm still not sure. Why is the Uri change related to the
thread safety issue? I know that your patch had included the change.
I was asking for the reason why.

Atsushi Eno

Arina Itkes wrote:
 Fix for thread safety had included changes in Url property. It was
made
 with calling to property supported only by net 2.0. Now it supported
by
 net 1.0 too.
 
 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi
 Eno
 Sent: Tuesday, November 27, 2007 10:13 PM
 To: mono-devel
 Subject: Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety
 fix.
 
 Hi,
 
 Please explain how come Uri is related to thread safety?
 
 Atsushi Eno
 
 Arina Itkes wrote:
 Please review additional fix for Url get property. Now it supported
by
 NET_1_1 too.

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Arina
 Itkes
 Sent: Thursday, November 15, 2007 2:57 PM
 To: mono-devel
 Subject: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

  Hi all,

  Please review the attached patch. 

  It contains synchronization fix for the class
 WebClientAsyncResult and light changes for the class
WebClientProtocol
 that is a base of SoapHttpClientProtocol for thread safety purpose.





 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 
 
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 



___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-12-02 Thread Alan McGovern 
Well, it is explicitly stated that instance members are not threadsafe by
default. If you're modifying an object from multiple threads simultaneously,
then you have a bug in your code (unless the docs for that object explicitly
state that the methods/properties you are using are threadsafe). Therefore a
patch which has 'thread safety' fixes for stuff that is not supposed to be
threadsafe doesn't make much sense. I think this is what Atsushi was saying.

Alan.

On Dec 2, 2007 12:57 PM, Arina Itkes [EMAIL PROTECTED] wrote:

 The previous code:

public string Url {
 -   get { return url; }
 -   set {
 -   url = value;
 -   uri = new Uri (url);
 -   }

 can cause inconsistent values of uri and Url with multithreading work.

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi
 Eno
 Sent: Thursday, November 29, 2007 11:07 PM
 To: mono-devel
 Subject: Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety
 fix.

 Well, I'm still not sure. Why is the Uri change related to the
 thread safety issue? I know that your patch had included the change.
 I was asking for the reason why.

 Atsushi Eno

 Arina Itkes wrote:
  Fix for thread safety had included changes in Url property. It was
 made
  with calling to property supported only by net 2.0. Now it supported
 by
  net 1.0 too.
 
  -Original Message-
  From: [EMAIL PROTECTED]
  [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi
  Eno
  Sent: Tuesday, November 27, 2007 10:13 PM
  To: mono-devel
  Subject: Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety
  fix.
 
  Hi,
 
  Please explain how come Uri is related to thread safety?
 
  Atsushi Eno
 
  Arina Itkes wrote:
  Please review additional fix for Url get property. Now it supported
 by
  NET_1_1 too.
 
  -Original Message-
  From: [EMAIL PROTECTED]
  [mailto:[EMAIL PROTECTED] On Behalf Of Arina
  Itkes
  Sent: Thursday, November 15, 2007 2:57 PM
  To: mono-devel
  Subject: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.
 
   Hi all,
 
   Please review the attached patch.
 
   It contains synchronization fix for the class
  WebClientAsyncResult and light changes for the class
 WebClientProtocol
  that is a base of SoapHttpClientProtocol for thread safety purpose.
 
 
 
 
 
  ___
  Mono-devel-list mailing list
  Mono-devel-list@lists.ximian.com
  http://lists.ximian.com/mailman/listinfo/mono-devel-list
 
 
  ___
  Mono-devel-list mailing list
  Mono-devel-list@lists.ximian.com
  http://lists.ximian.com/mailman/listinfo/mono-devel-list
 



 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-12-02 Thread Robert Jordan 
Alan McGovern wrote:
 Well, it is explicitly stated that instance members are not threadsafe by
 default. If you're modifying an object from multiple threads simultaneously,

 From MSDN's docs of SoapHttpClientProtocol:

Thread Safety
This type is thread safe


Robert



 then you have a bug in your code (unless the docs for that object explicitly
 state that the methods/properties you are using are threadsafe). Therefore a
 patch which has 'thread safety' fixes for stuff that is not supposed to be
 threadsafe doesn't make much sense. I think this is what Atsushi was saying.
 
 Alan.
 
 On Dec 2, 2007 12:57 PM, Arina Itkes [EMAIL PROTECTED] wrote:
 
 The previous code:

public string Url {
 -   get { return url; }
 -   set {
 -   url = value;
 -   uri = new Uri (url);
 -   }

 can cause inconsistent values of uri and Url with multithreading work.

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi
 Eno
 Sent: Thursday, November 29, 2007 11:07 PM
 To: mono-devel
 Subject: Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety
 fix.

 Well, I'm still not sure. Why is the Uri change related to the
 thread safety issue? I know that your patch had included the change.
 I was asking for the reason why.

 Atsushi Eno

 Arina Itkes wrote:
 Fix for thread safety had included changes in Url property. It was
 made
 with calling to property supported only by net 2.0. Now it supported
 by
 net 1.0 too.

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi
 Eno
 Sent: Tuesday, November 27, 2007 10:13 PM
 To: mono-devel
 Subject: Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety
 fix.

 Hi,

 Please explain how come Uri is related to thread safety?

 Atsushi Eno

 Arina Itkes wrote:
 Please review additional fix for Url get property. Now it supported
 by
 NET_1_1 too.

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Arina
 Itkes
 Sent: Thursday, November 15, 2007 2:57 PM
 To: mono-devel
 Subject: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

  Hi all,

  Please review the attached patch.

  It contains synchronization fix for the class
 WebClientAsyncResult and light changes for the class
 WebClientProtocol
 that is a base of SoapHttpClientProtocol for thread safety purpose.



 
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list

 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list



 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list

 
 
 
 
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-11-30 Thread Hubert FONGARNAND 
Hi Arina,

I'm experiencing some problems with WebService client with mono :
I get some :


Error thrown in application CASServer, message is : Error getting response 
stream (ReadDone2): ReceiveFailure Exception System.Net.WebException: Error 
getting response stream (ReadDone2): ReceiveFailure --- System.Exception: 
at System.Net.WebConnection.HandleError ()
at System.Net.WebConnection.ReadDone ()
at System.MulticastDelegate.invoke_void_IAsyncResult ()
at System.Net.Sockets.Socket+SocketAsyncResult.Complete ()
at System.Net.Sockets.Socket+Worker.Receive ()
at System.MulticastDelegate.invoke_void ()
at System.Net.WebConnection.HandleError (WebExceptionStatus st, 
System.Exception e, System.String where) [0x0] --- End of inner exception 
stack trace ---

at System.Net.HttpWebRequest.EndGetResponse (IAsyncResult asyncResult) 
[0x0] 
at System.Net.HttpWebRequest.GetResponse () [0x0] 
at System.Web.Services.Protocols.WebClientProtocol.GetWebResponse 
(System.Net.WebRequest request) [0x0]


On our production server... but i can't reproduce this specific problem
on my dev machine.
Does your patch is related to this kind of problem?
Had you ever get such problems?

Thanks 


Le jeudi 15 novembre 2007 à 04:56 -0800, Arina Itkes a écrit :

   Hi all,
 
   Please review the attached patch. 
 
   It contains synchronization fix for the class
 WebClientAsyncResult and light changes for the class WebClientProtocol
 that is a base of SoapHttpClientProtocol for thread safety purpose.
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list

_
Ce message et les éventuels documents joints peuvent contenir des informations 
confidentielles.
Au cas où il ne vous serait pas destiné, nous vous remercions de bien vouloir 
le supprimer et en aviser immédiatement l'expéditeur. Toute utilisation de ce 
message non conforme à sa destination, toute diffusion ou publication, totale 
ou partielle et quel qu'en soit le moyen est formellement interdite.
Les communications sur internet n'étant pas sécurisées, l'intégrité de ce 
message n'est pas assurée et la société émettrice ne peut être tenue pour 
responsable de son contenu.

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-11-29 Thread Atsushi Eno 
Well, I'm still not sure. Why is the Uri change related to the
thread safety issue? I know that your patch had included the change.
I was asking for the reason why.

Atsushi Eno

Arina Itkes wrote:
 Fix for thread safety had included changes in Url property. It was made
 with calling to property supported only by net 2.0. Now it supported by
 net 1.0 too.
 
 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi
 Eno
 Sent: Tuesday, November 27, 2007 10:13 PM
 To: mono-devel
 Subject: Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety
 fix.
 
 Hi,
 
 Please explain how come Uri is related to thread safety?
 
 Atsushi Eno
 
 Arina Itkes wrote:
 Please review additional fix for Url get property. Now it supported by
 NET_1_1 too.

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED] On Behalf Of Arina
 Itkes
 Sent: Thursday, November 15, 2007 2:57 PM
 To: mono-devel
 Subject: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

  Hi all,

  Please review the attached patch. 

  It contains synchronization fix for the class
 WebClientAsyncResult and light changes for the class WebClientProtocol
 that is a base of SoapHttpClientProtocol for thread safety purpose.



 
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 
 
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
 



___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-11-27 Thread Arina Itkes 
Please review additional fix for Url get property. Now it supported by
NET_1_1 too.

-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Arina
Itkes
Sent: Thursday, November 15, 2007 2:57 PM
To: mono-devel
Subject: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

Hi all,

Please review the attached patch. 

It contains synchronization fix for the class
WebClientAsyncResult and light changes for the class WebClientProtocol
that is a base of SoapHttpClientProtocol for thread safety purpose.


WebServicesProtocolPatch.patch
Description: WebServicesProtocolPatch.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-11-15 Thread Arina Itkes 
Hi all,

Please review the attached patch. 

It contains synchronization fix for the class
WebClientAsyncResult and light changes for the class WebClientProtocol
that is a base of SoapHttpClientProtocol for thread safety purpose.


WebServicesProtocolPatch.patch
Description: WebServicesProtocolPatch.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list