[Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
Hi,
The attached patch provides some trivial fixes for XmlDsig transforms in
System.Security, and adds/improves unit tests.
Let me know if this is ok to commit.
Gert
Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
===
--- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs (revision 110022)
+++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs (working copy)
@@ -23,8 +23,17 @@
// Note: GetInnerXml is protected in XmlDsigXsltTransform making it
// difficult to test properly. This class "open it up" :-)
- public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform {
+ public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
+ {
+ public UnprotectedXmlDsigXsltTransform ()
+ {
+ }
+ public UnprotectedXmlDsigXsltTransform (bool includeComments)
+ : base (includeComments)
+ {
+ }
+
public XmlNodeList UnprotectedGetInnerXml () {
return base.GetInnerXml ();
}
@@ -36,14 +45,28 @@
protected UnprotectedXmlDsigXsltTransform transform;
[SetUp]
- protected void SetUp ()
+ protected void SetUp ()
{
transform = new UnprotectedXmlDsigXsltTransform ();
}
- [Test]
- public void Properties ()
+ [Test] // ctor ()
+ public void Constructor1 ()
{
+ CheckProperties (transform);
+ }
+
+ [Test] // ctor (Boolean)
+ public void Constructor2 ()
+ {
+ transform = new UnprotectedXmlDsigXsltTransform (true);
+ CheckProperties (transform);
+ transform = new UnprotectedXmlDsigXsltTransform (false);
+ CheckProperties (transform);
+ }
+
+ void CheckProperties (XmlDsigXsltTransform transform)
+ {
AssertEquals ("Algorithm", "http://www.w3.org/TR/1999/REC-xslt-19991116";, transform.Algorithm);
Type[] input = transform.InputTypes;
Property changes on: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
___
Name: svn:eol-style
+ native
Index: Test/System.Security.Cryptography.Xml/ChangeLog
===
--- Test/System.Security.Cryptography.Xml/ChangeLog (revision 110022)
+++ Test/System.Security.Cryptography.Xml/ChangeLog (working copy)
@@ -1,3 +1,16 @@
+2008-08-09 Gert Driesen <[EMAIL PROTECTED]>
+
+ * XmlDsigXsltTranformTest.cs: Added test for .ctor (bool).
+ * XmlDsigEnvelopedTransformTest.cs: Added test for .ctor (bool). Use
+ Assert class. Improved properties tests.
+ * XmlDsigC14TransformTest.cs: Added test for .ctor (bool).
+ * XmlDsigExcC14NTransformTest.cs: Added .ctor tests and added asserts
+ IncludsiveNamespacesPrefixList
+ * XmlDsigExcC14NWithCommentsTransformTest.cs: Added basic .ctor and
+ properties tests.
+ * XmlDsigC14NWithCommentsTransformTest.cs: Fixed line endings.
+ * XmlLicenseTransformTest.cs: Added basic .ctor and properties tests.
+
2008-05-25 Sebastien Pouliot <[EMAIL PROTECTED]>
* XmlDsigBase64TransformTest.cs: Add test case for InputTypes
Index: Test/System.Security.Cryptography.Xml/XmlDsigEnvelopedSignatureTransformTest.cs
===
--- Test/System.Security.Cryptography.Xml/XmlDsigEnvelopedSignatureTransformTest.cs (revision 110022)
+++ Test/System.Security.Cryptography.Xml/XmlDsigEnvelopedSignatureTransformTest.cs (working copy)
@@ -21,79 +21,103 @@
// Note: GetInnerXml is protected in XmlDsigEnvelopedSignatureTransform making it
// difficult to test properly. This class "open it up" :-)
- public class UnprotectedXmlDsigEnvelopedSignatureTransform : XmlDsigEnvelopedSignatureTransform {
+ public class UnprotectedXmlDsigEnvelopedSignatureTransform : XmlDsigEnvelopedSignatureTransform
+ {
+ public UnprotectedXmlDsigEnvelopedSignatureTransform ()
+ {
+ }
- public XmlNodeList UnprotectedGetInnerXml ()
+ public UnprotectedXmlDsigEnvelopedSignatureTransform (bool includeComments)
+ : base (includeComments)
{
+ }
+
+ public XmlNodeList UnprotectedGetInnerXml ()
+ {
return base.GetInnerXml ();
}
}
[TestFixture]
- public class XmlDsigEnvelopedSignatureTransformTest : Assertion {
+ public class XmlDsigEnvelopedSignatureTransformTest
+ {
+ private UnprotectedXmlDsigEnvelopedSignatureTransform transform;
- protected UnprotectedXmlDsigEnvelopedSignatureTransform transform;
-
[SetUp]
- protected void SetUp ()
+ public void SetUp ()
{
transform = new UnprotectedXmlDsigEnvelopedSignatureTransform ();
}
- [Test]
- public void Properties ()
+ [Test] // ctor ()
+ public void Constructor1 ()
{
- AssertEquals ("Algorithm", "http://www.w3.org/2000/09/xmldsig#enveloped-signature";, transform.Algorithm);
+ CheckProperties (transform);
+ }
- Type[] input = transform.InputTypes;
- AssertEquals ("Input Length", 3, input.Length);
+ [Test] // ctor (Boolean)
+ public void Constructor2 ()
+ {
+ transform = new UnprotectedXmlDsigEnvelopedSignatur
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote:
> Hi,
>
> The attached patch provides some trivial fixes for XmlDsig transforms in
> System.Security, and adds/improves unit tests.
>
> Let me know if this is ok to commit.
No. It seems there's good stuff (like updating the old syntax of unit
tests) but then there's all the other unneeded stuff part of this patch
(some examples follows).
>
>
>
>
>
> differences between files attachment (xmldsig.patch)
>
> Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> ===
> --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (revision 110022)
> +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (working copy)
> @@ -23,8 +23,17 @@
>
> // Note: GetInnerXml is protected in XmlDsigXsltTransform making it
> // difficult to test properly. This class "open it up" :-)
> - public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform {
> + public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> + {
Your interpretation was different than mine so you asked (I think I
suggested it) on mono-dev about this (May 26th) and Miguel's answer (May
27th) was clear:
"Same line, there are a couple of samples on that page."
Anyway please do not introduce unneeded changes into your patches.
> + public UnprotectedXmlDsigXsltTransform ()
> + {
> + }
>
> + public UnprotectedXmlDsigXsltTransform (bool includeComments)
> + : base (includeComments)
> + {
> + }
> +
> public XmlNodeList UnprotectedGetInnerXml () {
> return base.GetInnerXml ();
> }
> @@ -36,14 +45,28 @@
> protected UnprotectedXmlDsigXsltTransform transform;
>
> [SetUp]
> - protected void SetUp ()
> + protected void SetUp ()
This is another case that should not be in the patch (unneeded change).
Yes I too dislike the extra space after () but let's not disturb those
bits on everyone boxes.
...
>
> - private XmlDocument GetDoc ()
> + XmlDocument GetDoc ()
Another example of an unneeded change. private is not required but it's
there (so let it be).
...
> @@ -168,7 +260,7 @@
>
> [Test]
> #if NET_2_0
> - [Category ("NotDotNet")]
> + [Category ("NotDotNet")]
I can't see why this change is needed, so I assume it's about line
endings ?!?
If this is required please let's do the line endings changes in a
separate commit (after ensuring it does not affect unit tests) and
generate the patch afterward.
...
Sebastien
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
Hey Sebastien,
I'm remove all unnecessary changes (like the brace position, bad habits ...)
and resubmit the patch for review.
Gert
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien Pouliot
Sent: donderdag 14 augustus 2008 2:58
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig
transforms
On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote:
> Hi,
>
> The attached patch provides some trivial fixes for XmlDsig transforms in
> System.Security, and adds/improves unit tests.
>
> Let me know if this is ok to commit.
No. It seems there's good stuff (like updating the old syntax of unit
tests) but then there's all the other unneeded stuff part of this patch
(some examples follows).
>
>
>
>
>
> differences between files attachment (xmldsig.patch)
>
> Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> ===
> --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (revision 110022)
> +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (working copy)
> @@ -23,8 +23,17 @@
>
> // Note: GetInnerXml is protected in XmlDsigXsltTransform making it
> // difficult to test properly. This class "open it up" :-)
> - public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform {
> + public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> + {
Your interpretation was different than mine so you asked (I think I
suggested it) on mono-dev about this (May 26th) and Miguel's answer (May
27th) was clear:
"Same line, there are a couple of samples on that page."
Anyway please do not introduce unneeded changes into your patches.
> + public UnprotectedXmlDsigXsltTransform ()
> + {
> + }
>
> + public UnprotectedXmlDsigXsltTransform (bool includeComments)
> + : base (includeComments)
> + {
> + }
> +
> public XmlNodeList UnprotectedGetInnerXml () {
> return base.GetInnerXml ();
> }
> @@ -36,14 +45,28 @@
> protected UnprotectedXmlDsigXsltTransform transform;
>
> [SetUp]
> - protected void SetUp ()
> + protected void SetUp ()
This is another case that should not be in the patch (unneeded change).
Yes I too dislike the extra space after () but let's not disturb those
bits on everyone boxes.
...
>
> - private XmlDocument GetDoc ()
> + XmlDocument GetDoc ()
Another example of an unneeded change. private is not required but it's
there (so let it be).
...
> @@ -168,7 +260,7 @@
>
> [Test]
> #if NET_2_0
> - [Category ("NotDotNet")]
> + [Category ("NotDotNet")]
I can't see why this change is needed, so I assume it's about line
endings ?!?
If this is required please let's do the line endings changes in a
separate commit (after ensuring it does not affect unit tests) and
generate the patch afterward.
...
Sebastien
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
> Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> ===
> --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (revision 110022)
> +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (working copy)
> @@ -23,8 +23,17 @@
>
> // Note: GetInnerXml is protected in XmlDsigXsltTransform making it
> // difficult to test properly. This class "open it up" :-)
> - public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform {
> + public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> + {
Your interpretation was different than mine so you asked (I think I
suggested it) on mono-dev about this (May 26th) and Miguel's answer (May
27th) was clear:
"Same line, there are a couple of samples on that page."
Anyway please do not introduce unneeded changes into your patches.
> + public UnprotectedXmlDsigXsltTransform ()
> + {
> + }
>
> + public UnprotectedXmlDsigXsltTransform (bool includeComments)
> + : base (includeComments)
> + {
> + }
Did you include this in your remarks to signal that braces should go on the
same line for .ctors (as opposed to methods, where they go on a new line)?
There's an example on the Coding Guidelines page that places braces on the same
line for .ctor, but the guidelines also clearly state the braces should go on a
new line for methods (even though there is sample code on that same page that
places it on the same line, pff).
Perhaps we should include a table that clearly lists the bracing style we
prefer:
Namespace same line
Types same line
Methodsnew line
Constructors new line (?)
Properties same line
Anonymous Methods same line (?)
Anonymous Typessame line (?)
Control Blocks same line
Gert
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
The attached patch should take care of your remarks.
Let me know if it's ok to commit.
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gert Driesen
Sent: donderdag 14 augustus 2008 4:53
To: 'Sebastien Pouliot'
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig
transforms
Hey Sebastien,
I'm remove all unnecessary changes (like the brace position, bad habits ...)
and resubmit the patch for review.
Gert
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien Pouliot
Sent: donderdag 14 augustus 2008 2:58
To: Gert Driesen
Cc: [EMAIL PROTECTED]
Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig
transforms
On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote:
> Hi,
>
> The attached patch provides some trivial fixes for XmlDsig transforms in
> System.Security, and adds/improves unit tests.
>
> Let me know if this is ok to commit.
No. It seems there's good stuff (like updating the old syntax of unit
tests) but then there's all the other unneeded stuff part of this patch
(some examples follows).
>
>
>
>
>
> differences between files attachment (xmldsig.patch)
>
> Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> ===
> --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (revision 110022)
> +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> (working copy)
> @@ -23,8 +23,17 @@
>
> // Note: GetInnerXml is protected in XmlDsigXsltTransform making it
> // difficult to test properly. This class "open it up" :-)
> - public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform {
> + public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> + {
Your interpretation was different than mine so you asked (I think I
suggested it) on mono-dev about this (May 26th) and Miguel's answer (May
27th) was clear:
"Same line, there are a couple of samples on that page."
Anyway please do not introduce unneeded changes into your patches.
> + public UnprotectedXmlDsigXsltTransform ()
> + {
> + }
>
> + public UnprotectedXmlDsigXsltTransform (bool includeComments)
> + : base (includeComments)
> + {
> + }
> +
> public XmlNodeList UnprotectedGetInnerXml () {
> return base.GetInnerXml ();
> }
> @@ -36,14 +45,28 @@
> protected UnprotectedXmlDsigXsltTransform transform;
>
> [SetUp]
> - protected void SetUp ()
> + protected void SetUp ()
This is another case that should not be in the patch (unneeded change).
Yes I too dislike the extra space after () but let's not disturb those
bits on everyone boxes.
...
>
> - private XmlDocument GetDoc ()
> + XmlDocument GetDoc ()
Another example of an unneeded change. private is not required but it's
there (so let it be).
...
> @@ -168,7 +260,7 @@
>
> [Test]
> #if NET_2_0
> - [Category ("NotDotNet")]
> + [Category ("NotDotNet")]
I can't see why this change is needed, so I assume it's about line
endings ?!?
If this is required please let's do the line endings changes in a
separate commit (after ensuring it does not affect unit tests) and
generate the patch afterward.
...
Sebastien
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
xmldsig.patch
Description: Binary data
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
On Thu, 2008-08-14 at 04:52 +0200, Gert Driesen wrote:
> Hey Sebastien,
>
> I'm remove all unnecessary changes (like the brace position, bad
> habits ...) and resubmit the patch for review.
Thanks!
Sebastien
> Gert
>
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien
> Pouliot
> Sent: donderdag 14 augustus 2008 2:58
> To: Gert Driesen
> Cc: [EMAIL PROTECTED]
> Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig
> transforms
>
> On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote:
> > Hi,
> >
> > The attached patch provides some trivial fixes for XmlDsig transforms in
> > System.Security, and adds/improves unit tests.
> >
> > Let me know if this is ok to commit.
>
> No. It seems there's good stuff (like updating the old syntax of unit
> tests) but then there's all the other unneeded stuff part of this patch
> (some examples follows).
>
> >
> >
> >
> >
> >
> > differences between files attachment (xmldsig.patch)
> >
> > Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> > ===
> > --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> > (revision 110022)
> > +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> > (working copy)
> > @@ -23,8 +23,17 @@
> >
> > // Note: GetInnerXml is protected in XmlDsigXsltTransform making it
> > // difficult to test properly. This class "open it up" :-)
> > - public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> > {
> > + public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> > + {
>
> Your interpretation was different than mine so you asked (I think I
> suggested it) on mono-dev about this (May 26th) and Miguel's answer (May
> 27th) was clear:
> "Same line, there are a couple of samples on that page."
>
> Anyway please do not introduce unneeded changes into your patches.
>
> > + public UnprotectedXmlDsigXsltTransform ()
> > + {
> > + }
> >
> > + public UnprotectedXmlDsigXsltTransform (bool
> > includeComments)
> > + : base (includeComments)
> > + {
> > + }
> > +
> > public XmlNodeList UnprotectedGetInnerXml () {
> > return base.GetInnerXml ();
> > }
> > @@ -36,14 +45,28 @@
> > protected UnprotectedXmlDsigXsltTransform transform;
> >
> > [SetUp]
> > - protected void SetUp ()
> > + protected void SetUp ()
>
> This is another case that should not be in the patch (unneeded change).
> Yes I too dislike the extra space after () but let's not disturb those
> bits on everyone boxes.
>
> ...
>
> >
> > - private XmlDocument GetDoc ()
> > + XmlDocument GetDoc ()
>
> Another example of an unneeded change. private is not required but it's
> there (so let it be).
>
> ...
>
> > @@ -168,7 +260,7 @@
> >
> > [Test]
> > #if NET_2_0
> > - [Category ("NotDotNet")]
> > + [Category ("NotDotNet")]
>
> I can't see why this change is needed, so I assume it's about line
> endings ?!?
>
> If this is required please let's do the line endings changes in a
> separate commit (after ensuring it does not affect unit tests) and
> generate the patch afterward.
>
> ...
>
>
> Sebastien
>
> ___
> Mono-devel-list mailing list
> Mono-devel-list@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
On Thu, 2008-08-14 at 06:35 +0200, Gert Driesen wrote:
> > Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> > ===
> > --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> > (revision 110022)
> > +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> > (working copy)
> > @@ -23,8 +23,17 @@
> >
> > // Note: GetInnerXml is protected in XmlDsigXsltTransform making it
> > // difficult to test properly. This class "open it up" :-)
> > - public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> > {
> > + public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> > + {
>
> Your interpretation was different than mine so you asked (I think I
> suggested it) on mono-dev about this (May 26th) and Miguel's answer (May
> 27th) was clear:
> "Same line, there are a couple of samples on that page."
>
> Anyway please do not introduce unneeded changes into your patches.
>
> > + public UnprotectedXmlDsigXsltTransform ()
> > + {
> > + }
> >
> > + public UnprotectedXmlDsigXsltTransform (bool
> > includeComments)
> > + : base (includeComments)
> > + {
> > + }
>
> Did you include this in your remarks to signal that braces should go
> on the same line for .ctors (as opposed to methods, where they go on a
> new line)?
No.
> There's an example on the Coding Guidelines page that places braces on
> the same line for .ctor, but the guidelines also clearly state the
> braces should go on a new line for methods (even though there is
> sample code on that same page that places it on the same line, pff).
IMO ctors are (special) methods. However I probably (I can't go back in
time to prove it ;-) would not have refused the patch for this (alone).
> Perhaps we should include a table that clearly lists the bracing style
> we prefer:
>
> Namespace same line
> Types same line
> Methodsnew line
> Constructors new line (?)
> Properties same line
> Anonymous Methods same line (?)
> Anonymous Typessame line (?)
> Control Blocks same line
It would be interesting to have such a recapitulating table inside the
wiki.
However such table, if/when existing, should not be interpreted as "must
be changed at first opportunity" ;-)
Sebastien
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien Pouliot Sent: donderdag 14 augustus 2008 14:05 To: Gert Driesen Cc: [EMAIL PROTECTED] Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms > Perhaps we should include a table that clearly lists the bracing style > we prefer: > > > Namespace same line > > Types same line > > Methodsnew line > > Constructors new line (?) > > Properties same line > > Anonymous Methods same line (?) > > Anonymous Typessame line (?) > > Control Blocks same line > > > It would be interesting to have such a recapitulating table inside the > wiki. > > However such table, if/when existing, should not be interpreted as "must > be changed at first opportunity" ;-) No, but at least we'd have something indisputable to redirect committers to for new sources. Can someone with write access add this to the wiki? Thanks ! Gert ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sebastien > Pouliot > Sent: donderdag 14 augustus 2008 14:03 > To: Gert Driesen > Cc: [EMAIL PROTECTED] > Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig > transforms > > On Thu, 2008-08-14 at 04:52 +0200, Gert Driesen wrote: > > Hey Sebastien, > > > > I'm remove all unnecessary changes (like the brace position, bad > > habits ...) and resubmit the patch for review. > > Thanks! Np. Can you (ask someone to) allow my updated patch to make it to the devel list (size restriction again, although I swear the patch is smaller now ;-))? Gert ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
Gert Driesen wrote: >> Perhaps we should include a table that clearly lists the bracing style >> we prefer: >> >>> Namespace same line >>> Types same line >>> Methodsnew line >>> Constructors new line (?) >>> Properties same line >>> Anonymous Methods same line (?) >>> Anonymous Typessame line (?) >>> Control Blocks same line >>> It would be interesting to have such a recapitulating table inside the >> wiki. >> >> However such table, if/when existing, should not be interpreted as "must >> be changed at first opportunity" ;-) > > No, but at least we'd have something indisputable to redirect committers to > for new sources. > > Can someone with write access add this to the wiki? > Done. Andrés -- ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
