Re: [Mono-dev] Please approve commit change toSystem.Web.Hosting/ApplicationHost.cs
Hi Gonzalo and all, I looked further into the need for using the URI object to validate the physical path passed in to the ApplicationHost.CreateApplicationHost method. I found out that there were tests in ApplicationHostTests that failed, and were marked with NotWorking, because of the Uri.Parse. So this patch actually improves the situation. I had to tweak the exceptions thrown by this method to be compatible with MS. Here is a patch (already committed) that includes these tweaks and the tests not marked as NotWorking. If you have any other comments, let me know. Thanks, --- Adar Wesley Mainsoft -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gonzalo Paniagua Javier Sent: Friday, January 12, 2007 8:01 AM To: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] Please approve commit change toSystem.Web.Hosting/ApplicationHost.cs On 1/9/07, Adar Wesley [EMAIL PROTECTED] wrote: Hi All, I would like to commit a change to ApplicationHost. The suggested diff follows: I've seen that this patch is already in, but it's wrong. Creating the Uri object was done so that we throw in the same cases that MS does. At least I would add the new Uri (blah) after getting the full path. -Gonzalo ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ApplicationHost.patch Description: ApplicationHost.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Please approve commit change toSystem.Web.Hosting/ApplicationHost.cs
Hello Adar, I looked further into the need for using the URI object to validate the physical path passed in to the ApplicationHost.CreateApplicationHost method. I found out that there were tests in ApplicationHostTests that failed, and were marked with NotWorking, because of the Uri.Parse. So this patch actually improves the situation. I had to tweak the exceptions thrown by this method to be compatible with MS. Here is a patch (already committed) that includes these tweaks and the tests not marked as NotWorking. Ah, great catch. Please commit it. ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Please approve commit change toSystem.Web.Hosting/ApplicationHost.cs
Will be handled by Tuesday. Regards, Kosta -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gonzalo Paniagua Javier Sent: Friday, January 12, 2007 8:01 AM To: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] Please approve commit change toSystem.Web.Hosting/ApplicationHost.cs On 1/9/07, Adar Wesley [EMAIL PROTECTED] wrote: Hi All, I would like to commit a change to ApplicationHost. The suggested diff follows: I've seen that this patch is already in, but it's wrong. Creating the Uri object was done so that we throw in the same cases that MS does. At least I would add the new Uri (blah) after getting the full path. -Gonzalo ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
