Re: [Mono-dev] Porting HttpApplication and associated classes

2014-11-20 Thread Miguel de Icaza


 First, we need to the fork and sub-module up and running for the reference
 source, so I can doing pull requests on there.


The referencesource submodule is there


 Second, come up with a way to exclude code without deleting it (I'm
 assuming we won't to go down the #ifdef route rather than simply removing
 the code from the fork).  I'm thinking there's probably something we can
 use already, so just need to know what that is.  (something like #if !MONO
 ??)


We should introduce a define, yes.

Perhaps we can introduce a CROSS_PLATFORM define that we use on the
Reference source to annotate those cases.

Third, Miguel had an idea of how to do the String resources so we don't
 need to refactor large amounts of the referencesource.  The script needs
 work, and is probably a job in it's own right.


That will get you running for now ;)

Finally, as I won't be replacing every file, some will just have large
 amounts of additions/fixes, it's probably worth getting the legacy #ifdef's
 before I send a pull.


Nah, I think it is easy.

The way you replace a class, is to remove the file from the .sources and
add the new one.   That should cover most bases.

Miguel
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Porting HttpApplication and associated classes

2014-11-20 Thread Martin Thwaites
Thanks Miguel, I'll get started properly tonight.

So the DEFINE will be #if !CROSS_PLATFORM to exclude anything that is
native and won't work on non-windows?

On 20 November 2014 13:27, Miguel de Icaza mig...@xamarin.com wrote:


 First, we need to the fork and sub-module up and running for the
 reference source, so I can doing pull requests on there.


 The referencesource submodule is there


 Second, come up with a way to exclude code without deleting it (I'm
 assuming we won't to go down the #ifdef route rather than simply removing
 the code from the fork).  I'm thinking there's probably something we can
 use already, so just need to know what that is.  (something like #if !MONO
 ??)


 We should introduce a define, yes.

 Perhaps we can introduce a CROSS_PLATFORM define that we use on the
 Reference source to annotate those cases.

 Third, Miguel had an idea of how to do the String resources so we don't
 need to refactor large amounts of the referencesource.  The script needs
 work, and is probably a job in it's own right.


 That will get you running for now ;)

 Finally, as I won't be replacing every file, some will just have large
 amounts of additions/fixes, it's probably worth getting the legacy #ifdef's
 before I send a pull.


 Nah, I think it is easy.

 The way you replace a class, is to remove the file from the .sources and
 add the new one.   That should cover most bases.

 Miguel

___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Porting HttpApplication and associated classes

2014-11-20 Thread Miguel de Icaza
Yes.

We will add the defines to the build profile so you get them soon

On Thursday, November 20, 2014, Martin Thwaites monofo...@my2cents.co.uk
wrote:

 Thanks Miguel, I'll get started properly tonight.

 So the DEFINE will be #if !CROSS_PLATFORM to exclude anything that is
 native and won't work on non-windows?

 On 20 November 2014 13:27, Miguel de Icaza mig...@xamarin.com
 javascript:_e(%7B%7D,'cvml','mig...@xamarin.com'); wrote:


 First, we need to the fork and sub-module up and running for the
 reference source, so I can doing pull requests on there.


 The referencesource submodule is there


 Second, come up with a way to exclude code without deleting it (I'm
 assuming we won't to go down the #ifdef route rather than simply removing
 the code from the fork).  I'm thinking there's probably something we can
 use already, so just need to know what that is.  (something like #if !MONO
 ??)


 We should introduce a define, yes.

 Perhaps we can introduce a CROSS_PLATFORM define that we use on the
 Reference source to annotate those cases.

 Third, Miguel had an idea of how to do the String resources so we don't
 need to refactor large amounts of the referencesource.  The script needs
 work, and is probably a job in it's own right.


 That will get you running for now ;)

 Finally, as I won't be replacing every file, some will just have large
 amounts of additions/fixes, it's probably worth getting the legacy #ifdef's
 before I send a pull.


 Nah, I think it is easy.

 The way you replace a class, is to remove the file from the .sources and
 add the new one.   That should cover most bases.

 Miguel



___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


[Mono-dev] Porting HttpApplication and associated classes

2014-11-19 Thread Martin Thwaites
Hi All,

I'm planning on taking on the porting of part of System.Web, so I thought I
would make people aware so that we're not all working on the same thing.

My process is to start with importing HttpApplication in it's entirety,
then pull in the surrounding classes so it compiles.  I can then start
running some tests to see how close we are.  Until the fork is in, I've
copied them into my local instance, and changing them there, so the sooner
we get the fork setup the better.

So far, I've noted that there are a few things that this work will be
dependent on.

First, we need to the fork and sub-module up and running for the reference
source, so I can doing pull requests on there.

Second, come up with a way to exclude code without deleting it (I'm
assuming we won't to go down the #ifdef route rather than simply removing
the code from the fork).  I'm thinking there's probably something we can
use already, so just need to know what that is.  (something like #if !MONO
??)

Third, Miguel had an idea of how to do the String resources so we don't
need to refactor large amounts of the referencesource.  The script needs
work, and is probably a job in it's own right.

Finally, as I won't be replacing every file, some will just have large
amounts of additions/fixes, it's probably worth getting the legacy #ifdef's
before I send a pull.

I have around a week to get this done, if I don't manage to get it
completed, I will be able to do some work, just not full-time.  I will
however make my fork available for people to continue it.

Please let me know your thoughts, and if you think there may be a better
way to do this.
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list