Re: [Mono-dev] monodis implemented with Cecil
Hello all, Thanks for your feedback. Miguel: Are you also planning on adding the table dumping features? They are not necessary if we keep monodis around. I will probably work on this last, but I hope to get around to it, yeah. That way we can remove monodis and the burden of maintaining it, instead of just adding to the maintenance burden. Jb: As I wrote in my earlier mail, there's a lot of code that can be lifted from: Thanks, I've seen that and I am referring to it. My goal of being character-for-character the same as monodis means that I'm not using your existing code as is. ildasm should be in mcs/tools, ilasm is in mcs just for historical reasons. Also I don't think we should require python for the tests, a simple Makefile should be enough. Thanks, I've moved it to tools, and I've rewritten by tests in Make. Marek: Another drawback is that it's very easy to crash/SIGSEGV monodis with broken metadata/MSIL. If the new version could be made more robust that would be great too. Hopefully it will be. When I get around to it, I could get hold of some broken files and perhaps implement some kind of error recovery logic, but that's for the future. Regards, Chris Seaton ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] monodis implemented with Cecil
Hello, I have named it ildasm to match the managed ilasm. The new name also means that it can live alongside monodis for the time being. Monodis has a major drawback, its dependency on picking up the right mscorlib.dll to work, your effort will fix that problem and get rid of one of the most annoying things of monodis. Another drawback is that it's very easy to crash/SIGSEGV monodis with broken metadata/MSIL. If the new version could be made more robust that would be great too. Marek ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] monodis implemented with Cecil
Can I advertise the work that I have started towards the reimplementation of monodis using Cecil. The fork is at https://github.com/chrisseaton/mono/ with the code found in mcs/ildasm. If anyone has the time I would appreciate an early code review to check that it will fit into mono and could be merged in the future. I'm still not sure about the build and test systems so that might require some attention in the future. So far it implements the monodis command line interface and disassembles a simple hello world with the same output as monodis, so it isn't much more than a proof of concept but it's coming along very quickly and should be all done in a few weeks hopefully. I am writing it as a simple reimplementation of monodis. It has the same command line interface and the output is the same as monodis, character for character. This means that it can be dropped into place when finished and should not affect anyone's systems. It also enables me to test it very effectively by using diff to compare the output of ildasm to monodis. I have named it ildasm to match the managed ilasm. The new name also means that it can live alongside monodis for the time being. Regards, Chris Seaton ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] monodis implemented with Cecil
Hello Chris, I have named it ildasm to match the managed ilasm. The new name also means that it can live alongside monodis for the time being. This is wonderful! Monodis has a major drawback, its dependency on picking up the right mscorlib.dll to work, your effort will fix that problem and get rid of one of the most annoying things of monodis. Are you also planning on adding the table dumping features? They are not necessary if we keep monodis around. Miguel ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] monodis implemented with Cecil
Hi Chris, On Wed, Apr 6, 2011 at 1:29 AM, Chris Seaton ch...@chrisseaton.com wrote: If anyone has the time I would appreciate an early code review to check that it will fit into mono and could be merged in the future. As I wrote in my earlier mail, there's a lot of code that can be lifted from: https://github.com/mono/cecil/tree/master/ildasm This code probably needs only a bit of cleanup and a port to the updated Cecil API. I'm still not sure about the build and test systems so that might require some attention in the future. ildasm should be in mcs/tools, ilasm is in mcs just for historical reasons. Also I don't think we should require python for the tests, a simple Makefile should be enough. Jb ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
