Re: [Mono-devel-list] patch for nunit support for xmlconf
Andrew Skiba wrote: Hello. Please review the applied patch, if noone objects, I will apply it tomorrow. You need more explanation. No one would understand what add nunit support exactly does. If it is kind of thing that reports failure in case of fixed bugs (saying remove A,B,C from list), it will be soon easily set as [Ignore] (of course am writing it only with imagination because there is no description). (Also note that you are saying I gave you full Sunday for patch review which is kinda zero day attack :-S) Atsushi Eno ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: spam: suspected: Re: [Mono-devel-list] patch for nunit support for xmlconf
Andrew Skiba wrote: Atsushi Eno wrote: (Also note that you are saying I gave you full Sunday for patch review which is kinda zero day attack :-S) Can't stop laughing. Zero day attack sounds good. What if I posted changes on your works on Thursday evening for you, while I know you guys have off days on Friday and Saturday? I know you understood that representation as a joke (and that certainly is), but the entire talk is not a joke. I thought, I have your permission to commit to the W3C directory without review. And then, I did not say I will commit tomorrow morning, so tomorrow people will have time to review. Note that your evening would be still Monday afternoon for Boston people (with somewhat insane timezone). If you didn't need any comments, then you could just commit things. But since you didn't do that, then what you asked is all readers' comments. I'm just a reader here, without mentioning any kind of permission and I think your way of answering is weird. No? You need more explanation. No one would understand what add nunit support exactly does. It does exactly that - nunit support. You can see in the makefile there is a new target - run-nunit-test. This target runs nunit-console with this testsuite, and the results are stored in TestResults.xml and TestResults.log I made some trick to make minimal changes in existing code. Instead of running test from nunit, I kept the existing code that runs the test. Later instead of reporting results, it remembers them by creating PredefinedTest object with already known outcome of the test, and when nunit calls Run, it makes Success or Failure according to the result already stored in _res field. I thought the code is self-explaining, but if it's not so, I will explain more. You should notice there are many possible interpretations than you have in mind. People cannot identify whether nunit support means: - if it is integrated into make run-test in the containing directory (i.e. in mcs/class/System.XML). - if it is to generate a TestFixture class which contains Test case methods. - if it reports failure on you should remove fixed bugs from list cases (I mentioned above), since when it is standalone tests it dictates us to do that. Not all of readers would read the entire patch. They will first check ChangeLog (and/or the post itself) and see if it is significant for themselves or not. If that is not understandable, then they will ask what it means. That's what I did. See how Rafi answered to the question, which clarifies things. Atsushi Eno ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: spam: suspected: Re: [Mono-devel-list] patch for nunit support for xmlconf
Atsushi Eno wrote:
If you didn't need any comments, then you could just commit things.
But since you didn't do that, then what you asked is all readers'
comments. I'm just a reader here, without mentioning any kind of
permission and I think your way of answering is weird. No?
Of course, I wanted comments, that's why I sent the patch to the list. I
just was afraid it will not have too much response. The next time I will
post it during the Boston working week.
- if it is integrated into make run-test in the
containing directory (i.e. in mcs/class/System.XML).
No, it's not integrated. Now I understand, what confused in my message.
- if it is to generate a TestFixture class which contains
Test case methods.
Impossible to make. w3c opens different files but the code that opens is
the same. If I'd write regular TestFixture class, it would look like:
[TestFixture]
class C {
[Test]
public void f1 () {
doc.Load(1.xml);
}
[Test]
public void f2 () {
doc.Load(2.xml);
}
And so on, 3000 testcases.
- if it reports failure on you should remove fixed bugs
from list cases (I mentioned above), since when it
is standalone tests it dictates us to do that.
Sorry, I did not understand what do you mean here. How is it related to
nunit?
Not all of readers would read the entire patch. They will first
check ChangeLog (and/or the post itself) and see if it is
significant for themselves or not. If that is not understandable,
then they will ask what it means. That's what I did.
That's OK, but I did not understand question in your first mail.
See how Rafi answered to the question, which clarifies things.
Yes, Rafi gave good reference.
Andrew.
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
