Re: [Mono-dev] PATCH SiteMapNode

[Chris Toshok]

This patch isn't necessary.  comparison works just fine in the face of
null values.

Chris

On Tue, 2006-04-11 at 02:51 -0700, Andrew Skiba wrote:
 Use properties instead of fields to protect from null values. If no one
 objects, I will commit.
 
 
 Index: SiteMapNode.cs
 ===
 --- SiteMapNode.cs(revision 59261)
 +++ SiteMapNode.cs(working copy)
 @@ -249,10 +249,10 @@
   SiteMapNode node = ob as SiteMapNode;
   if (node == null) return false;
   
 - if (node.key != key ||
 - node.url != url ||
 - node.title != title ||
 - node.description != description)
 {
 + if (node.Key != Key ||
 + node.Url != Url ||
 + node.Title != Title ||
 + node.Description != Description)
 {
   return false;
   }
   
 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

RE: [Mono-dev] PATCH SiteMapNode

[Andrew Skiba]

 You are right. Sorry for the inconvenience.

 This patch isn't necessary.  comparison works just fine in 
 the face of null values.
 
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list