Re: [Mono-docs-list] Re: [Mono-devel-list] patch for bug#57748
Joshua, give you get a chance to look at this yet? - raf On Sat, 2005-06-11 at 14:21 -0700, Rafael Ferreira wrote: On Sat, 2005-06-11 at 07:25 -0400, Joshua Tauberer wrote: Rafael Ferreira wrote: This patch fixes bug#57748 by giving the docbrowser its AssemblyInfo back and by changing the About dialog to display the extra information. Hi, Rafael. You should post monodoc-related patches to mono-docs-list. I broke up the About dialog into a 4 tab notebook/treeview (about/authors/plugins/version). Not bad. Thanks! AboutDialog.cs: string[] plugins = {ECMA Documentation,Mono XML Documentation, Mono Handbook, Manual Pages, Compiler Errors,ECMA C# Specification }; The providers are all compiled into monodoc 'statically', so the user has no control over it. I don't think we need to list them. Would you like to remove the plugins tab completely or just have a label instead of the list? AssemblyInfo.cs.in: [assembly:AssemblyVersion(@DOCBROWSER_VERSION@)] [assembly:AssemblyDelaySign(true)] Thanks! Nice. configure.in: +DOCBROWSER_VERSION=1.0 Yeah, I should have noted that I put a placeholder there. Miguel needs to chime in with how he would want monodoc to be versioned. Also, it would be nice to display the monodoc version more prominently, instead of just in the list of loaded assemblies. I changed the interface so the docbrowser version shows up in the about tab as well, check it out and tell me what you think: http://ophion.org/~rafael/static/about3.png docbrowser/browser.cs: - RootTree.UncompiledHelpSources.Add(args[i+1]); + //RootTree.UncompiledHelpSources.Add(args[i+1]); Please don't disable my features. :) Oops, I forgot I did that. That line is giving me some compilation problems: ./browser.cs(79) error CS0117: `Monodoc.RootTree' does not contain a definition for `UncompiledHelpSources' Do you want me to just leaved it commented for now? -class Browser { +public class Browser { Why this? Fixed. +/* class About { You can just delete that class and any Glade stuff it has, if any. -class Tab : Notebook { +public class Tab : Notebook { Again, I don't think this was necessary. Fixed. Thanks for working on updating the about dialog. Can you fix the issues I noted, add a ChangeLog, and then repost the patch on mono-docs-list? Let me know what you want to do about the plugins tab and I'll send you a new patch with all the fixes. Take care, - raf ___ Mono-docs-list maillist - Mono-docs-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-docs-list ___ Mono-docs-list maillist - Mono-docs-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-docs-list
Re: [Mono-docs-list] Re: [Mono-devel-list] patch for bug#57748
Heh, okay, okay, here we go... Rafael Ferreira wrote: Would you like to remove the plugins tab completely or just have a label instead of the list? My preference would be to remove it alltogether. I changed the interface so the docbrowser version shows up in the about tab as well, check it out and tell me what you think: Nice. Oops, I forgot I did that. That line is giving me some compilation problems: You just need to 'make install' the latest monodoc.dll from /monodoc/browser. -- - Joshua Tauberer http://taubz.for.net ** Nothing Unreal Exists ** ___ Mono-docs-list maillist - Mono-docs-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-docs-list
[Mono-docs-list] Re: [Mono-devel-list] patch for bug#57748
On Sat, 2005-06-11 at 07:25 -0400, Joshua Tauberer wrote: Rafael Ferreira wrote: This patch fixes bug#57748 by giving the docbrowser its AssemblyInfo back and by changing the About dialog to display the extra information. Hi, Rafael. You should post monodoc-related patches to mono-docs-list. I broke up the About dialog into a 4 tab notebook/treeview (about/authors/plugins/version). Not bad. Thanks! AboutDialog.cs: string[] plugins = {ECMA Documentation,Mono XML Documentation, Mono Handbook, Manual Pages, Compiler Errors,ECMA C# Specification }; The providers are all compiled into monodoc 'statically', so the user has no control over it. I don't think we need to list them. Would you like to remove the plugins tab completely or just have a label instead of the list? AssemblyInfo.cs.in: [assembly:AssemblyVersion(@DOCBROWSER_VERSION@)] [assembly:AssemblyDelaySign(true)] Thanks! Nice. configure.in: +DOCBROWSER_VERSION=1.0 Yeah, I should have noted that I put a placeholder there. Miguel needs to chime in with how he would want monodoc to be versioned. Also, it would be nice to display the monodoc version more prominently, instead of just in the list of loaded assemblies. I changed the interface so the docbrowser version shows up in the about tab as well, check it out and tell me what you think: http://ophion.org/~rafael/static/about3.png docbrowser/browser.cs: - RootTree.UncompiledHelpSources.Add(args[i+1]); + //RootTree.UncompiledHelpSources.Add(args[i+1]); Please don't disable my features. :) Oops, I forgot I did that. That line is giving me some compilation problems: ./browser.cs(79) error CS0117: `Monodoc.RootTree' does not contain a definition for `UncompiledHelpSources' Do you want me to just leaved it commented for now? -class Browser { +public class Browser { Why this? Fixed. +/* class About { You can just delete that class and any Glade stuff it has, if any. -class Tab : Notebook { +public class Tab : Notebook { Again, I don't think this was necessary. Fixed. Thanks for working on updating the about dialog. Can you fix the issues I noted, add a ChangeLog, and then repost the patch on mono-docs-list? Let me know what you want to do about the plugins tab and I'll send you a new patch with all the fixes. Take care, - raf ___ Mono-docs-list maillist - Mono-docs-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-docs-list