Re: [Monotone-devel] Making vocab-from-string constructors explicit?
On 1/25/07, Timothy Brownawell <[EMAIL PROTECTED]> wrote: The purpose of our vocab system is to provide some amount of type safety. This is somewhat defeated by having the vocab-from-string constructors not be explicit, there are a number of places that simply use () to allow use of a variable with a type that doesn't match. I'd like to make the constructors for this explicit, to make this practice slightly more annoying to do and much easier to recognize (both for whover writes it, and anyone who looks at it later). Does anyone have (good) reasons not to do this? I think it'd help us keep the code clean. I tried to do this once before. I found some real, if probably harmless, bugs doing it (things being converted to types they honestly weren't) and I think it's a great idea, but I gotta warn you that the fallout will be immense. I gave up on it just because it was too much work. zw ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
[Monotone-devel] Making vocab-from-string constructors explicit?
The purpose of our vocab system is to provide some amount of type safety. This is somewhat defeated by having the vocab-from-string constructors not be explicit, there are a number of places that simply use () to allow use of a variable with a type that doesn't match. I'd like to make the constructors for this explicit, to make this practice slightly more annoying to do and much easier to recognize (both for whover writes it, and anyone who looks at it later). Does anyone have (good) reasons not to do this? I think it'd help us keep the code clean. -- Timothy Free (experimental) public monotone hosting: http://mtn-host.prjek.net ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
Re: [Monotone-devel] Unnamed directory in a changeset
"Julio M. Merino Vidal" <[EMAIL PROTECTED]> wrote: > Notice the 'add_dir ""' line in the reported changeset. This seems > to be harmless, but is incorrect. This is the root directory of the first revision. It's there "on purpose". Someone can chime in with more specific details. -- Chad Walstrom <[EMAIL PROTECTED]> http://www.wookimus.net/ assert(expired(knowledge)); /* core dump */ ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
Re: [Monotone-devel] Unnamed directory in a changeset
In message <[EMAIL PROTECTED]> on Thu, 25 Jan 2007 17:49:53 +0100, "Julio M. Merino Vidal" <[EMAIL PROTECTED]> said: jmmv84> For some reason, monotone is adding an unnamed directory to my jmmv84> changeset. I have hit this several times already (with 0.31 jmmv84> and 0.32, IIRC, but possibly earlier versions too). This is by design, and only happens with the initial add to a new project. That "unnamed" directory is the top level directory of your project tree. Why it exists exactly? Uhmm, I'm not savvy with regards to the reasons, but I imagine it's so the top-level files can be attached to *something*. Nothing to worry about, it's normal. Maybe we should make it more apparent in some outputs, though... Cheers, Richard - Please consider sponsoring my work on free software. See http://www.free.lp.se/sponsoring.html for details. -- Richard Levitte [EMAIL PROTECTED] http://richard.levitte.org/ "When I became a man I put away childish things, including the fear of childishness and the desire to be very grown up." -- C.S. Lewis ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
[Monotone-devel] Unnamed directory in a changeset
Hi, For some reason, monotone is adding an unnamed directory to my changeset. I have hit this several times already (with 0.31 and 0.32, IIRC, but possibly earlier versions too). This goes as such: mkdir foo mkdir foo/doc touch foo/doc/a mtn --db=foo.mtn db init mtn --db=foo.mtn --branch=my.branch setup foo cd foo mtn add -R doc mtn diff Notice the 'add_dir ""' line in the reported changeset. This seems to be harmless, but is incorrect. In fact, it seems to be recorded in the database when you do a commit so it might not be as harmless as I think. When doing a 'mtn log': Added files: doc/a doc/b Added directories: doc Notice the extra single space before 'doc'. That shouldn't be here, but it is because of the unnamed directory being in the database (I guess). Any idea about what's going on here? A known bug? Happens equally under OS X with 0.32 on HFS+ and under Fedora with 0.31 and ext3 (so it is not an issue with case unsensitivity). Thanks. -- Julio M. Merino Vidal <[EMAIL PROTECTED]> ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
[Monotone-devel] Monotone update lost deletions
I cleaned up this branch quite some time ago. After upgrading the database, it's complaining that files that were removed are missing. What further information can I give? ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
Re: [Monotone-devel] 'mtn add' output on stderr
In message <[EMAIL PROTECTED]> on Thu, 25 Jan 2007 14:45:53 +0100, Tim Kettler <[EMAIL PROTECTED]> said: tim.kettler> is it by intention that the output of 'mtn add ...' goes tim.kettler> to stderr instead of stdout? If so, what is the reason tim.kettler> for that. You mean the status messages such as this? mtn: adding bar to workspace manifest Uhmm, I dunno, it makes perfect sense to me to have such messages go to stderr. It's like error messages and warning messages, except these are purely informational. In any case, I'd prefer to keep ot that way. Cheers, Richard - Please consider sponsoring my work on free software. See http://www.free.lp.se/sponsoring.html for details. -- Richard Levitte [EMAIL PROTECTED] http://richard.levitte.org/ "When I became a man I put away childish things, including the fear of childishness and the desire to be very grown up." -- C.S. Lewis ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
[Monotone-devel] 'mtn add' output on stderr
Hi, is it by intention that the output of 'mtn add ...' goes to stderr instead of stdout? If so, what is the reason for that. Or should I file a bug? This is with 0.32. -Tim ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel