Re: [Monotone-devel] Monotone tests failing under Debian automated building

2012-04-24 Thread Markus Wanner
Francis,

On 04/24/2012 05:04 PM, Francis Russell wrote:
> I don't think this is a requirement though, looking at RFC3986, "+" is a
> reserved character, protected from percent encoding and "therefore safe
> to be used by scheme-specific and producer-specific algorithms for
> delimiting data subcomponents within a URI."

Safe for *delimiting* data subcomponents. I don't think the plus sign is
allowed in the subcomponent of a path itself.

> So, + only needs to be
> percent encoded if it otherwise has a special meaning in the file://
> scheme. Since + doesn't I don't believe it needs to appear in an escaped
> form.

Yes, plus encodes a whitespace. That's why you didn't get a decoding
error, but monotone tried to load the file "/tmp/mtn 2.db".

Regards

Markus Wanner

___
Monotone-devel mailing list
Monotone-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/monotone-devel


[Monotone-devel] time for a release?

2012-04-24 Thread Markus Wanner
Hi,

quite a few fixes went in since monotone 1.0, including the recent fix
for compatibility with Botan 1.10 (which got released in June 2011). So
I'm thinking it's about time for a release.

How much time do we need to be able to release? Any pending items
somebody absolutely wants to get in?

Regards

Markus Wanner


___
Monotone-devel mailing list
Monotone-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/monotone-devel


Re: [Monotone-devel] [Monotone-debian] Monotone tests failing under Debian automated building

2012-04-24 Thread Markus Wanner
Package: monotone
Version: 1.0-4
Tags: patch

Hi,

On 04/24/2012 04:04 PM, Francis Russell wrote:
> Ha, I've found it! monotone appears to be rewriting pluses to spaces in
> its URLs:

Yeah, monotone expects a correctly escaped URL as argument for the clone
and netsync commands. But the test suite didn't expect parent paths that
require escaping so far.

I committed a fix upstream [1]. The corresponding patch is attached.

Regards

Markus Wanner

[1] rev a0ed177b60caee5cf304c01d83e75812af1225e1, see
https://code.monotone.ca/p/monotone/source/commit/a0ed177b60caee5cf304c01d83e75812af1225e1/


mtn-testsuite-fix.diff.gz
Description: GNU Zip compressed data
___
Monotone-devel mailing list
Monotone-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/monotone-devel


Re: [Monotone-devel] Monotone tests failing under Debian automated building

2012-04-24 Thread Francis Russell

On 24.04.2012 15:29, Ludovic Brenta wrote:


The plus sign must be percent-encoded as %2B in the URI:

mtn pull -d mtn.db "file:///tmp/mtn%2B2.db?*"


I don't think this is a requirement though, looking at RFC3986, "+" is 
a reserved character, protected from percent encoding and "therefore 
safe to be used by scheme-specific and producer-specific algorithms for 
delimiting data subcomponents within a URI." So, + only needs to be 
percent encoded if it otherwise has a special meaning in the file:// 
scheme. Since + doesn't I don't believe it needs to appear in an escaped 
form.


Francis

___
Monotone-devel mailing list
Monotone-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/monotone-devel


Re: [Monotone-devel] Monotone tests failing under Debian automated building

2012-04-24 Thread Ludovic Brenta

On Tue, 24 Apr 2012 15:04:13 +0100, Francis Russell wrote:
To me, it looks like monotone is copying test databases to a 
specific
location for a test, then apparently finding the files missing. I 
can't

replicate this in a Debian unstable chroot, nor can I imagine in the
automated build environment could cause the tests to fail in this 
way.


Ha, I've found it! monotone appears to be rewriting pluses to spaces
in its URLs:

Simple example:

$ cd /tmp/
$ mtn db init -d mtn.db
$ mtn db init -d mtn+2.db
$ mtn pull -d mtn.db "file:///tmp/mtn+2.db?*"
mtn: doing anonymous pull; use -kKEYNAME if you need authentication
mtn: connecting to 'file:/tmp/mtn 2.db'
mtn:   include pattern  '*'
mtn:   exclude pattern  ''
mtn: misuse: database '/tmp/mtn 2.db' does not exist


The plus sign must be percent-encoded as %2B in the URI:

mtn pull -d mtn.db "file:///tmp/mtn%2B2.db?*"

--
Ludovic Brenta.


___
Monotone-devel mailing list
Monotone-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/monotone-devel


Re: [Monotone-devel] Monotone tests failing under Debian automated building

2012-04-24 Thread Francis Russell

To me, it looks like monotone is copying test databases to a specific
location for a test, then apparently finding the files missing. I 
can't

replicate this in a Debian unstable chroot, nor can I imagine in the
automated build environment could cause the tests to fail in this 
way.


Ha, I've found it! monotone appears to be rewriting pluses to spaces in 
its URLs:


Simple example:

$ cd /tmp/
$ mtn db init -d mtn.db
$ mtn db init -d mtn+2.db
$ mtn pull -d mtn.db "file:///tmp/mtn+2.db?*"
mtn: doing anonymous pull; use -kKEYNAME if you need authentication
mtn: connecting to 'file:/tmp/mtn 2.db'
mtn:   include pattern  '*'
mtn:   exclude pattern  ''
mtn: misuse: database '/tmp/mtn 2.db' does not exist
mtn: peer file:/tmp/mtn 2.db IO terminated connection in working state 
(error)
mtn: error: I/O failure while talking to peer 'file:/tmp/mtn 2.db', 
disconnecting

$

Francis


___
Monotone-devel mailing list
Monotone-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/monotone-devel


[Monotone-devel] Monotone tests failing under Debian automated building

2012-04-24 Thread Francis Russell
Monotone packages are currently failing to build under Debian's
auto-build system, but the reason has me confused so I thought I'd ask
the main dev list. It looks like monotone itself is building fine, but a
number of the tests are failing.

A full log of a recent build can be found here:

https://buildd.debian.org/status/fetch.php?pkg=monotone&arch=i386&ver=1.0-4%2Bb1&stamp=1335032594

To me, it looks like monotone is copying test databases to a specific
location for a test, then apparently finding the files missing. I can't
replicate this in a Debian unstable chroot, nor can I imagine in the
automated build environment could cause the tests to fail in this way.

Any ideas?

Francis


___
Monotone-devel mailing list
Monotone-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/monotone-devel