Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello fredvs, you wrote on Wed, 18 Mar 2020 03:44:08 -0700 (MST): > > But most probabely they were preexisting, I presume? > > Yes, they were produced maybe by a build process but that build process is > not part of mse (imho). > > > (or compare them with tha originals, or just > > dump them and _use_ the originals), > > Yes, I did tests before to choose what to commit. > And, yes, applying the patch on image-files makes some images corrupted. > > So, imho, the safer is just to paste the original images after the patch. > It is what was done. Alright then. Tous en ordre. -- -- (Weitergabe von Adressdaten, Telefonnummern u.ä. ohne Zustimmung nicht gestattet, ebenso Zusendung von Werbung oder ähnlichem) --- Mit freundlichen Grüßen, S. Schicktanz --- ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
> But most probabely they were preexisting, I presume? Yes, they were produced maybe by a build process but that build process is not part of mse (imho). > (or compare them with tha originals, or just > dump them and _use_ the originals), Yes, I did tests before to choose what to commit. And, yes, applying the patch on image-files makes some images corrupted. So, imho, the safer is just to paste the original images after the patch. It is what was done. Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello fredvs, you wrote on Mon, 16 Mar 2020 14:45:09 -0700 (MST): > > Wouldn't it be simpler to just rebuild all binaries > > Not sure to understand. > There is no applications-binaries or libraries-binary in mseide-msegui > source. > All the binaries are about images files, like bmp, png, jpeg, ... Ok, I didn't know what kind of binaries you meant. I thought of object files or programs produced by the build process. > Rebuild the images? If the images weren't preexisting, i.e. they were produced by the build process, then, yes. But most probabely they were preexisting, I presume? Then you just can check them (or compare them with tha originals, or just dump them and _use_ the originals), as, yes, the command may also "adversely affect" an image file as well. But they're easily inspected, after all. -- -- (Weitergabe von Adressdaten, Telefonnummern u.ä. ohne Zustimmung nicht gestattet, ebenso Zusendung von Werbung oder ähnlichem) --- Mit freundlichen Grüßen, S. Schicktanz --- ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
> Wouldn't it be simpler to just rebuild all binaries Not sure to understand. There is no applications-binaries or libraries-binary in mseide-msegui source. All the binaries are about images files, like bmp, png, jpeg, ... Rebuild the images? -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello fredvs, you wrote on Sun, 15 Mar 2020 16:28:19 -0700 (MST): > > If you are COMPLETELY SURE that NOT A SINGLE FILE of them all is a > > binary > > No, I am not completely sure. > > It is the reason why, before to apply the patch, I did copy the > directories containing binaries and git files in safe place. > (Imho, only images and git files are concerned). > > Then apply the patch for all files. > (Of course, the patch could use a filters in place of "-name '*.*'", but > more complicated). > > When all files are patched, replace the binary directories and git files > with the original one. Hopefully you'll get them all. Wouldn't it be simpler to just rebuild all binaries (except, of course, preexising ones) after performing the truncation action? This might even unveil some damage that may have been done to preexisting binaries that have to be replaced then. Just a suggestion - you should do it your way, as you see fit. -- -- (Weitergabe von Adressdaten, Telefonnummern u.ä. ohne Zustimmung nicht gestattet, ebenso Zusendung von Werbung oder ähnlichem) --- Mit freundlichen Grüßen, S. Schicktanz --- ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
> If you are COMPLETELY SURE that NOT A SINGLE FILE of them all is a binary No, I am not completely sure. It is the reason why, before to apply the patch, I did copy the directories containing binaries and git files in safe place. (Imho, only images and git files are concerned). Then apply the patch for all files. (Of course, the patch could use a filters in place of "-name '*.*'", but more complicated). When all files are patched, replace the binary directories and git files with the original one. Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello fredvs,
you wrote on Sun, 15 Mar 2020 13:45:54 -0700 (MST):
> > OK, done in 2 last commits.
> > I hope I did not a disaster.
Hope you always can...
> I did use that command (after done a copy of .git and images files):
>
> $ find . -type f -name '*.*' -exec sed --in-place 's/[[:space:]]\+$//' {}
> \+ ^^^
If you are COMPLETELY SURE that NOT A SINGLE FILE of them all is a binary
file or even a runnable program, then you might consider this safe.
In any other case you _will_ have wreaked havoc on those binaries, as
there's always a chance that the sed command may have corrupted some.
> After that command, I did paste the original copied .git and images files.
That's probably a wise decision; so in the case when some binary was
corrupted, there's still the possibility to retrieve the original unscarred
version.
With text files, that's safe, but might be irritated if a mixture of line
endings (Linux - LF / Windows - CR/LF) occurs. Then it might not find all
trailing space and so not remove some.
Just to mention it.
--
--
(Weitergabe von Adressdaten, Telefonnummern u.ä. ohne Zustimmung
nicht gestattet, ebenso Zusendung von Werbung oder ähnlichem)
---
Mit freundlichen Grüßen, S. Schicktanz
---
___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
> OK, done in 2 last commits.
> I hope I did not a disaster.
I did use that command (after done a copy of .git and images files):
$ find . -type f -name '*.*' -exec sed --in-place 's/[[:space:]]\+$//' {} \+
After that command, I did paste the original copied .git and images files.
Fre;D
--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/
___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
OK, done in 2 last commits. I hope I did not a disaster. Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
> You are green to go! :-) Aargh, it does not work this time. OK. (but asap). Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
On 13/03/2020 12:59 pm, fredvs wrote: > Anyway, I will use the magic words (that works very well with Graeme): hahahaha I'm on to you now. ;-) > "Graeme, if you want, I will do it asap." You are green to go! :-) Regards, Graeme ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
On 12/03/2020 5:59 pm, fredvs wrote: > Mse has **many** units, doing this via a editor will takes ages... Thare are plent of command line tools that can do it too. Some programmer text editors are process all files in directories recursively too. Google is your friend. ;-) Regards, Graeme -- fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/ My public PGP key: http://tinyurl.com/graeme-pgp ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello Sieghard. > Do you use Windows (a manualizing tool) or Linux (an automating tool)? I use Linux. > "sed -i 's/[[:blank:]]*$//' " Thanks for the tip! Maybe Graeme is already busy with it. Anyway, I will use the magic words (that works very well with Graeme): "Graeme, if you want, I will do it asap." ;-) Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello fredvs,
you wrote on Thu, 12 Mar 2020 10:59:15 -0700 (MST):
> > I suggest,if you want, apply it to ALL the source code in the repo and
> > make one
> > commit that says trimming the whitespace. Done and dusted! ;-)
Should be done urgently. I also hate trailing invisible stuff.
> Ho, yes, it would be wonderful.
>
> But...
>
> Mse has **many** units, doing this via a editor will takes ages...
Do you use Windows (a manualizing tool) or Linux (an automating tool)?
If the latter, "sed" ist the tool of choice. You can use "find" to retrieve
all unit files in all subdirectories of the mse code tree, feed them to sed
and have that remove all the trailing whitespace in all files by issuing a
single, albeit complex, command.
The "sed" call might look somewhat like so:
"sed -i 's/[[:blank:]]*$//' "
where the "-i" tells sed to apply the expression within quotes "in place"
to the file, thus modifying it, the expression in single quotes is the
editing command that removes white space at the end of any line (blanks
and tabs) and the specifies the file to modify. If used in
conjunction with find, the characters "{}" have to be used as the , as that's the marker telling "find" where to insert the names of
the files it found.
There are ways to achieve that with Windows as well, as there are
implementations of "sed" and even "find" for Windows also.
--
--
(Weitergabe von Adressdaten, Telefonnummern u.ä. ohne Zustimmung
nicht gestattet, ebenso Zusendung von Werbung oder ähnlichem)
---
Mit freundlichen Grüßen, S. Schicktanz
---
___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
> I suggest,if you want, apply it to ALL the source code in the repo and make one > commit that says trimming the whitespace. Done and dusted! ;-) Ho, yes, it would be wonderful. But... Mse has **many** units, doing this via a editor will takes ages... Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
On 12/03/2020 5:39 pm, fredvs wrote: > Yes, my fault, now I see that it was absolutely not a good idea. Martin once told me too, to revert my contributions because I enabled "trim trailing whitespace". :-) The MSEide+MSEgui code is full of such trailing whitespace. I suggest, if you want, apply it to ALL the source code in the repo and make one commit that says trimming the whitespace. Done and dusted! ;-) After that, all will be good. No point in having contributions "polluted" by such whitespace noise. Regards, Graeme -- fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/ My public PGP key: http://tinyurl.com/graeme-pgp ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello Graeme. > change a editor setting (eg: trim trailing whitespace)? Yes, my fault, now I see that it was absolutely not a good idea. Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] Space and empty lines removed in commits.
On 12/03/2020 10:26 am, fredvs wrote: > Maybe Graeme could refresh my mind? Use the 'git diff' with the following parameters -b (ignores changes in amount of whitespace) -w (ignores all whitespace) But I would be thinging to myself, why did Git complain about those in the first place. Did you run a code formatter over the code? Did you change a editor setting (eg: trim trailing whitespace)? Regards, Graeme -- fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/ My public PGP key: http://tinyurl.com/graeme-pgp ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
[MSEide-MSEgui-talk] Space and empty lines removed in commits.
Hello. When I check my last commits, doing a "diff", shows also all the spaces end empty lines removed. That makes the read of the change much more complicated, I would prefer that only the change in code was show. I know that there is a option in Git to ignore the change done for space and empty lines. Sadly, I do not remember what was that git command. Maybe Graeme could refresh my mind? Thanks. Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
