Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection
Graeme Geldenhuys wrote > On 07/03/2021 12:58 pm, fredvs wrote: >> Nice (but you are mse-org member so no need to request, just push it). > > I forgot I have read/write access. I've pushed my changes. > > Regards, > Graeme Thanks! Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection
On 07/03/2021 12:58 pm, fredvs wrote: > Nice (but you are mse-org member so no need to request, just push it). > > By the way, I did commit your code for ideU. I forgot I have read/write access. I've pushed my changes. Regards, Graeme -- fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/ My public PGP key: http://tinyurl.com/graeme-pgp ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection
Graeme Geldenhuys wrote > I'll make the remaining changes today and created a pull request for code > review. Hello Graeme. Nice (but you are mse-org member so no need to request, just push it). By the way, I did commit your code for ideU. Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection
On 07/03/2021 2:20 am, fredvs wrote: > But if doing this, imho, tactionsmo.enablecomment has no sense anymore and > should be commented. My initial thoughts was not to change existing behaviour, but you are 100% correct. That action doesn't make sense any more - in fact I did not even know that right-click popup menu or the action existed. I'll make the remaining changes today and created a pull request for code review. Regards, Graeme -- fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/ My public PGP key: http://tinyurl.com/graeme-pgp ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
Re: [MSEide-MSEgui-talk] [PATCH 1/1] editor - allow to comment line without selection
Hello Graeme. Indeed, much better. But if doing this, imho, tactionsmo.enablecomment has no sense anymore and should be commented. Otherwise if you use the right-click to show the properties-list, "comment" will be disabled if nothing was selected. procedure tactionsmo.enablecomment(const sender: tcustomaction); begin // enableonselect(sender); // sender.enabled:= sender.enabled and sourcefo.activepage.cancomment(); end; Fre;D -- Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/ ___ mseide-msegui-talk mailing list mseide-msegui-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk
