Re: [Musicpd-dev-team] [PATCH] Add support for DSD-over-USB version 1.0, remove pre-v1 support

2012-04-02 Thread Max Kellermann
On 2012/04/01 11:10, Jurgen Kramer gtmkra...@xs4all.nl wrote:
 Hi,
 
 Attached patch adds support for DSD-over-USB version 1.0 and removes
 support for the old pre-v1 standard. Patch is against current git.

Please update the URLs to the official documentation.

--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


[Musicpd-dev-team] [PATCH] update: properly skip symlinks in path that is to be updated.

2012-04-02 Thread Anton Khirnov
---
 src/update_walk.c |6 +-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/update_walk.c b/src/update_walk.c
index 003807d..bb2f247 100644
--- a/src/update_walk.c
+++ b/src/update_walk.c
@@ -676,6 +676,9 @@ directory_make_child_checked(struct directory *parent, 
const char *name_utf8)
inodeFoundInParent(parent, st.st_ino, st.st_dev))
return NULL;
 
+if (skip_symlink(parent, name_utf8))
+   return NULL;
+
/* if we're adding directory paths, make sure to delete filenames
   with potentially the same name */
db_lock();
@@ -728,7 +731,8 @@ updatePath(const char *path)
 
name = g_path_get_basename(path);
 
-   if (stat_directory_child(parent, name, st) == 0)
+   if (!skip_symlink(parent, name) 
+   stat_directory_child(parent, name, st) == 0)
updateInDirectory(parent, name, st);
else
modified |= delete_name_in(parent, name);
-- 
1.7.9.1


--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


[Musicpd-dev-team] Current mpd-git DSD playback problems/slowdown - possible clues

2012-04-02 Thread Jurgen Kramer
Hi,

As a follow up on my previous mails regarding the slowdown issue with
DSD-over-USB. With the current mpd-git code DSD-over-USB the connected
device won't lock into DSD mode. I found out it is not receiving enough
data per time period.

In MPD clients this is visible in that it takes mpd 4 seconds to play 1
second of music data. This is regardless of using ALSA hw:x,x or
plughw so no relation to the needed shifting for 32-bit output. 

After much digging around I managed to get sound working but the timing
issue remained. When the value for SAMPLE_FORMAT_DSD is changed from 1
to 4 (src/audio_format.h) I get proper sound when playing DSD-over-USB.
This ratio of 1 to 4 makes sense but unfortunately is not the (complete)
solution. For example with SAMPLE_FORMAT_DSD set to 4, DSD2PCM still
works fine but now it's timing is off.

@Max, hopefully you can make sense of this and find a solution. And
hopefully you'll get a DSD-over-USB compatible device soon so you can
reproduce the issue.

Jurgen


--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


[Musicpd-dev-team] [PATCH] Add support for DSD-over-USB version 1.0, remove pre-v1 support - updated docs

2012-04-02 Thread Jurgen Kramer
Hi,

Attached patch updates the documentation. Modified the links to the
documentation of the DSD-over-USB standard version 1.1. 
JR will make the link live later today.

---
 doc/user.xml  |4 ++--
 src/pcm_dsd_usb.h |5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/user.xml b/doc/user.xml
index 6c0547f..cd36528 100644
--- a/doc/user.xml
+++ b/doc/user.xml
@@ -1127,8 +1127,8 @@ systemctl start mpd.socket/programlisting
 entry
   If set to parameteryes/parameter, then DSD over
   USB according to the ulink
-  url=http://www.dcsltd.co.uk/page/assets/DSDoverUSB.pdf;dCS
-  suggested standard/ulink is enabled.  This wrapsa
+  url=http://www.sonore.us/DoP_openStandard_1v1.pdf;pro
+  posed standard by dCS and others/ulink is enabled.  This wraps
   DSD samples in fake 24 bit PCM, and is understood by
   some DSD capable products, but may be harmful to
   other hardware.  Therefore, the default is
diff --git a/src/pcm_dsd_usb.h b/src/pcm_dsd_usb.h
index 3e7ad8f..3893584 100644
--- a/src/pcm_dsd_usb.h
+++ b/src/pcm_dsd_usb.h
@@ -30,8 +30,9 @@ struct pcm_buffer;
 
 /**
  * Pack DSD 1 bit samples into (padded) 24 bit PCM samples for
- * playback over USB, according to the dCS suggested standard:
- * http://www.dcsltd.co.uk/page/assets/DSDoverUSB.pdf
+ * playback over USB, according to the proposed standard by 
+ * dCS and others:
+ * http://www.sonore.us/DoP_openStandard_1v1.pdf
  */
 const uint32_t *
 pcm_dsd_to_usb(struct pcm_buffer *buffer, unsigned channels,
-- 
1.7.6.5

--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team