On Thu, 2012-08-09 at 18:29 +0200, Max Kellermann wrote: > On 2012/08/09 18:04, Jurgen Kramer <gtmkra...@xs4all.nl> wrote: > > Excerpt: > > In file included from src/input/ffmpeg_input_plugin.c:26:0: > > /usr/include/ffmpeg/libavformat/avformat.h:158:1: error: ???AVMetadata??? is > > deprecated (declared at /usr/include/ffmpeg/libavutil/dict.h:41) > > [-Werror=deprecated-declarations] > > Hm, bad ffmpeg headers. Which version do you use? I have libav > 0.8.3, works fine. OK, I have 0.7.13, I'll probably have to upgrade my system...
> > New attempt: > > http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=65c0690891d5312180140bb32c284d973a9fc58e > > I suggest disabling all of the id3 code when there's no libid3tag, to > reduce overhead. For example, the attribute id3_offset should not > exist. OK, will do that. I'll revert this commit. > The function dsdlib_tag_id3() looks like duplicate code. Better use > the scan_id3_tag() function from tag_id3.c. This function is not > exported currently. This avoids code duplication, avoids > duplicate memory allocation for the temporary tag object, supports all > tags, and supports multiple tag values. No problem, I'll look into using scan_id3_tag(). I guess I will have to export it? Jurgen ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
