2010/1/2 Max Kellermann m...@duempel.org:
On 2010/01/02 05:11, Jon Heier snakeb...@jvnv.net wrote:
Hi, I tried the latest git version to test out the new cuesheet
support. I've attached two patches which fixes some issues I
encountered.
The first one fixes a segfault which occured when reading an invalid
cuesheet.
Is it actually legal for track_get_filename() to return NULL? I'd
consider this a libcue bug, because it doesn't make sense for a track
to not have a data file, does it?
I have a few cuesheets pointing to flac files which uses FLAC instead
of WAVE after the filename (got them fixed now). libcue threw some
error messages at me about invalid characters and a syntax error when
I tried to load these. cue_parse_file() doesn't seem to return NULL
when this happens, so the error checking in cue_playlist_open_uri()
fails to detect the error.
The second one fixes an issue where I could not play the last track
in the cuesheet, by setting the correct end_ms and track time.
This patch assumes that track_get_filename() always returns non-NULL
and will crash when it really gets NULL.
If applied after the first patch, filename shouldn't be NULL here.
Fixing the above problem should solve this anyway.
Jochen, the function track_get_filename() isn't documented - can you
please enlighten us?
Max
--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
