Re: [Musicpd-dev-team] ffmpeg input/decoder patch for http and aacp
Just some extra ignores for eclipse-style projects. You can exclude if you wish, but I thought they were harmless. Do you all just use plain text editors for primary development of mpd? If you use an IDE which one do you use? Thanks -Sven Max Kellermann wrote: On 2012/12/21 13:07, Sven sven.carlb...@gmail.com wrote: Hi folks - this is essentially two 1-line patches. And what about these? diff --git a/.gitignore b/.gitignore index 67b2610..b630452 100644 --- a/.gitignore +++ b/.gitignore @@ -67,3 +67,6 @@ test/run_ntp_server test/run_resolver test/run_tcp_connect test/test_pcm +.cproject +.project +.settings diff --git a/src/input/ffmpeg_input_plugin.c b/src/input/ffmpeg_input_plugin.c index 6d339a0..398c093 100644 --- a/src/input/ffmpeg_input_plugin.c +++ b/src/input/ffmpeg_input_plugin.c @@ -82,6 +82,7 @@ input_ffmpeg_open(const char *uri, struct input_ffmpeg *i; if (!g_str_has_prefix(uri, gopher://;) +!g_str_has_prefix(uri, http://;) !g_str_has_prefix(uri, rtp://) !g_str_has_prefix(uri, rtsp://) !g_str_has_prefix(uri, rtmp://) -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] ffmpeg input/decoder patch for http and aacp
On 2012/12/21 13:17, sven sven.carlb...@gmail.com wrote: Just some extra ignores for eclipse-style projects. You can exclude if you wish, but I thought they were harmless. May be harmless, and may be reasonable to add, but not in a patch that is described as add audio/aacp as an available mime-type to the ffmpeg decoder. Similar goes for the HTTP thing: if you think it is necessary to add that, you may suggest to do it and tell why, but not sneak it in in an unrelated patch. -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] ffmpeg input/decoder patch for http and aacp
Sorry not trying to be sneaky here, just trying to help. Max Kellermann wrote: On 2012/12/21 13:17, sven sven.carlb...@gmail.com wrote: Just some extra ignores for eclipse-style projects. You can exclude if you wish, but I thought they were harmless. May be harmless, and may be reasonable to add, but not in a patch that is described as add audio/aacp as an available mime-type to the ffmpeg decoder. Similar goes for the HTTP thing: if you think it is necessary to add that, you may suggest to do it and tell why, but not sneak it in in an unrelated patch. -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
