Crash after failed [C]opy

[Steffen Nurpmeso]

Hello,

i don't dare to try the bugtracker anymore, so posting here.
For comparison purposes only, tried

  [C] -> maildir:/tmp/x.maildir

and got asked whether creation is desired, i said yes, and then:

  maildir:/tmp/x.maildir: No such file or directory (errno = 2)Segmentation 
fault (core dumped)
  ?139[steffen@wales tmp]$

Ciao.

--steffen

Re: Crash after failed [C]opy

[Steffen Nurpmeso]

i wrote:
 |i don't dare to try the bugtracker anymore, so posting here.
 |For comparison purposes only, tried
 |
 |  [C] -> maildir:/tmp/x.maildir
 |
 |and got asked whether creation is desired, i said yes, and then:
 |
 |  maildir:/tmp/x.maildir: No such file or directory (errno = 2)Segmentation \
 |  fault (core dumped)
 |  ?139[steffen@wales tmp]$
 |
 |Ciao.

Forgot to say this was on (almost up-to-date) ArchLinux:

  ?130[steffen@wales tmp]$ pacman -Si mutt
  Repository  : extra
  Name: mutt
  Version : 1.8.2-2
  Description : Small but very powerful text-based mail client
  Architecture: x86_64
  URL : http://www.mutt.org/
  ...
  Depends On  : gpgme  ncurses  openssl  libsasl  gdbm  libidn  mime-types  
krb5
  ...
  Download Size   : 1335.51 KiB
  Installed Size  : 7229.00 KiB
  ...
  Build Date  : Wed 19 Apr 2017 10:36:51 AM CEST

Ciao.

--steffen

[Mutt] #3936: Compiler warnings on macOS 10.12.4

[Mutt]

#3936: Compiler warnings on macOS 10.12.4
+--
 Reporter:  chdiza  |  Owner:  mutt-dev
 Type:  defect  | Status:  new
 Priority:  major   |  Milestone:
Component:  build   |Version:
 Keywords:  |
+--
 When building mutt from hg tip on macOS 10.12.4 and Xcode 8.3.2, I see
 these two compiler warnings fly by.  (Everything builds fine, though.)

 {{{
 gcc -DPKGDATADIR=\"/usr/local/share/mutt\" -DSYSCONFDIR=\"/usr/local/etc\"
 -DBINDIR=\"/usr/local/bin\" -DMUTTLOCALEDIR=\"/usr/local/share/locale\"
 -DHAVE_CONFIG_H=1 -I.  -I. -I. -I./imap  -Iintl -I/usr/local/ssl/include
 -I./intl  -Wall -pedantic -Wno-long-long -g -O2 -MT getdomain.o -MD -MP
 -MF .deps/getdomain.Tpo -c -o getdomain.o getdomain.c
 init.c:944:12: warning: unused function 'parse_path_list' [-Wunused-
 function]
 static int parse_path_list (BUFFER *buf, BUFFER *s, unsigned long data,
 ...
^
 init.c:960:12: warning: unused function 'parse_path_unlist' [-Wunused-
 function]
 static int parse_path_unlist (BUFFER *buf, BUFFER *s, unsigned long
 data...
^
 }}}

--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3936: Compiler warnings on macOS 10.12.4

[Mutt]

#3936: Compiler warnings on macOS 10.12.4
-+--
  Reporter:  chdiza  |  Owner:  mutt-dev
  Type:  defect  | Status:  new
  Priority:  major   |  Milestone:
 Component:  build   |Version:
Resolution:  |   Keywords:
-+--

Comment (by kevin8t8):

 Yes, when it's built without the sidebar, those two functions are not
 used.
 The two functions are not "sidebar specific" though, so I'm not inclined
 to put #ifdefs around them.

 I'll try to see if there is some other way to squelsh the warnings.

--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: Crash after failed [C]opy

[Kevin J. McCarthy]

On Fri, Apr 28, 2017 at 02:47:38PM +0200, Steffen Nurpmeso wrote:
>  |For comparison purposes only, tried
>  |
>  |  [C] -> maildir:/tmp/x.maildir
>  |
>  |and got asked whether creation is desired, i said yes, and then:
>  |
>  |  maildir:/tmp/x.maildir: No such file or directory (errno = 2)Segmentation 
> \
>  |  fault (core dumped)
>  |  ?139[steffen@wales tmp]$

I haven't been able to duplicate the segv yet, so I have a few questions
I'm hoping will help me track it down.

What is your value of $mbox_type just before you attempt the copy?
   :set ?mbox_type

What type of mailbox are you copying from (imap, mbox, maildir, mh)?

Would you include the full output of 'mutt -v'?

Thank you!

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA


signature.asc
Description: PGP signature

Re: Crash after failed [C]opy

[Moritz Barsnick]

On Fri, Apr 28, 2017 at 11:25:28 -0700, Kevin J. McCarthy wrote:
> I haven't been able to duplicate the segv yet, so I have a few questions
> I'm hoping will help me track it down.

I can reproduce with my patched 1.8.0, but not with 1.8.2, patched or
vanilla.

I have mbox_type=mbox, and I can reproduce on 1.8.0 with the blink of
an eye. Here's the backtrace:

maildir:/tmp/keks: No such file or directory (errno = 2)
Program received signal SIGSEGV, Segmentation fault.
0x00704f71 in fileno_unlocked () from /lib/libc.so.6
Missing separate debuginfos, use: debuginfo-install 
bzip2-libs-1.0.6-1.fc10.1sunshine.pentium4 cyrus-sasl-lib-2.1.22-19.fc10.i386 
e2fsprogs-libs-1.41.4-6.fc10.i386 glibc-2.9-3.2sunshine.i686 
gnutls-2.4.2-5.fc10.i386 keyutils-libs-1.2-3.fc9.i386 
krb5-libs-1.6.3-18.fc10.i386 libgcrypt-1.4.4-1.fc10.i386 
libgpg-error-1.6-2.i386 libidn-0.6.14-8.i386 libselinux-2.0.78-1.fc10.i386 
libtasn1-1.5-1.fc10.i386 ncurses-libs-5.6-20.20080927.fc10.i386 
tokyocabinet-1.3.27-1.fc10.i386 zlib-1.2.3-22.fc10.1sunshine.pentium4
(gdb) bt
#0  0x00704f71 in fileno_unlocked () from /lib/libc.so.6
#1  0x08089702 in mbox_close_mailbox (ctx=0xbfffd9b8) at mbox.c:470
#2  0x08093f31 in mx_fastclose_mailbox (ctx=0xbfffd9b8) at mx.c:704
#3  0x08094571 in mx_open_mailbox (path=0xbfffda98 "maildir:/tmp/keks", 
flags=, pctx=0xbfffd9b8) at mx.c:620
#4  0x0805c10b in mutt_save_message (h=0x8331e68, delete=0, decode=0, 
decrypt=0, redraw=0x833207c) at commands.c:846
#5  0x08067f1e in mutt_index_menu () at curs_main.c:1787
#6  0x08088fad in main (argc=2, argv=0xb5d4, environ=0xb5e0) at 
main.c:1304

(Copying from an mbox.)

I don't know why a mutt from hg tip would crash, "for me" it seems
fixed. (No, I haven't had the time to try vanilla 1.8.0. Enough
correlating for now. ;-))

Moritz

Warnings from pgp.c

[Moritz Barsnick]

Hi,
I just checked my build of pgp.c:

gcc -std=gnu99  -Wall -pedantic -Wno-long-long -g -O2   -o pgpring pgppubring.o 
pgplib.o lib.o extlib.o sha1.o md5.o pgppacket.o ascii.o
pgp.c: In function ‘pgp_decrypt_mime’:
pgp.c:1010: warning: ‘saved_length’ may be used uninitialized in this function
pgp.c:1009: warning: ‘saved_offset’ may be used uninitialized in this function
pgp.c:1008: warning: ‘saved_type’ may be used uninitialized in this function

I think gcc (4.3.2) may actually be right.

Just wondering,
Moritz

Re: Crash after failed [C]opy

[Kevin J. McCarthy]

On Fri, Apr 28, 2017 at 09:37:11PM +0200, Moritz Barsnick wrote:
> On Fri, Apr 28, 2017 at 11:25:28 -0700, Kevin J. McCarthy wrote:
> > I haven't been able to duplicate the segv yet, so I have a few questions
> > I'm hoping will help me track it down.
> 
> I can reproduce with my patched 1.8.0, but not with 1.8.2, patched or
> vanilla.

Yes, that crash was something I fixed for 1.8.1:
https://dev.mutt.org/hg/mutt/rev/e3e47b2f1370

But Steffen reported running 1.8.2.  I'm hoping he was perhaps mistaken.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA


signature.asc
Description: PGP signature

Re: Warnings from pgp.c

[Kevin J. McCarthy]

On Fri, Apr 28, 2017 at 09:43:23PM +0200, Moritz Barsnick wrote:
> Hi,
> I just checked my build of pgp.c:
> 
> gcc -std=gnu99  -Wall -pedantic -Wno-long-long -g -O2   -o pgpring 
> pgppubring.o pgplib.o lib.o extlib.o sha1.o md5.o pgppacket.o ascii.o
> pgp.c: In function ‘pgp_decrypt_mime’:
> pgp.c:1010: warning: ‘saved_length’ may be used uninitialized in this function
> pgp.c:1009: warning: ‘saved_offset’ may be used uninitialized in this function
> pgp.c:1008: warning: ‘saved_type’ may be used uninitialized in this function
> 
> I think gcc (4.3.2) may actually be right.

Thank you for the report.

In this case, the values are safe.  They are initialized if need_decode
is set, and are subsequently read only under the same condition
(need_decode being set).

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA


signature.asc
Description: PGP signature

Re: Crash after failed [C]opy

[Steffen Nurpmeso]

Good evening,

"Kevin J. McCarthy"  wrote:
 |On Fri, Apr 28, 2017 at 02:47:38PM +0200, Steffen Nurpmeso wrote:
 |>|For comparison purposes only, tried
 |>|
 |>|  [C] -> maildir:/tmp/x.maildir
 |>|
 |>|and got asked whether creation is desired, i said yes, and then:
 |>|
 |>|  maildir:/tmp/x.maildir: No such file or directory (errno = 2)Segmentatio\
 |>|  n \
 |>|  fault (core dumped)
 |>|  ?139[steffen@wales tmp]$
 |
 |I haven't been able to duplicate the segv yet, so I have a few questions
 |I'm hoping will help me track it down.
 |
 |What is your value of $mbox_type just before you attempt the copy?
 |:set ?mbox_type

  mbox_type=mbox

 |
 |What type of mailbox are you copying from (imap, mbox, maildir, mh)?

mbox.

  Copy to mailbox: maildir:/tmp/hi.mbox

Then "yes" for create and

  maildir:/tmp/hi.mbox: No such file or directory (errno = 2)Segmentation fault 
(core dumped)

 |Would you include the full output of 'mutt -v'?

Attached.

Eh, but, wait, please.  I see now this is indeed 1.8.0 (pacman
reports 1.8.2 but installed is still 1.8.0)!  If this has been
fixed in between, as the other two mails imply, then i am really
sorry for the noise.  I haven't updated this VM since about two
weeks because ArchLinux has switched to OpenSSL 1.1.0, and i was
near download limit, and that resets on the 22nd each month, and,
pfff, last Saturday i have found no time.  Please just ignore
this, then.  If after the update and reboot i can still reproduce
this (when you cannot today), then i would report this, ok?
Sorry.

--steffen

Re: Crash after failed [C]opy

[Steffen Nurpmeso]

"Kevin J. McCarthy"  wrote:
 |On Fri, Apr 28, 2017 at 09:37:11PM +0200, Moritz Barsnick wrote:
 |> On Fri, Apr 28, 2017 at 11:25:28 -0700, Kevin J. McCarthy wrote:
 |>> I haven't been able to duplicate the segv yet, so I have a few questions
 |>> I'm hoping will help me track it down.
 |> 
 |> I can reproduce with my patched 1.8.0, but not with 1.8.2, patched or
 |> vanilla.
 |
 |Yes, that crash was something I fixed for 1.8.1:
 |https://dev.mutt.org/hg/mutt/rev/e3e47b2f1370
 |
 |But Steffen reported running 1.8.2.  I'm hoping he was perhaps mistaken.

Yes, pacman said 1.8.2, but mutt -v actually says 1.8.0.
Sorry again.

--steffen

Re: Crash after failed [C]opy

[Steffen Nurpmeso]

Moritz Barsnick  wrote:

 |I don't know why a mutt from hg tip would crash, "for me" it seems
 |fixed. (No, I haven't had the time to try vanilla 1.8.0. Enough
 |correlating for now. ;-))

Yaah, i am very sorry.  No i don't have Mercurial no more at all:

  ?0[steffen@wales tmp]$ (cd /home/steffen/code.arena/mutt.tar_bomb_git;
  git loca)
  * db70827 (tag: refs/tags/v1.8.0, refs/heads/master) Import v1.8.0, 2017-02-24
  * d39448b (tag: refs/tags/v1.7.0) Import v1.7.0, 2016-08-18
  * ec22a9a (tag: refs/tags/v1.6.2) Import v1.6.2, 2016-08-03
  * 29d1cde (tag: refs/tags/v1.6.0) Import v1.6.0, 2016-04-19
  * 290e129 (tag: refs/tags/v1.5.24) Import v1.5.24, 2015-09-02
  * 419d57e (tag: refs/tags/v1.5.23) Import v1.5.23, 2015-02-24
  * a5cf704 (tag: refs/tags/v1.5.22) Import v1.5.22, 2015-02-24
  * 42282b5 (HEAD -> refs/heads/arena-manager-null) NULL

But since my main machine died i really use binary updates for
almost anything but the very small things, e.g., TinyCC.  E.g.,
i cannot even git garbage collect the groff repo because of memory
constraints in the VM i work in, i need to raise the limit and
restart for that, and then the rest of the system is unusable.
I really need to buy a Librem or still Zenbook, finally, and then
i can use CRUX-Linux more often again, juhu.  And such...
Sorry for the noise, then.

--steffen

Re: [Mutt] #3936: Compiler warnings on macOS 10.12.4

[Mutt]

#3936: Compiler warnings on macOS 10.12.4
-+--
  Reporter:  chdiza  |  Owner:  mutt-dev
  Type:  defect  | Status:  new
  Priority:  major   |  Milestone:
 Component:  build   |Version:
Resolution:  |   Keywords:
-+--

Comment (by derekmartin):

 You can remove the static keyword.  Or disable -Wunused-function, possibly
 for only that file if you want to be clever. All the other ways I can
 think of will just generate other warnings that need to be squelched.

--
Ticket URL: 
Mutt 
The Mutt mail user agent