Re: trash folder in 1.5.18

2008-08-19 Thread Christian Brabandt
Hi David!

On Tue, 19 Aug 2008, David Champion wrote:

   http://cedricduval.free.fr/mutt/patches/#trash  is only upto the
   mutt version 1.5.5.1; there are no patches after that. I am guessing
   that it has been included in the original code.
  
   It has not been.
 
 Cedric hasn't updated it AFAIK, but a google
 on cedric duval trash patch turns up
 http://scie.nti.st/2007/6/21/mutt-trash-folder-patch-for-1-5-16 . Maybe
 that version will apply more cleanly to 1.5.18.

You could also get the source code from Debian, which includes the 
trash-folder patch. They have a version for 1.5.18

regards,
Christian
-- 
When the Universe was not so out of whack as it is today, and all the
stars were lined up in their proper places, you could easily count them
from left to right, or top to bottom, and the larger and bluer ones were
set apart, and the smaller yellowing types pushed off to the corners as
bodies of a lower grade ...
-- Stanislaw Lem, Cyberiad


Re: trash folder in 1.5.18

2008-08-18 Thread P Kapat
Hi,

On 8/17/08, Kyle Wheeler [EMAIL PROTECTED] wrote:

 On Saturday, August 16 at 06:25 PM, quoth P Kapat:
 The trash folder patch from
 http://cedricduval.free.fr/mutt/patches/#trash  is only upto the
 mutt version 1.5.5.1; there are no patches after that. I am guessing
 that it has been included in the original code.

 It has not been.

OK.

 I have used the trash folder option in 1.5.17 (the binary version
 included with Ubuntu Hardy). Any help?

 That old patch will *probably* work. You can at least try it.

I tried to patch the already patched (with sidebar) code with the trash.folder 
patch. It was not entirely clean (output given below). Nevertheless the 
configure and make process didn't give any error and I am able to use the set 
trash= option now! Is it okay to live with these errors? BTW, I tried to apply 
this patch before applying the sidebar patch and the errors were similar.

Thanks again.

PATCH OUTPUT:

$ patch -p1  patch-1.5.5.1.cd.trash_folder.3.4
patching file commands.c
Hunk #1 FAILED at 663.
1 out of 1 hunk FAILED -- saving rejects to file commands.c.rej
patching file flags.c
Hunk #1 FAILED at 65.
Hunk #2 succeeded at 96 (offset 6 lines).
1 out of 2 hunks FAILED -- saving rejects to file flags.c.rej
patching file globals.h
Hunk #1 succeeded at 144 (offset 34 lines).
patching file imap/message.c
Hunk #1 succeeded at 816 (offset 192 lines).
patching file init.h
Hunk #1 succeeded at 2966 (offset 407 lines).
patching file mutt.h
Hunk #1 succeeded at 201 (offset 4 lines).
Hunk #2 succeeded at 709 with fuzz 1 (offset 72 lines).
Hunk #3 succeeded at 814 with fuzz 1 (offset 48 lines).
patching file muttlib.c
Hunk #1 FAILED at 1181.
1 out of 1 hunk FAILED -- saving rejects to file muttlib.c.rej
patching file mx.c
Hunk #1 succeeded at 818 (offset 3 lines).
Hunk #2 succeeded at 997 (offset -4 lines).
Hunk #3 succeeded at 1026 (offset 3 lines).
Hunk #4 succeeded at 1221 (offset -2 lines).
patching file postpone.c
Hunk #1 succeeded at 279 (offset 4 lines).
patching file PATCHES


-- 
Regards
PK
--
http://counter.li.org  #402424


Re: trash folder in 1.5.18

2008-08-18 Thread Kyle Wheeler
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Monday, August 18 at 06:33 PM, quoth P Kapat:
 I tried to patch the already patched (with sidebar) code with the 
 trash.folder patch. It was not entirely clean (output given below).

Uy. Unfortunately, those FAILED lines probably mean that you need to 
reconcile the patch with those files by hand in order to make it work 
*correctly*.

 Nevertheless the configure and make process didn't give any error 
 and I am able to use the set trash= option now! Is it okay to live 
 with these errors? BTW, I tried to apply this patch before applying 
 the sidebar patch and the errors were similar.

If it works for you, cool; unfortunately, I suspect that even though 
it compiled without errors, it doesn't actually do all the right 
things. Having code that compiles without errors is akin to saying 
that your essay has no spelling errors: it's important, but it doesn't 
guarantee that whats in there makes any sense.

If you're not much of a C programmer, you can try applying the two 
patches in reverse order (i.e. apply the trash patch first, and the 
sidebar patch second), or you can try asking the author of the trash 
patch to fix it for you.

~Kyle
- -- 
The purpose of computing is insight, not numbers.
  -- Richard W. Hamming
-BEGIN PGP SIGNATURE-
Comment: Thank you for using encryption!

iEYEARECAAYFAkip/tkACgkQBkIOoMqOI14KwQCePA+v71xixeZkwQG9/+NfqjeB
efgAoLVeHDEly+TC9tc4qjGiDiGsElCQ
=CxBv
-END PGP SIGNATURE-


Re: trash folder in 1.5.18

2008-08-18 Thread P Kapat
Hi,

On 8/18/08, Kyle Wheeler [EMAIL PROTECTED] wrote:

 Uy. Unfortunately, those FAILED lines probably mean that you need to
 reconcile the patch with those files by hand in order to make it work
 *correctly*.

Ah, that is the tricky part. Though I can read the syntax of the
source code and the patch, but not knowing the utility of the
statements, it will be impossible to patch them correctly.

 If you're not much of a C programmer, you can try applying the two
 patches in reverse order (i.e. apply the trash patch first, and the
 sidebar patch second), or you can try asking the author of the trash
 patch to fix it for you.

I'll try to contact the author and see. Thanks the nonetheless!

-- 
Regards
PK
--
http://counter.li.org  #402424


Re: trash folder in 1.5.18

2008-08-18 Thread David Champion
  http://cedricduval.free.fr/mutt/patches/#trash  is only upto the
  mutt version 1.5.5.1; there are no patches after that. I am guessing
  that it has been included in the original code.
 
  It has not been.

Cedric hasn't updated it AFAIK, but a google
on cedric duval trash patch turns up
http://scie.nti.st/2007/6/21/mutt-trash-folder-patch-for-1-5-16 . Maybe
that version will apply more cleanly to 1.5.18.

-- 
 -D.[EMAIL PROTECTED]NSITUniversity of Chicago


Re: trash folder in 1.5.18

2008-08-17 Thread Kyle Wheeler
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Saturday, August 16 at 06:25 PM, quoth P Kapat:
 The trash folder patch from 
 http://cedricduval.free.fr/mutt/patches/#trash  is only upto the 
 mutt version 1.5.5.1; there are no patches after that. I am guessing 
 that it has been included in the original code.

It has not been.

 I have used the trash folder option in 1.5.17 (the binary version 
 included with Ubuntu Hardy). Any help?

That old patch will *probably* work. You can at least try it.

~Kyle
- -- 
Make no little plans. They have no magic to stir men's blood.
  -- Daniel Burnham
-BEGIN PGP SIGNATURE-
Comment: Thank you for using encryption!

iEYEARECAAYFAkioXqYACgkQBkIOoMqOI16fZwCg40vECCenG595AVYNNDejyU5R
LUgAoM5rrq76QpQ6RUpvwrqK+MWMde3n
=WEx6
-END PGP SIGNATURE-


trash folder in 1.5.18

2008-08-16 Thread P Kapat
Hi,

I recently compiled the 1.5.18 version on a RedHat EL5 machine with
the sidebar patch from here:
http://www.lunar-linux.org/index.php?option=com_contenttask=viewid=44

I used the following to configure:
./configure --prefix=$HOME/usr/local --enable-pop --enable-imap
--enable-smtp --enable-locales-fix --enable-nfs-fix --with-ssl
--with-sasl --enable-hcache

But I am not able to use the trash folder option:
set trash=..
I get the following error: trash: unknown variable

The trash folder patch from
http://cedricduval.free.fr/mutt/patches/#trash  is only upto the mutt
version 1.5.5.1; there are no patches after that. I am guessing that
it has been included in the original code. I have used the trash
folder option in 1.5.17 (the binary version included with Ubuntu
Hardy). Any help?

-- 
Regards
PK
--
http://counter.li.org #402424