RE: [nant-dev] Mail task
I'm always in favor of more fileset support, so you have my vote! -Original Message- From: Gert Driesen [mailto:[EMAIL PROTECTED] Sent: Saturday, August 30, 2003 3:23 PM To: Nant-Developers (E-Mail) Subject: [nant-dev] Mail task Hi, Currently the mail task allows files that should be included as text in the body, and attachments to be specified as a comma- or semicolon-separated list. Shouldn't we replaces this by fileset support ? I know that would indeed break backward compatibility, but in this case I think it wouldn't cause that much problems ... What do you think ? Gert --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] solution task assemblyfolders
Hi all! I implement that assemblyfolder subtag for solution as we discused it here. I hope my coding convention is ok (try to be close to yours). I'm also totally confused by security checks. Have you any experience with enabling read from registry? [it is ok for me without it, but...] There will be some other matters regarding project dependencies and paths but I need to explore it first. Regards, Martin a.patch Description: Binary data
Re: [nant-dev] solution task assemblyfolders
Hi all!
That's a very good idea, however just by looking at your patch I see few
problems:
1. When you have both VS.NET 2002 and VS.NET 2003 you actually have more
registry keys to consider:
HKEY_LOCAL_MACHINE\Software\Microsoft\VisualStudio\7.0\AssemblyFolders
HKEY_CURRENT_USER\Software\Microsoft\VisualStudio\7.0\AssemblyFolders
HKEY_LOCAL_MACHINE\Software\Microsoft\VisualStudio\7.1\AssemblyFolders
HKEY_CURRENT_USER\Software\Microsoft\VisualStudio\7.1\AssemblyFolders
where as a rule CURRENT_USER settings override the local machine. I think
that the registry paths should be stored a part of the framework
configuration in NAnt.exe.config. For mono on linux you would simply have no
paths to examine.
2. Looks like there's a mistake in your code:
+FileSet af = _solutionTask.AssemblyFolders;
+if(af.DirectoryNames.Count==0)
af=_solutionTask.DefaultAssemlyFolders;
+
+foreach(string path in
_solutionTask.AssemblyFolders.DirectoryNames)
+{
+fiRef = new FileInfo(Path.Combine(path,justFilename));
+if ( fiRef.Exists )
+{
+_referenceFile = fiRef.FullName;
+_baseDirectory = fiRef.DirectoryName;
+return;
+}
+}
You initialize local variable af to some fileset but iterate over
_solutionTask.AssemblyFolders.DirectoryNames so obviously af is not
used. I think it was meant to be foreach(string path in af.DirectoryNames)
3. I think there should be an option to include/exclude
DefaultAssemblyFolders from processing. In your patch there's a line:
+if(af.DirectoryNames.Count==0)
af=_solutionTask.DefaultAssemlyFolders;
I think that the semantics should be: process all directories specified in
the fileset PLUS any directories found via DefaultAssemblyFolders when the
user asks for it
You would have a syntax like this.
solution includevsfolders=true
/solution
I think that this new option should default to false. Having it otherwise
would be dangerous as it would by default introduce a dependency of the
registry and might produce inconsistent results on different build machines.
Overall: the direction is good, but your patch still needs some work,
Martin. You're very close, though.
Jarek
- Original Message -
From: Martin Aliger [EMAIL PROTECTED]
To: ! nant [EMAIL PROTECTED]
Sent: Monday, September 01, 2003 5:04 PM
Subject: [nant-dev] solution task assemblyfolders
Hi all!
I implement that assemblyfolder subtag for solution as we discused it
here. I hope my coding convention is ok (try to be close to yours). I'm
also
totally confused by security checks. Have you any experience with enabling
read from registry? [it is ok for me without it, but...]
There will be some other matters regarding project dependencies and paths
but I need to explore it first.
Regards,
Martin
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] last suggestion - Solution task again
Good find. I like your assembly-folders idea. Unfortunately, I'm quite
busy at work and don't have any time for solution task development.
It should be pretty straight-forward to implement if someone has an hour
or so to space.
I could code it - no problem. Does others see any other ideas?
Also I'm not quite sure about naming. is assembly-folders proper name for
that tag? And how to internally implement it? As list of paths? Fileset is
not appropriate here. Maybe I could handle it simmilary as arg in csc?
(only list tag I'm aware of)
Martin
Martin Aliger wrote:
I did some exploration in this field and found this:
Visual Studio use HintPath to find reference assemblies. If not found it
uses all paths listed under registry key
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\VisualStudio\7.1\AssemblyFolders
Maybe we should implement similar mechanism? Use HintPath first and then
some path list which could defaults to this regisry read. And be
overrided
(extended?) by e.g.
solution _verbose=true configuration=Release
output=${build.dir}
projects
includes name=**/*.csproj/
/projects
assembly-folders
includes name=c:\temp\build\dll/
/assembly-folders
/solution
Martin
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
