[nant-dev] [ nant-Bugs-1195320 ] solution task does not recompile resources
Bugs item #1195320, was opened at 2005-05-04 17:27 Message generated for change (Comment added) made by drieseng You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1195320group_id=31650 Category: Tasks Group: 0.85 Status: Closed Resolution: Fixed Priority: 5 Submitted By: David (dob80) Assigned to: Gert Driesen (drieseng) Summary: solution task does not recompile resources Initial Comment: If a project's resource script contains imported files then the solution task doesn't recompile the resources if the imported files are updated. Attached is an example. The resource script of the NantResourceTest project (in the NantResourceTest solution) imports the file description.xml. If description.xml is altered (for example try updating the version element) and the solution built (using NantResourceTest.build) the target exe is not relinked. -- Comment By: Gert Driesen (drieseng) Date: 2005-05-05 09:30 Message: Logged In: YES user_id=707851 This is now fixed in cvs. Thanks for the report and the repro ! -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1195320group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1188492 ] Very slow builds of the solutions with many projects
Bugs item #1188492, was opened at 2005-04-23 09:21 Message generated for change (Comment added) made by drieseng You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1188492group_id=31650 Category: Tasks Group: 0.85 Status: Closed Resolution: Fixed Priority: 5 Submitted By: dminikitin (dminikitin) Assigned to: Gert Driesen (drieseng) Summary: Very slow builds of the solutions with many projects Initial Comment: With Nant 0.85rc2 it takes unacceptably long to build solutions with large number of projects and high rate of dependencies between projects. For example, a solution with 60 projects (C#) took ~60 minutes to build in Nant, whereas in dev studio it takes ~60 seconds. The problem was traced to the way Nant builds the list of output files for the solution [GetOutputFiles() method and related methods). Nant uses recursive algorithm where for each project it determines its references, for each reference it determins its references and so on. The problem is that recursion termination wasn't implemented correctly for the cases when the reference has already been processed. Attached is the zip archive with fixes. All files are from NAnt.VSNet directory. The fixes implement recursion termination for the already processed references and change the method singnatures from public Hashtable GetOutputFiles (string configuration) to public void GetOutputFiles (string configuration, Hashtable outputFiles). The latter fix is to avoid unnecessary creation/destruction of hashtables. -- Comment By: Gert Driesen (drieseng) Date: 2005-05-05 10:17 Message: Logged In: YES user_id=707851 This is now committed in cvs. Thanks !! -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1188492group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1186146 ] solution C++ link omits /INCLUDE:
Bugs item #1186146, was opened at 2005-04-19 19:42 Message generated for change (Comment added) made by drieseng You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1186146group_id=31650 Category: Tasks Group: None Status: Open Resolution: None Priority: 5 Submitted By: Mach005 (mach005) Assigned to: Nobody/Anonymous (nobody) Summary: solution C++ link omits /INCLUDE: Initial Comment: The solution task, C++ link sub-task, omits the /INCLUDE: command line argument for link, which should be specified for the VS.NET 2003 project setting: Linker-Input-Force Symbol References. e.g. link /INCLUDE:[EMAIL PROTECTED] This most typically results in linker warning: LNK4210 __section__ section exists; there may be unhandled static initializers or terminators This is required because the /GS compiler option requires CRT startup code (static initializers or terminators). -- Comment By: Gert Driesen (drieseng) Date: 2005-05-05 10:17 Message: Logged In: YES user_id=707851 Ping ! -- Comment By: Gert Driesen (drieseng) Date: 2005-04-19 20:21 Message: Logged In: YES user_id=707851 May I ask what version of NAnt you're using ? If I'm not mistaken, this issue was fixed recently (fix should be part of RC3). -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1186146group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] patch for FileSet extension
Hi Gary, as I implemented it, it converts scanned files from first fileset to full path asis includes. So fileset id=foo1 basedir=X:\nant\t1 include name=world.peace / include name=world.war/ /fileset fileset id=foo2 basedir=X:\nant\t1 includesfileset refid=foo1/ exclude name=world.war/ include name=reefer.saddness / /fileset becomes fileset id=foo2 basedir=X:\nant\t1 include asis=true name=X:\nant\t1\world.peace/ include asis=true name=X:\nant\t1\world.war/ exclude name=world.war/ include name=reefer.saddness / /fileset To your question with excludes: - all excludes in foo1 are respected. - no exclude in foo2 take effect on included files. Thats something which is already in place. Excludes do _not_ affect asis includes. It sounds a little strange to me, but I'd rather not change something what is in place for several years. Is this behaviour right? Maybe yes. I think about includesfileset like fileset merging operation - so you merge existing fileset with some include/exclude mask. But I see, there is no way how to filter out existing fileset to another one... So maybe its not right way? Ideas? Note: reason why I used asis is to prevent double-scan. asis includes are not scanned anymore, and all included files via includesfileset was scanned once already. Martin Aliger --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1187291 ] Property macro expansion does not happen for Element types
Bugs item #1187291, was opened at 2005-04-21 11:02
Message generated for change (Comment added) made by copsey
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=402868aid=1187291group_id=31650
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Copsey (copsey)
Assigned to: Nobody/Anonymous (nobody)
Summary: Property macro expansion does not happen for Element types
Initial Comment:
In element.cs, in the CreateChildBuildElement method,
the parameter properties is not used.
Property macro expansion does not happen. In my
build, I have created a custom task which takes a
filename as a parameter
blahfilename/blah
but when i use it with a property, its not expanded
blah${filename}/blah
(get ${filename} not found)
--
Comment By: Copsey (copsey)
Date: 2005-05-05 13:03
Message:
Logged In: YES
user_id=1263750
I've uploaded a test task .cs file [Test2Task.cs].
If you look at, say, this property
[BuildElement(size, Required=true)]
public TextElement Size{...}
When using this in an actual build, if I use a property instead
of a literal in the build file, it is not expanded (it is treated as
a literal).
I would expect it to be expanded (as is the case when I use a
TaskAttribute attribute on a property)
--
Comment By: Gert Driesen (drieseng)
Date: 2005-05-04 13:53
Message:
Logged In: YES
user_id=707851
Can you send me a repro and provide more information on
the behaviour you were expecting ?
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=402868aid=1187291group_id=31650
---
This SF.Net email is sponsored by: NEC IT Guy Games.
Get your fingers limbered up and give it your best shot. 4 great events, 4
opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
___
nant-developers mailing list
nant-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1192287 ] NAnt build core dumped on FreeBSD
Bugs item #1192287, was opened at 2005-04-29 11:09 Message generated for change (Comment added) made by philk You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1192287group_id=31650 Category: Core Group: 0.85 Status: Closed Resolution: None Priority: 7 Submitted By: Filip (philk) Assigned to: Nobody/Anonymous (nobody) Summary: NAnt build core dumped on FreeBSD Initial Comment: I'm not able to compile NAnt on FreeBSD. Each attempt fails with: System was remapped (http://www.go-mono.com/remap.html) Compat mode: the request from /usr/home/phil/opt/nant-0.85-nightly-2005-04-20/bootstrap/log4net.dll to load System.Data was remapped (http://www.go-mono.com/remap.html) Compat mode: the request from /usr/home/phil/opt/nant-0.85-nightly-2005-04-20/bootstrap/log4net.dll to load System.Web was remapped (http://www.go-mono.com/remap.html) NAnt 0.85 (Build 0.85.1936.0; nightly; 04/20/2005) Copyright (C) 2001-2005 Gerry Shaw http://nant.sourceforge.net gmake: *** [build-nant] Segmentation fault (core dumped) -- Comment By: Filip (philk) Date: 2005-05-05 16:26 Message: Logged In: YES user_id=245405 Thank you! works fine (nant-0.85-nightly-2005-05-05) -- Comment By: Gert Driesen (drieseng) Date: 2005-05-04 16:35 Message: Logged In: YES user_id=707851 This should be fixed in the next nightly build. -- Comment By: Filip (philk) Date: 2005-05-04 16:29 Message: Logged In: YES user_id=245405 sorry, Mono 1.1.6.10; thank for you help. -- Comment By: Filip (philk) Date: 2005-05-04 16:26 Message: Logged In: YES user_id=245405 The Mono 1.6.10 works fine but ... mono bootstrap/NAnt.exe -f:NAnt.build build The NAnt configuration file (/usr/home/phil/opt/nant-0.85-nightly-2005-04-20/bootstrap/NAnt.exe.config) does not have a framework node for the current runtime framework. Please add a framework node with family 'mono' and clrversion '2.0.50215' under the 'unix' platform node. -- Comment By: Filip (philk) Date: 2005-05-04 13:40 Message: Logged In: YES user_id=245405 It seems that you are right; bug was raised http://bugzilla.ximian.com/show_bug.cgi?id=74782 Thank you. -- Comment By: Gert Driesen (drieseng) Date: 2005-05-03 21:58 Message: Logged In: YES user_id=707851 I'm sorry if I cannot be more helpful, but this seems to be a Mono issue. Have you tried using a 1.1.x version of Mono ? -- Comment By: Filip (philk) Date: 2005-04-29 14:36 Message: Logged In: YES user_id=245405 epidem% uname -a FreeBSD epidem 5.4-STABLE FreeBSD 5.4-STABLE #28: Mon Apr 11 11:13:16 CEST 2005 [EMAIL PROTECTED]:/usr/obj/usr/src/sys/EPIDEM i386 epidem% mono --version Mono JIT compiler version 1.0.6, (C) 2002-2004 Novell, Inc and Contributors. www.go-mono.com TLS: normal GC:Included Boehm (with typed GC) SIGSEGV : normal Globalization: none -- Comment By: Filip (philk) Date: 2005-04-29 11:24 Message: Logged In: YES user_id=245405 I don't know what causes core dump but the bug is critical for me because I want use NAnt to build my new C# project. Thank you. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1192287group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1192287 ] NAnt build core dumped on FreeBSD
Bugs item #1192287, was opened at 2005-04-29 11:09 Message generated for change (Settings changed) made by drieseng You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1192287group_id=31650 Category: Core Group: 0.85 Status: Closed Resolution: Fixed Priority: 7 Submitted By: Filip (philk) Assigned to: Gert Driesen (drieseng) Summary: NAnt build core dumped on FreeBSD Initial Comment: I'm not able to compile NAnt on FreeBSD. Each attempt fails with: System was remapped (http://www.go-mono.com/remap.html) Compat mode: the request from /usr/home/phil/opt/nant-0.85-nightly-2005-04-20/bootstrap/log4net.dll to load System.Data was remapped (http://www.go-mono.com/remap.html) Compat mode: the request from /usr/home/phil/opt/nant-0.85-nightly-2005-04-20/bootstrap/log4net.dll to load System.Web was remapped (http://www.go-mono.com/remap.html) NAnt 0.85 (Build 0.85.1936.0; nightly; 04/20/2005) Copyright (C) 2001-2005 Gerry Shaw http://nant.sourceforge.net gmake: *** [build-nant] Segmentation fault (core dumped) -- Comment By: Filip (philk) Date: 2005-05-05 16:26 Message: Logged In: YES user_id=245405 Thank you! works fine (nant-0.85-nightly-2005-05-05) -- Comment By: Gert Driesen (drieseng) Date: 2005-05-04 16:35 Message: Logged In: YES user_id=707851 This should be fixed in the next nightly build. -- Comment By: Filip (philk) Date: 2005-05-04 16:29 Message: Logged In: YES user_id=245405 sorry, Mono 1.1.6.10; thank for you help. -- Comment By: Filip (philk) Date: 2005-05-04 16:26 Message: Logged In: YES user_id=245405 The Mono 1.6.10 works fine but ... mono bootstrap/NAnt.exe -f:NAnt.build build The NAnt configuration file (/usr/home/phil/opt/nant-0.85-nightly-2005-04-20/bootstrap/NAnt.exe.config) does not have a framework node for the current runtime framework. Please add a framework node with family 'mono' and clrversion '2.0.50215' under the 'unix' platform node. -- Comment By: Filip (philk) Date: 2005-05-04 13:40 Message: Logged In: YES user_id=245405 It seems that you are right; bug was raised http://bugzilla.ximian.com/show_bug.cgi?id=74782 Thank you. -- Comment By: Gert Driesen (drieseng) Date: 2005-05-03 21:58 Message: Logged In: YES user_id=707851 I'm sorry if I cannot be more helpful, but this seems to be a Mono issue. Have you tried using a 1.1.x version of Mono ? -- Comment By: Filip (philk) Date: 2005-04-29 14:36 Message: Logged In: YES user_id=245405 epidem% uname -a FreeBSD epidem 5.4-STABLE FreeBSD 5.4-STABLE #28: Mon Apr 11 11:13:16 CEST 2005 [EMAIL PROTECTED]:/usr/obj/usr/src/sys/EPIDEM i386 epidem% mono --version Mono JIT compiler version 1.0.6, (C) 2002-2004 Novell, Inc and Contributors. www.go-mono.com TLS: normal GC:Included Boehm (with typed GC) SIGSEGV : normal Globalization: none -- Comment By: Filip (philk) Date: 2005-04-29 11:24 Message: Logged In: YES user_id=245405 I don't know what causes core dump but the bug is critical for me because I want use NAnt to build my new C# project. Thank you. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1192287group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1187506 ] NAnt.Core.BuildException: Circular dependency detected.
Bugs item #1187506, was opened at 2005-04-21 18:29 Message generated for change (Comment added) made by drieseng You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1187506group_id=31650 Category: Core Group: None Status: Open Resolution: None Priority: 9 Submitted By: svakiltx (svakiltx) Assigned to: Gert Driesen (drieseng) Summary: NAnt.Core.BuildException: Circular dependency detected. Initial Comment: [solution] Starting solution build. [solution] Loading projects... [solution] Loading project 'C:\Odyssey\Production\Source\Orion\PropertySe archWe bService\PropertySearch\PropertySearch.csproj'. [solution] Gathering additional dependencies... [solution] Fixing up references... [solution] Converted assembly reference to project reference: PropertySearch - PropertySearch BUILD FAILED - 0 non-fatal error(s), 2 warning(s) Circular dependency detected.: NAnt.Core.BuildException: Circular dependency detected. at NAnt.VSNet.SolutionBase.Compile(String solutionConfiguration) in d:\Source \nant- 20050420T141941Z\src\NAnt.VSNet\SolutionBase.cs:lin e 255 at NAnt.VSNet.Tasks.SolutionTask.ExecuteTask() in d:\Source\nant-20050420T141 941Z\src\NAnt.VSNet\Tasks\SolutionTask.cs:line 409 at NAnt.Core.Task.Execute() in d:\Source\nant- 20050420T141941Z\src\NAnt.CoreTask.cs:line 177 at NAnt.Core.Target.Execute() in d:\Source\nant- 20050420T141941Z\src\NAnt.Cor e\Target.cs:line 247 at NAnt.Core.Project.Execute(String targetName, Boolean forceDependencies) in d:\Source\nant- 20050420T141941Z\src\NAnt.Core\Project.cs:line 887 at NAnt.Core.Project.Execute() in d:\Source\nant- 20050420T141941Z\src\NAnt.Co re\Project.cs:line 839 at NAnt.Core.Project.Run() in d:\Source\nant- 20050420T141941Z\src\NAnt.Core\P roject.cs:line 924 -- Comment By: Gert Driesen (drieseng) Date: 2005-05-05 17:52 Message: Logged In: YES user_id=707851 What version of NAnt are you using ? Can you provide a small repro for this issue ? Thanks ! -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1187506group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1187374 ] Invalid ResX input
Bugs item #1187374, was opened at 2005-04-21 15:45 Message generated for change (Comment added) made by tkocian You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1187374group_id=31650 Category: Other Group: 0.85 Status: Open Resolution: None Priority: 5 Submitted By: tkocian (tkocian) Assigned to: Nobody/Anonymous (nobody) Summary: Invalid ResX input Initial Comment: During building I got the following error message: [solution] Building 'RSM.Cash.Common' [Debug] ... [resgen] error: Invalid ResX input. [resgen] error: Specific exception: XmlException Message: Invalid ResX input. --- XmlException: There is no Unicode byte order mark. Cannot switch to Unicode. [resgen] 2 error(s). BUILD FAILED - 0 non-fatal error(s), 4 warning(s) External Program Failed: C:\Program Files\Microsoft Visual Studio .NET 2003\SDK\v1.1\bin\resgen.exe (return code was -1163019603) Is there a workaround for it? I'm using version 0.85 rc3. Thanks for your help Tomas -- Comment By: tkocian (tkocian) Date: 2005-05-05 17:52 Message: Logged In: YES user_id=1263817 Sorry, I'm not a developer but I tried to prepare a small solution for you. -- Comment By: Gert Driesen (drieseng) Date: 2005-05-03 17:21 Message: Logged In: YES user_id=707851 Can you send me a small repro for this issue ? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1187374group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-1187374 ] Invalid ResX input
Bugs item #1187374, was opened at 2005-04-21 15:45 Message generated for change (Comment added) made by drieseng You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1187374group_id=31650 Category: Third party libraries Group: 0.85 Status: Closed Resolution: None Priority: 5 Submitted By: tkocian (tkocian) Assigned to: Gert Driesen (drieseng) Summary: Invalid ResX input Initial Comment: During building I got the following error message: [solution] Building 'RSM.Cash.Common' [Debug] ... [resgen] error: Invalid ResX input. [resgen] error: Specific exception: XmlException Message: Invalid ResX input. --- XmlException: There is no Unicode byte order mark. Cannot switch to Unicode. [resgen] 2 error(s). BUILD FAILED - 0 non-fatal error(s), 4 warning(s) External Program Failed: C:\Program Files\Microsoft Visual Studio .NET 2003\SDK\v1.1\bin\resgen.exe (return code was -1163019603) Is there a workaround for it? I'm using version 0.85 rc3. Thanks for your help Tomas -- Comment By: Gert Driesen (drieseng) Date: 2005-05-05 18:20 Message: Logged In: YES user_id=707851 There seems to be a change in behaviour between resgen (which is part of the .NET Framework SDK, and which is what NAnt uses to compile resources) and VS.NET 2003. Your resx file is in fact a UTF-8 encoded file, but with encoding attribute of the XML processing instruction set to UTF-16. VS.NET 2003 seems to have no problems with this, but resgen (in both .NET 1.1 and .NET 2.0) and VS.NET 2005 (where the internal build system, msbuild, also uses resgen) does. I'd advise you to just change the value of the encoding attribute from utf-16 to utf-8. Was this resx file created by VS.NET or did you create it manually ? I'm closing this bug report, as this is definitely not a bug in NAnt. Feel free to report it to MS using the MSDN Product Feedback Center (as it affects not just NAnt but also VS.NET 2005). -- Comment By: tkocian (tkocian) Date: 2005-05-05 17:52 Message: Logged In: YES user_id=1263817 Sorry, I'm not a developer but I tried to prepare a small solution for you. -- Comment By: Gert Driesen (drieseng) Date: 2005-05-03 17:21 Message: Logged In: YES user_id=707851 Can you send me a small repro for this issue ? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=1187374group_id=31650 --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] patch for FileSet extension
Martin Aliger wrote: Hi Gary, as I implemented it, it converts scanned files from first fileset to full path asis includes. So fileset id=foo1 basedir=X:\nant\t1 include name=world.peace / include name=world.war/ /fileset fileset id=foo2 basedir=X:\nant\t1 includesfileset refid=foo1/ exclude name=world.war/ include name=reefer.saddness / /fileset becomes fileset id=foo2 basedir=X:\nant\t1 include asis=true name=X:\nant\t1\world.peace/ include asis=true name=X:\nant\t1\world.war/ exclude name=world.war/ include name=reefer.saddness / /fileset To your question with excludes: - all excludes in foo1 are respected. - no exclude in foo2 take effect on included files. Thats something which is already in place. Excludes do _not_ affect asis includes. It sounds a little strange to me, but I'd rather not change something what is in place for several years. Is this behaviour right? Maybe yes. I think about includesfileset like fileset merging operation - so you merge existing fileset with some include/exclude mask. But I see, there is no way how to filter out existing fileset to another one... So maybe its not right way? Ideas? Note: reason why I used asis is to prevent double-scan. asis includes are not scanned anymore, and all included files via includesfileset was scanned once already. Interesting. I think there is an opportunity for optimizing this, to eliminate the asis by changing the synchronization point. For example, if the contents of the foo1 fileset were not computed until actually needed, then you could do away with the asis and apply the exclude. Part of the problem is that asis seems to violate the principle of one method/class/object/parameter should do one thing. It's doing three things: suppressing the existence check, suppressing the application of excludes, and suppressing the pattern matching (in case you were on a file system silly enough to allow asterisks in the file name). I doubt the last is necessary; it could just be poor wording in the documentation. I don't know if there's a justification for suppressing the excludes. What happens if you remove the implicit asis that you generate, and instead insert explicit asis attributes into the foo1 fileset? (Regardless of what the decision is, the test cases need to include all combinations of asis, include, exclude, fromdir, relative basedir, absolute basedir, and omitted basedir.) Gary --- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
