- Original Message -
From: Matthew Mastracci [EMAIL PROTECTED]
To: Gert Driesen [EMAIL PROTECTED]
Cc: Ian MacLean [EMAIL PROTECTED]
Sent: Tuesday, September 07, 2004 7:57 PM
Subject: Re: fileset/directoryscanner hang
I think we decided to just document this side-effect.
My memory fails me here ... But if that is what we decided, then I guess we
should indeed document it in both the filset doc and in the release notes ..
The base
directory is now returned when the pattern **/* is used, whereas
before it was not. All other patterns are identical. AFAIK, **/* is
equivalent to ** anyways. To avoid matching the base directory,
people should be using */** instead.
Would be interesting to check what Ant does here ...
The reason for keeping this was that it was more consistent with
patterns like foo/**/bar.cs. We can enhance the warning in
DirectoryScanner.cs to recommend using either ** to match the base
directory or */** to not match the base directory. I suppose we could
even make that particular pattern an error.
Not sure we should do this ...
Gert
PS. I'm copying the dev list in on this ...
Gert Driesen wrote:
Matthew,
I think you already mentioned this before, but your changes actually
have a side effect: the base directory of the fileset is now also
returned as an entry in the DirectoryNames string collection.
Is it possible to fix this side-effect ?
Gert
- Original Message - From: Matthew Mastracci [EMAIL PROTECTED]
To: Gert Driesen [EMAIL PROTECTED]
Cc: Ian MacLean [EMAIL PROTECTED]
Sent: Saturday, September 04, 2004 5:10 PM
Subject: Re: fileset/directoryscanner hang
Okay. I see the problem now. If a Regex entry doesn't have a
BaseDirectory set (like any of the exclude patterns) it won't be applied
properly.
I added code at one point to clear the BaseDirectory if the pattern is
an exclude one. I'll take that out since it seems to be the culprit.
Gert - can you reget CVS and see if this fixes your problem?
Thanks,
Matt.
On Fri, 2004-09-03 at 23:33, Gert Driesen wrote:
- Original Message - From: Matthew Mastracci
[EMAIL PROTECTED]
To: Gert Driesen [EMAIL PROTECTED]
Cc: Ian MacLean [EMAIL PROTECTED]
Sent: Friday, September 03, 2004 10:52 PM
Subject: Re: fileset/directoryscanner hang
Hrm... not sure what's going on. When you have a chance, please
uncomment the DEBUG_REGEXES line in DirectoryScanner.cs and send me
the output. It might help us find out what might be going on here.
here you go ...
Gert
--
Matthew Mastracci [EMAIL PROTECTED]
---
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047alloc_id=10808op=click
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
