RE: [nant-dev] debug=true/full and DEBUG

2005-03-08 Thread Gert Driesen



This change has now been committed to 
cvs.

  
  
  From: 
  [EMAIL PROTECTED] 
  [mailto:[EMAIL PROTECTED] On Behalf Of Erv 
  WalterSent: dinsdag 8 maart 2005 22:01To: Gert Driesen; 
  nant-developers@lists.sourceforge.netSubject: RE: [nant-dev] 
  debug=true/full and DEBUG
  
  
  That would work 
  great!  I agree that whatever is done, it should be non breaking to 
  existing true/false settings.
   
  
  
  
  
  From: Gert 
  Driesen [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 08, 2005 2:45 
  PMTo: Erv Walter; 
  nant-developers@lists.sourceforge.netSubject: RE: [nant-dev] debug=true/full 
  and DEBUG
   
  Hi,
   
  I agree that it 
  would've been better to not implicitly set symbols, but instead leave it up to 
  the build authors to use the define attribute for this 
  purpose.
   
  I'm not sure whether 
  its a good idea to introduce such a (breaking) change. We could ofcourse not 
  define any symbols when the "debug" attribute is set to Full, PdbOnly 
  or None.
   
  What do you think 
  ?
   
  Gert
   
  
  
  
  From: 
  [EMAIL PROTECTED] 
  [mailto:[EMAIL PROTECTED] On Behalf Of Erv WalterSent: dinsdag 8 maart 2005 
  20:29To: Gert Driesen; 
  nant-developers@lists.sourceforge.netSubject: [nant-dev] debug=true/full and 
  DEBUG
  
I am wondering 
about another issue that I initially thought might be helped by the 
change below, but it turned out not quite.  I think this has been asked 
before (a long time ago), but I figured I'd ask 
again.
 
Currently (in cvs), 
the csc task sets the DEBUG symbol if debug is true, Full, or PdbOnly.  
That is fairly limiting in the first two cases and I think conceptually 
"wrong" in the last case.  By setting DEBUG, many conditionally 
compiled functions are included in the compiled assembly.  In the 
PdbOnly case, that is probably not what is desired.  Someone using 
PdbOnly probably wants a "release" style build but with a pdb file.  
They will instead get all their DEBUG stuff included (Debug.Writeline, 
Debug.Assert, etc).
 
Our situation is 
slightly different.  We would like to turn on the debug build (to 
include debugging symbols), but *not* define DEBUG.  In VS.NET project 
files, I believe it's possible to control debug symbols separately from 
compilation symbols such as DEBUG.  We've wished for a while that this 
was possible in the  task.  Any thoughts on perhaps another 
entry in the DebugOutput enum that would allow this sort of situation?  
Or some other workaround?
 
Thanks!!
 
 




From: Gert 
Driesen [mailto:[EMAIL PROTECTED]Sent: Sat 3/5/2005 8:43 AMTo: Walker, Brian; 
nant-developers@lists.sourceforge.netSubject: RE: [nant-dev] Patch for 
1156702

 [snip]
 
I've just added 
support for the different debug types to cvs.  Before this change, our 
compiler tasks only supported either full debug output or no debug output at 
all.

 
 [snip] 


RE: [nant-dev] debug=true/full and DEBUG

2005-03-08 Thread Erv Walter








That would work great!  I agree that
whatever is done, it should be non breaking to existing true/false settings.

 









From: Gert Driesen
[mailto:[EMAIL PROTECTED] 
Sent: Tuesday, March 08, 2005 2:45
PM
To: Erv Walter;
nant-developers@lists.sourceforge.net
Subject: RE: [nant-dev]
debug=true/full and DEBUG



 

Hi,

 

I agree that it would've been better to
not implicitly set symbols, but instead leave it up to the build authors to use
the define attribute for this purpose.

 

I'm not sure whether its a good idea to
introduce such a (breaking) change. We could ofcourse not define any symbols
when the "debug" attribute is set to Full, PdbOnly or None.

 

What do you think ?

 

Gert

 







From:
[EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Erv Walter
Sent: dinsdag 8 maart 2005 20:29
To: Gert Driesen;
nant-developers@lists.sourceforge.net
Subject: [nant-dev]
debug=true/full and DEBUG



I am wondering about another issue that I
initially thought might be helped by the change below, but it turned out
not quite.  I think this has been asked before (a long time ago), but I
figured I'd ask again.

 

Currently (in cvs), the csc task sets the
DEBUG symbol if debug is true, Full, or PdbOnly.  That is fairly limiting
in the first two cases and I think conceptually "wrong" in the last
case.  By setting DEBUG, many conditionally compiled functions are
included in the compiled assembly.  In the PdbOnly case, that is probably
not what is desired.  Someone using PdbOnly probably wants a
"release" style build but with a pdb file.  They will instead
get all their DEBUG stuff included (Debug.Writeline, Debug.Assert, etc).

 

Our situation is slightly different. 
We would like to turn on the debug build (to include debugging symbols), but
*not* define DEBUG.  In VS.NET project files, I believe it's possible to
control debug symbols separately from compilation symbols such as DEBUG. 
We've wished for a while that this was possible in the  task. 
Any thoughts on perhaps another entry in the DebugOutput enum that would allow
this sort of situation?  Or some other workaround?

 

Thanks!!

 

 









From: Gert
Driesen [mailto:[EMAIL PROTECTED]
Sent: Sat 3/5/2005 8:43 AM
To: Walker, Brian;
nant-developers@lists.sourceforge.net
Subject: RE: [nant-dev] Patch for
1156702





 [snip]

 

I've just added support for the different
debug types to cvs.  Before this change, our compiler tasks only supported
either full debug output or no debug output at all.



 



 [snip] 












RE: [nant-dev] debug=true/full and DEBUG

2005-03-08 Thread Gert Driesen



Hi,
 
I agree that it would've been better to not implicitly set 
symbols, but instead leave it up to the build authors to use the define 
attribute for this purpose.
 
I'm not sure whether its a good idea to introduce such a 
(breaking) change. We could ofcourse not define any symbols when the "debug" 
attribute is set to Full, PdbOnly or None.
 
What do you think ?
 
Gert
 



From: 
[EMAIL PROTECTED] 
[mailto:[EMAIL PROTECTED] On Behalf Of Erv 
WalterSent: dinsdag 8 maart 2005 20:29To: Gert Driesen; 
nant-developers@lists.sourceforge.netSubject: [nant-dev] 
debug=true/full and DEBUG

  
  I am wondering about another issue that I initially 
  thought might be helped by the change below, but it turned out not 
  quite.  I think this has been asked before (a long time ago), but I 
  figured I'd ask again.
   
  Currently (in cvs), the csc task sets the DEBUG 
  symbol if debug is true, Full, or PdbOnly.  That is fairly limiting in 
  the first two cases and I think conceptually "wrong" in the last case.  
  By setting DEBUG, many conditionally compiled functions are included in the 
  compiled assembly.  In the PdbOnly case, that is probably not what is 
  desired.  Someone using PdbOnly probably wants a "release" style build 
  but with a pdb file.  They will instead get all their DEBUG stuff 
  included (Debug.Writeline, Debug.Assert, etc).
   
  Our situation is slightly different.  We would 
  like to turn on the debug build (to include debugging symbols), but *not* 
  define DEBUG.  In VS.NET project files, I believe it's possible to 
  control debug symbols separately from compilation symbols such as DEBUG.  
  We've wished for a while that this was possible in the  task.  
  Any thoughts on perhaps another entry in the DebugOutput enum that would allow 
  this sort of situation?  Or some other workaround?
   
  Thanks!!
   
   
  
  
  
  From: Gert Driesen 
  [mailto:[EMAIL PROTECTED]Sent: Sat 3/5/2005 8:43 
  AMTo: Walker, Brian; 
  nant-developers@lists.sourceforge.netSubject: RE: [nant-dev] Patch 
  for 1156702
  
   [snip]
   
  I've 
  just added support for the different debug types to cvs.  Before this change, our compiler tasks only 
  supported either full debug output or no debug output at 
  all.
   
   [snip] 


[nant-dev] debug=true/full and DEBUG

2005-03-08 Thread Erv Walter



I am wondering about another issue that I initially 
thought might be helped by the change below, but it turned out not 
quite.  I think this has been asked before (a long time ago), but I figured 
I'd ask again.
 
Currently (in cvs), the csc task sets the DEBUG symbol 
if debug is true, Full, or PdbOnly.  That is fairly limiting in the first 
two cases and I think conceptually "wrong" in the last case.  By setting 
DEBUG, many conditionally compiled functions are included in the compiled 
assembly.  In the PdbOnly case, that is probably not what is desired.  
Someone using PdbOnly probably wants a "release" style build but with a pdb 
file.  They will instead get all their DEBUG stuff included 
(Debug.Writeline, Debug.Assert, etc).
 
Our situation is slightly different.  We would 
like to turn on the debug build (to include debugging symbols), but *not* define 
DEBUG.  In VS.NET project files, I believe it's possible to control debug 
symbols separately from compilation symbols such as DEBUG.  We've wished 
for a while that this was possible in the  task.  Any thoughts 
on perhaps another entry in the DebugOutput enum that would allow this sort of 
situation?  Or some other workaround?
 
Thanks!!
 
 



From: Gert Driesen 
[mailto:[EMAIL PROTECTED]Sent: Sat 3/5/2005 8:43 
AMTo: Walker, Brian; 
nant-developers@lists.sourceforge.netSubject: RE: [nant-dev] Patch 
for 1156702

 [snip]
 
I've 
just added support for the different debug types to cvs.  Before this change, our compiler tasks only 
supported either full debug output or no debug output at 
all.
 
 [snip]