Re: [nant-dev] filesets speed
Martin, If you have time, please implement this optimization. However, as the fileset implementation is a very critical feature of NAnt, any changes to it should be accompanied by unit tests (and needless to say that all existing tests should continue to pass). Thanks ! Gert - Original Message - From: Martin Aliger [EMAIL PROTECTED] To: nant-developers@lists.sourceforge.net Sent: Friday, September 09, 2005 5:37 PM Subject: RE: [nant-dev] filesets speed c:\test\foo\etc should be discarded when scanned and not dip into, since none file/folder in it could ever satisfy any pattern. c:\test\foo\Gordic1 shouldn't be discarded and scanned normaly as today. c:\test\foo\Gordic1\_svn shouldn't be discarded as well ---^ SHOULD BE. Since none file in this folder or subfolders could ever satisfy any pattern. Late friday and mine keyboard is tired or what :-) Damn copy/paste! Regards, Martin --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] filesets speed
Hello, I just noticed that fileset containting pattern like this "foo*/xxx" are considered recursive and therefore DirectoryScanner scans whole directory structure. That is not (completely) true - thosepatterns could not contain files in other depth than 1. I'd like to come with some optimalization to speed up this case. I tried to add another condition into "Only include the valid patterns for this path" part of DirectoryScanner, which would do some partial-regexp-match to see, if any deeper object could potentially satisfy that pattern. if not - its not neccessary to scan deeper. e.g. fileset id="buildfiles" basedir="c:\test\foo" defaultexcludes="false"include name="Gordic*/*.csproj"//fileset c:\test\foo\etc should be discarded when scanned and not dip into, since none file/folder in it could ever satisfy any pattern. c:\test\foo\Gordic1 shouldn't be discarded and scanned normaly as today. c:\test\foo\Gordic1\_svn shouldn't be discarded as well What do you think about this optimalization? Any idea how to (easily) perform it? Martin
RE: [nant-dev] filesets speed
c:\test\foo\etc should be discarded when scanned and not dip into, since none file/folder in it could ever satisfy any pattern. c:\test\foo\Gordic1 shouldn't be discarded and scanned normaly as today. c:\test\foo\Gordic1\_svn shouldn't be discarded as well ---^ SHOULD BE. Since none file in this folder or subfolders could ever satisfy any pattern. Late friday and mine keyboard is tired or what :-) Damn copy/paste! Regards, Martin --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
