Re: [naviserver-devel] Naviserver hangs on Windows

2014-10-04 Thread Maurizio Martignano
Again,
What is your target? Windows 32 or Windows 64?
Did you use the define _USE_32BIT_TIME_T yes or not?

Thank you,
Maurizio


-Original Message-
From: Andrew Piskorski [mailto:a...@piskorski.com] 
Sent: 04 October 2014 13:00
To: naviserver-devel@lists.sourceforge.net
Subject: Re: [naviserver-devel] Naviserver hangs on Windows

On Fri, Oct 03, 2014 at 10:49:27AM -0400, Andrew Piskorski wrote:
> Hm, the old AOLserver 4.0.7 version of Ns_GetTime() had a Windows 
> ifdef which is entirely missing from Naviserver!  (See below.)

I added back that Windows-specific Ns_GetTime() here:

 
https://bitbucket.org/apiskors/naviserver/commits/51f1735d788d7b00adc797a757
9272763ddd9bcf

With that change, "nsd -h" started working, but running nsd with any other
arguments now stops with a Windows pop-up box saying:

  Debug Assertion Failed!
  File: f:\dd\vctools\crt_bld\self_64_amd64\crt\src\strftime.c
  Line: 615
  Expression:  ((timeptr->tm_mday >= 1) && (timeptr->tm_mday <= 31))

Mysteriously, with that new next problem I can't seem to get any plausible
backtrace out of WinDbg.  However, strftime() only appears three times in
the entire Naviserver codebase, so I very strongly suspect that it's
actually hitting that assertion in LogTime() (in nsd/log.c).

So in LogTime(), I added some simple printf's just before calling
strftime().  ptm->tm_mday and all the other struct members have a value of
-1.  That's because in ns_localtime(), localtime_s() returns an EINVAL = 22
"Invalid argument" error code, and then sets all the members to -1.

  http://msdn.microsoft.com/en-us/library/a442x3ye.aspx

The *tp and *clock values look like a correct time_t count of seconds since
the Unix epoch.  So perhaps something is wrong with the only other argument
ther to localtime_s():  &tlsPtr->ltbuf

But what?  Any ideas?

--
Andrew Piskorski 


--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI
DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you
Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI
DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
___
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel


--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
___
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel


Re: [naviserver-devel] Naviserver hangs on Windows

2014-10-04 Thread Andrew Piskorski
On Fri, Oct 03, 2014 at 10:49:27AM -0400, Andrew Piskorski wrote:
> Hm, the old AOLserver 4.0.7 version of Ns_GetTime() had a Windows
> ifdef which is entirely missing from Naviserver!  (See below.)

I added back that Windows-specific Ns_GetTime() here:

  
https://bitbucket.org/apiskors/naviserver/commits/51f1735d788d7b00adc797a7579272763ddd9bcf

With that change, "nsd -h" started working, but running nsd with any
other arguments now stops with a Windows pop-up box saying:

  Debug Assertion Failed!
  File: f:\dd\vctools\crt_bld\self_64_amd64\crt\src\strftime.c
  Line: 615
  Expression:  ((timeptr->tm_mday >= 1) && (timeptr->tm_mday <= 31))

Mysteriously, with that new next problem I can't seem to get any
plausible backtrace out of WinDbg.  However, strftime() only appears
three times in the entire Naviserver codebase, so I very strongly
suspect that it's actually hitting that assertion in LogTime() (in
nsd/log.c).

So in LogTime(), I added some simple printf's just before calling
strftime().  ptm->tm_mday and all the other struct members have a
value of -1.  That's because in ns_localtime(), localtime_s() returns
an EINVAL = 22 "Invalid argument" error code, and then sets all the
members to -1.

  http://msdn.microsoft.com/en-us/library/a442x3ye.aspx

The *tp and *clock values look like a correct time_t count of seconds
since the Unix epoch.  So perhaps something is wrong with the only
other argument ther to localtime_s():  &tlsPtr->ltbuf

But what?  Any ideas?

-- 
Andrew Piskorski 

--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
___
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel


Re: [naviserver-devel] were all AOLserver 4.0.x bugfixes merged?

2014-10-04 Thread Maurizio Martignano
Dear Andrew,
You have risen a very good point.
This is what I think.
1. Fact - Naviserver forked from Aolserver 4.0.x
2. Fact - Aolserver evolved to Aolserver 4.5.2 and then stopped
3. Fact - Naviserver doesn't contain the changes/improvements occurred in
Aolserver fron 4.0.x to 4.5.2
4. Fact - All new developments are now occurring on Naviserver
5. Opinion - I believe Aolserver code base is more stable (it is used a lot
and there's no development on it)
6. Opinion - I believe Naviserver needs to get more stable both in terms of
build processes(es) and code base
7. Fact - I do not have time at the moment to work on this area but I see
with great pleasure the efforts you are putting on Windows part and the
build process and Gustaf on the code base stability (look at all the changes
Gustaf has recently introduced). Anyhow I am trying to support both efforts
as much as I can (some of the changes Gustaf has introduced are the result
of little suggestions, tips I gave him. I am actually maintaining an on line
database with all the results of some static analyses performed on both
Aolserver 4.5.2 and Naviserver - the very last version.)
8. Opinion - I believe this is the path Naviserver should follow:
8.1 - You improve the build process(es)  and Windows related code base,
looking at what was done in Aolserver till version 4.5.2
8.2 - We retain the results of the wonderful work Gustaf is doing on the
overall codebase.

Hope it helps,
Maurizio


-Original Message-
From: Andrew Piskorski [mailto:a...@piskorski.com] 
Sent: 04 October 2014 08:51
To: naviserver-devel@lists.sourceforge.net
Subject: [naviserver-devel] were all AOLserver 4.0.x bugfixes merged?

When exactly did Naviserver fork from AOLserver, and have all the relevent
bugfixes made to AOLserver since then been merged into Naviserver?  (I see a
few that look like they haven't been...)

Although I don't see any official mention of it, from comparing the
Naviserver and aolserver-40x repositories on Bitbucket it sure looks like
Naviserver forked from the aolserver-4.0.10 release, and that this was the
last commit made by anyone PRIOR to forking:

  changeset:   1095:e9c50ae686b5 
  user:Dossy Shiobara  
  date:Tue Jan 18 21:10:07 2005 + 
  description:  Tag aolserver-4.0.10 

--
Andrew Piskorski 


--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI
DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you
Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI
DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
___
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel


--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
___
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel


[naviserver-devel] use nsconfig.tcl to compile on Windows?

2014-10-04 Thread Andrew Piskorski
On Fri, Oct 03, 2014 at 05:20:48PM +0200, Maurizio Martignano wrote:
> Subject: Re: Naviserver hangs on Windows

> The Windows-OpenACS distribution which I make available here
> (http://www.spazioit.com/pages_en/sol_inf_en/windows-openacs_en/) is based
> on AOLServer 4.5.2, contains the sources, is compiled with Visual Studio
> 2013 and runs on Windows 64.

Indeed, the first thing I noticed is that Maurizio's Windows build
seems to use nsconfig.tcl in place of the Unix configure/autoconf,
which Jim Davidson added back in 2005.

Naviserver folks, can you comment on what you think of that approach?
Does Naviserver not include it solely because it wasn't included in
the AOLserver 4.0.10 branch that Naviserver forked from?


https://bitbucket.org/aolserver/aolserver/src/2aa0f24395ae0a42fd590f3635e4fdf2c7eefdfd/nsconfig.tcl?at=default

andy@milo:/home/nobackup/co/nsd-aol/aolserver-head-hg$ hg log nsconfig.tcl 
configure.tcl 
changeset:   1370:76895d8bf843 
user:Jim Davidson  
date:Thu Aug 18 21:48:21 2005 +0100 
summary: Renamed configure script configure.tcl 
 
changeset:   1367:9c88ea73dcad 
user:Jim Davidson  
date:Wed Aug 17 23:55:57 2005 +0100 
summary: Updates to new build tools to support Unix 
 
changeset:   1360:697679717350 
user:Jim Davidson  
date:Wed Aug 17 22:18:46 2005 +0100 
summary: New platform-indepedent build support 

-- 
Andrew Piskorski 

--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
___
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel