Re: [naviserver-devel] [naviserver-commits] naviserver/nsd tclobj.c, 1.7, 1.8
On Sat, Apr 26, 2008 at 8:50 PM, Zoran Vasiljevic [EMAIL PROTECTED] wrote: Update of /cvsroot/naviserver/naviserver/nsd In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv10260/nsd Modified Files: tclobj.c Log Message: * nsd/tclobj.c: Changed Tcl handle format to include hyphens (-) instead of spaces, as spaces create troubles with Tcl [eval]. This change broke these tests: ns_thread-2.2 wait for thread thread FAILED ns_thread-3.1 create and destroy a mutex FAILED ns_thread-4.1 create and destroy a critical section FAILED ns_thread-5.1 create and destroy a semaphore FAILED ns_thread-6.1 create and destroy a read-write lock FAILED - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel
Re: [naviserver-devel] [naviserver-commits] naviserver/nsd tclobj.c, 1.7, 1.8
On 12.05.2008, at 13:53, Vasiljevic Zoran wrote: So I will fix those tests. Fixed. Really, the format of the handle(s) was a great pain for me for some auto-synthetized code... - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel
Re: [naviserver-devel] [naviserver-commits] naviserver/nsd tclobj.c, 1.7, 1.8
On Mon, May 12, 2008 at 1:25 PM, Vasiljevic Zoran [EMAIL PROTECTED] wrote: On 12.05.2008, at 13:53, Vasiljevic Zoran wrote: So I will fix those tests. Fixed. Really, the format of the handle(s) was a great pain for me for some auto-synthetized code... No problem. It's a good change. I was just passively-aggressively suggesting you don't run 'make test' enough... :-) Also, there's no tests/ns_job.test to cover all those bugs you fixed. - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel
Re: [naviserver-devel] [naviserver-commits] naviserver/nsd tclobj.c, 1.7, 1.8
On 12.05.2008, at 14:41, Stephen Deasey wrote: I was just passively-aggressively suggesting you don't run 'make test' enough... :-) I know. Huh. There must be a reason to that. And the reason is that I have a slightly diffent build for our product which is sometimes (link- wise) colliding with off-the-shelf build. In order to make test I first need to remove/save /usr/local/ns, then make install then make test then I need to re-activate my private state. This isn't that complex but when you are under time-constraints (i am always under time-constraints) you default to saving time wherever you can. The make test is a first candidate most of the time... Also, there's no tests/ns_job.test to cover all those bugs you fixed. There are no bugs got fixed. Rather I added new feature and while adding it, I made some errors because of the non-transparent locking strategy. Which I then fixed again. So the only real test that should go there is to check the (new) script cancellation. I will put this on the my list. FWIW: please DO continue to bug myself and others to keep good practices. This increases the quality of the code and I am ALL for it. Cheers Zoran - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel
