hg: jdk7/tl/langtools: 6968497: localized text appears in raw diagnostic
Changeset: 064468702a8d Author:jjg Date: 2010-07-12 16:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/064468702a8d 6968497: localized text appears in raw diagnostic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/generics/6946618/T6946618c.java ! test/tools/javac/generics/6946618/T6946618c.out
hg: jdk7/tl/jdk: 2 new changesets
Changeset: ddf825161d2d Author:dcubed Date: 2010-07-12 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ddf825161d2d 6968401: 3/3 disable tests added by 6942989 until 6964018 is fixed Summary: Disable AnonLoggerWeakRefLeak.sh and LoggerWeakRefLeak.sh Reviewed-by: ohair ! test/java/util/logging/AnonLoggerWeakRefLeak.sh ! test/java/util/logging/LoggerWeakRefLeak.sh Changeset: 4e365ef6576d Author:dcubed Date: 2010-07-12 15:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e365ef6576d Merge
hg: jdk7/tl/jdk: 6921472: RFE: java launcher code needs clean up
Changeset: d3fa95d0710c Author:ksrini Date: 2010-07-09 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3fa95d0710c 6921472: RFE: java launcher code needs clean up Summary: This changeset also contains fixes for 6405284, 6753938 and 6922500 Reviewed-by: darcy ! src/share/bin/emessages.h ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/jli_util.c ! src/share/bin/jli_util.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c ! test/tools/launcher/Arrrghs.java
Re: 6964714, Please review the fix (XS), round 3
Dmitry, looks good. -Chris. Dmitry Samersoff wrote: On 2010-07-12 22:30, Alan Bateman wrote: Dmitry Samersoff wrote: Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry The copyright date on the new test says 2008 :-) Copy-paste from a neighbor ;) Fixed? http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.05/ -Dmitry
Re: 6964714, Please review the fix (XS), round 3
On 2010-07-12 22:30, Alan Bateman wrote: Dmitry Samersoff wrote: Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry The copyright date on the new test says 2008 :-) Copy-paste from a neighbor ;) Fixed? http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.05/ -Dmitry -- Dmitry Samersoff J2SE Sustaining team, SPB04 * Give Rabbit time and he'll always get the answer ...
Re: 6964714, Please review the fix (XS), round 3
Dmitry Samersoff wrote: Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry The copyright date on the new test says 2008 :-) Otherwise looks good to me. -Alan.
Re: 6964714, Please review the fix (XS), round 3
Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry On 2010-07-12 12:00, Alan Bateman wrote: Dmitry Samersoff wrote: Chris, Please review my changes. see: http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/ -Dmitry The fix to NetworkInterface.c looks good to me. I notice you've got the Sun copyright header in the test so that should be fixed. Also I agree with Chris's comment that the test can simply check if the Enumeration contains an element that is an instance of Inet6Address. Minor nit is that you seem to be intending by 8 instead of 4 spaces. Given that the test is in the NetworkInterface directory then an alternative name might be IPv4Only.java (keep the name short?). -Alan. -- Dmitry Samersoff J2SE Sustaining team, SPB04 * Give Rabbit time and he'll always get the answer ...
hg: jdk7/tl/jdk: 3 new changesets
Changeset: a7f8f269f741 Author:chegar Date: 2010-07-12 18:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a7f8f269f741 6967937: Scope id no longer being set after 6931566 Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/Inet6Address/B6214234.java Changeset: 1371a2d5f3a8 Author:chegar Date: 2010-07-12 18:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1371a2d5f3a8 6967684: httpserver using a non thread-safe SimpleDateFormat Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/ExchangeImpl.java Changeset: bb0b32ffefe9 Author:chegar Date: 2010-07-12 18:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bb0b32ffefe9 6966846: Incorrect assertion in java.net.Inet6Address.readObject Reviewed-by: michaelm ! src/share/classes/java/net/Inet6Address.java
Re: Code Review 6967937: Scope id no longer being set after 6931566
Chris Hegarty wrote: : Updated Webrev: http://cr.openjdk.java.net/~chegar/6967937/webrev.01/webrev/ The updated webrev looks good to me. -Alan.
Re: Code Review 6967937: Scope id no longer being set after 6931566
On 07/12/10 12:32, Alan Bateman wrote: Chris Hegarty wrote: Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This was missed during code review as there was a lot of refactoring to clean up the code. The solution is to simply set the scope id as was the case in the original code. Webrev: http://cr.openjdk.java.net/~chegar/6967937/webrev.00/webrev/ Thanks, -Chris. Looks okay to me. Is this covered by an existing test or do we need a new test? Yes, there is a specific test for this. While you are there, does getIndex need the env parameter? It doesn't seem to be needed. Done. Updated Webrev: http://cr.openjdk.java.net/~chegar/6967937/webrev.01/webrev/ Thanks, -Chris. -Alan.
Re: Code Review 6967937: Scope id no longer being set after 6931566
On 2010-07-12 13:54, Chris Hegarty wrote: Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 Looks good for me. Thank you for fixing it. -Dmitry CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This was missed during code review as there was a lot of refactoring to clean up the code. The solution is to simply set the scope id as was the case in the original code. Webrev: http://cr.openjdk.java.net/~chegar/6967937/webrev.00/webrev/ Thanks, -Chris. -- Dmitry Samersoff J2SE Sustaining team, SPB04 * Give Rabbit time and he'll always get the answer ...
Re: Code Review 6967937: Scope id no longer being set after 6931566
Chris Hegarty wrote: Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This was missed during code review as there was a lot of refactoring to clean up the code. The solution is to simply set the scope id as was the case in the original code. Webrev: http://cr.openjdk.java.net/~chegar/6967937/webrev.00/webrev/ Thanks, -Chris. Looks okay to me. Is this covered by an existing test or do we need a new test? While you are there, does getIndex need the env parameter? It doesn't seem to be needed. -Alan.
Code Review 6967937: Scope id no longer being set after 6931566
Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This was missed during code review as there was a lot of refactoring to clean up the code. The solution is to simply set the scope id as was the case in the original code. Webrev: http://cr.openjdk.java.net/~chegar/6967937/webrev.00/webrev/ Thanks, -Chris.
Re: 6964714, Please review the fix (XS), round 3
Dmitry Samersoff wrote: Chris, Please review my changes. see: http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/ -Dmitry The fix to NetworkInterface.c looks good to me. I notice you've got the Sun copyright header in the test so that should be fixed. Also I agree with Chris's comment that the test can simply check if the Enumeration contains an element that is an instance of Inet6Address. Minor nit is that you seem to be intending by 8 instead of 4 spaces. Given that the test is in the NetworkInterface directory then an alternative name might be IPv4Only.java (keep the name short?). -Alan.
