hg: jdk8/tl/jdk: 7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list

2011-08-12 Thread stuart . marks
Changeset: 3f66f9ca1ba5
Author:smarks
Date:  2011-08-12 14:51 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f66f9ca1ba5

7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list
Reviewed-by: weijun, alanb

! test/ProblemList.txt



hg: jdk8/tl/jdk: 4900206: Include worst-case rounding tests for Math library functions

2011-08-12 Thread joe . darcy
Changeset: 8f962aca221e
Author:darcy
Date:  2011-08-12 13:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f962aca221e

4900206: Include worst-case rounding tests for Math library functions
Reviewed-by: alanb

! test/java/lang/Math/Tests.java
+ test/java/lang/Math/WorstCaseTests.java



hg: jdk8/tl/jdk: 7078355: sun/net/www/protocol/file/DirPermissionDenied.sh leaves garbage on some linux systems

2011-08-12 Thread weijun . wang
Changeset: e533c13df9ad
Author:weijun
Date:  2011-08-12 21:04 +0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e533c13df9ad

7078355: sun/net/www/protocol/file/DirPermissionDenied.sh leaves garbage on 
some linux systems
Reviewed-by: chegar

! test/sun/net/www/protocol/file/DirPermissionDenied.sh



Re: Socket InputStream.available may return a positive value after shutdown

2011-08-12 Thread Chris Hegarty

On 11/08/2011 19:31, Michael McMahon wrote:

On 11/08/11 17:27, Alan Bateman wrote:

Chris Hegarty wrote:

Here is a first stab at fixing this issue.

  http://cr.openjdk.java.net/~chegar/7014860/webrev.00/webrev/

-Chris.
The spec clarification seems reasonable to me. Small typo "the 
streams available method" to "the stream's available method".


Good to see the NIO socket adapter included in the test. One comment 
on the test is that the Thread.dumpStack is a bit odd. It might be 
better to pass in a test name into the test method and have that 
printed by the failure message.


-Alan.

Just wondering what the motivation for changing this is? I can see the 
logic in the change
all right, but has anyone actually encountered this problem (of an 
inconsistency
between InputStream.available() and the number of bytes that can be 
returned)?


This fix gives us consistent behavior across all platforms, and 
clarifies the spec so that users know what to expect. Currently the 
behavior on Linux and Windows is to return the amount of unattainable 
data in the socket buffer. Solaris returns 0.


We have two bugs in the bug database (that I can find) for this:
  6726928: SocketInputStream.available() method does not return 0 when 
it reaches end of file on Linux
  7014860: Socket.getInputStream().available() not clear for case that 
connection is shutdown for reading


CR 7014860 is the bug being used to fix this issue.

-Chris.




- Michael


Re: code review request: 7078355: sun/net/www/protocol/file/DirPermissionDenied.sh leaves garbage on some linux systems

2011-08-12 Thread Chris Hegarty

Unusual, but I have not problem with this. Thanks for fixing it.

-Chris.

On 12/08/2011 07:56, Weijun Wang wrote:

CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7078355
webrev: http://cr.openjdk.java.net/~weijun/7078355/webrev.00/

Evaluation:

It seems on this system, being an owner of a directory does not 
automatically grants a user every privileged action on it. A chmod is 
still needed.


Description:

sun/net/www/protocol/file/DirPermissionDenied.sh has these lines:

   mkdir -p ${TESTDIR}
   chmod 333 ${TESTDIR}
   ...
   rm -rf ${TESTDIR}

On one of SQE's test machines the "rm -rf" fails saying "cannot open 
directory...: Permission denied". The machine is a --


$ uname -a
Linux sc14160057 2.6.18-238.0.0.0.1.el5xen #1 SMP Tue Jan 4 07:38:47 
EST 2011 i686 i686 i386 GNU/Linux

$ arch
i686
$ cat /etc/redhat-release
Red Hat Enterprise Linux Server release 5.6 (Tikanga)

It seems this system needs a read access to rm, even if called by the 
owner.


The test runs fine on other systems.

Thanks
Max