hg: jdk8/tl/jdk: 7198988: re-order paramaters for Collision.java @run
Changeset: e20a2e6a92f7 Author:mduigou Date: 2012-09-17 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e20a2e6a92f7 7198988: re-order paramaters for Collision.java @run Reviewed-by: alanb ! test/java/util/Map/Collisions.java
Re: Indenting code?
Paul, On 2012-09-17 17:52, Paul Sandoz wrote: > The solution to that is to re-format all JDK source code using a tool > and commit independent of any fixes, i bet the NBs formatter could be > extracted for command line operation. Netbeans formatter is OK to do simple job why editing, but it couldn't be used as a standalone tool. There are plenty of separate tools, so someone have to invest time to evaluate some of these tools, choose one and write config that mimic netbeans settings. > FWIW i really don't care about what the style would be as long as it > is not equivalent to a Huggy Bear sofa so garish as to require one to > wear peril sensitive sunglasses. Personally, I also don't think that the coding style is important. It's important to have the style common one over all code - which one doesn't really matter. -Dmitry -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...
Re: Indenting code?
On Sep 14, 2012, at 1:20 PM, Alan Bateman wrote:
> On 14/09/2012 01:21, Brad Wetmore wrote:
>> Netbean's automatic formatting does a pretty good job with new code.
>> However, I think the general advice is to not change existing code just
>> because. When you're dealing with multiple release families, it makes the
>> merges much more difficult.
>>
>> Brad
> One think that Paul Sandoz suggested recently is that we should have a NB
> template that folks can use to avoid some discussions/debates on styles.
+1 i.e. make producing and reviewing code easier.
> It would be great for someone to run with that, the hard part is of course
> that it will be impossible to get agreement. Personally I find NB's defaults
> okay but there are several cases where its indenting is horrible.
>
> Anyway, the main advice I think is to keep things locally consistent where
> possible. Also major refactoring or formatting in a bug fix is a royal pain
> for reviewers.
>
The solution to that is to re-format all JDK source code using a tool and
commit independent of any fixes, i bet the NBs formatter could be extracted for
command line operation.
IMHO it requires a benevolent dictator to decide on the exact formatting rules,
since agreement is unlikely to be reached and much more heat than light will
ever come from such discussions about where to place a '{'.
FWIW i really don't care about what the style would be as long as it is not
equivalent to a Huggy Bear sofa so garish as to require one to wear peril
sensitive sunglasses.
Paul.
hg: jdk8/tl/jdk: 7198849: Make javax/management/remote/mandatory/notif/ListenerScaleTest.java less timing sensitive
Changeset: 8a454e92aaf1 Author:sla Date: 2012-09-17 12:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a454e92aaf1 7198849: Make javax/management/remote/mandatory/notif/ListenerScaleTest.java less timing sensitive Reviewed-by: alanb ! test/javax/management/remote/mandatory/notif/ListenerScaleTest.java
hg: jdk8/tl/jdk: 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
Changeset: f56f85040c58 Author:weijun Date: 2012-09-17 18:19 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f56f85040c58 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh
hg: jdk8/tl/jdk: 7198846: Add javax/management/remote/mandatory/notif/DiffHBTest.java to ProblemList.txt
Changeset: 39e97f68fa8c Author:sla Date: 2012-09-17 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39e97f68fa8c 7198846: Add javax/management/remote/mandatory/notif/DiffHBTest.java to ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt
hg: jdk8/tl/jdk: 7198205: CloseTest fails on mac
Changeset: 0c3b0a82c4fc Author:weijun Date: 2012-09-17 17:19 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3b0a82c4fc 7198205: CloseTest fails on mac Reviewed-by: alanb, chegar, michaelm ! test/ProblemList.txt ! test/java/net/URLClassLoader/closetest/CloseTest.java
