Change to: ./src/solaris/native/java/net/PlainDatagramSocketImpl.c
Greetings: I'm proposing the following change: http://cr.openjdk.java.net/~khazra/john/8000206/webrev.00/ because it simplifies the code by eliminating an unnecessary union data structure. This change eliminates a false positive from our static code analyzer: parfait. This modification doesn't change any of the externally-visible behavior in the procedure. I look forward to your comments and suggestions. Thanks! John Zavgren john.zavg...@oracle.com
Re: Change to: ./src/solaris/native/java/net/PlainDatagramSocketImpl.c
John, Looks good for me. -Dmitry On 2012-10-19 00:59, John Zavgren wrote: Greetings: I'm proposing the following change: http://cr.openjdk.java.net/~khazra/john/8000206/webrev.00/ because it simplifies the code by eliminating an unnecessary union data structure. This change eliminates a false positive from our static code analyzer: parfait. This modification doesn't change any of the externally-visible behavior in the procedure. I look forward to your comments and suggestions. Thanks! John Zavgren john.zavg...@oracle.com -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...
Re: Change to: ./src/solaris/native/java/net/PlainDatagramSocketImpl.c
Hi John, This change looks good to me. Thanks, - Kurchi On 18.10.2012 14:18, Dmitry Samersoff wrote: John, Looks good for me. -Dmitry On 2012-10-19 00:59, John Zavgren wrote: Greetings: I'm proposing the following change: http://cr.openjdk.java.net/~khazra/john/8000206/webrev.00/ because it simplifies the code by eliminating an unnecessary union data structure. This change eliminates a false positive from our static code analyzer: parfait. This modification doesn't change any of the externally-visible behavior in the procedure. I look forward to your comments and suggestions. Thanks! John Zavgren john.zavg...@oracle.com -- -Kurchi
