tl forest update
Sorry for the wide distribution but you all see the push messages anyway. I've just pushed a coordinated set of changes to the top-level, langtools and jdk repos in the tl forest. If you use tl you will need to ensure that you update all of these repos to ensure they are in sync. Thanks, David
hg: jdk8/tl/langtools: 8009429: Miscellaneous profiles cleanup
Changeset: 82dc1e827c2a Author:dholmes Date: 2013-03-14 01:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/82dc1e827c2a 8009429: Miscellaneous profiles cleanup Reviewed-by: jjg, alanb ! src/share/classes/com/sun/tools/javac/sym/Profiles.java
hg: jdk8/tl/jdk: 8009429: Miscellaneous profiles cleanup; ...
Changeset: 41289b4a1819 Author:dholmes Date: 2013-03-14 01:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41289b4a1819 8009429: Miscellaneous profiles cleanup 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj ! makefiles/CreateJars.gmk ! makefiles/ProfileNames.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt
hg: jdk8/tl: 8009428: Revert changes to $ substitution performed as part of nashorn integration
Changeset: 19a59a13b3ef Author:dholmes Date: 2013-03-14 01:41 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/19a59a13b3ef 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj ! common/makefiles/MakeBase.gmk
hg: jdk8/tl/jdk: 8009650: HttpClient available() check throws SocketException when connection has been closed
Changeset: f5c85c0a9af0 Author:robm Date: 2013-03-14 00:21 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5c85c0a9af0 8009650: HttpClient available() check throws SocketException when connection has been closed Reviewed-by: chegar, khazra, dsamersoff Contributed-by: sdoug...@redhat.com ! src/share/classes/sun/net/www/http/HttpClient.java + test/sun/net/www/http/HttpClient/IsAvailable.java
hg: jdk8/tl/jdk: 8001334: Remove use of JVM_* functions from java.io code
Changeset: ef0c60b93a17 Author:dxu Date: 2013-03-13 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef0c60b93a17 8001334: Remove use of JVM_* functions from java.io code Summary: Replace JVM_* functions with direct system calls in java io area Reviewed-by: alanb, uta, martin ! make/java/nio/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/native/java/io/ObjectOutputStream.c ! src/share/native/java/io/io_util.c ! src/share/native/java/io/io_util.h ! src/solaris/native/common/jdk_util_md.h ! src/solaris/native/java/io/FileDescriptor_md.c ! src/solaris/native/java/io/UnixFileSystem_md.c ! src/solaris/native/java/io/io_util_md.c ! src/solaris/native/java/io/io_util_md.h ! src/windows/native/common/jdk_util_md.h ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h
hg: jdk8/tl/jdk: 8002070: Remove the stack search for a resource bundle for Logger to use
Changeset: 94335b6ffb32 Author:jgish Date: 2013-03-13 11:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94335b6ffb32 8002070: Remove the stack search for a resource bundle for Logger to use Summary: The fragile, vulnerable, stack crawling has been eliminated from findResourceBundle(String) Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/LoggerResourceBundleRace.java
Re: Request for review: 8009650 - HttpClient available() check throws SocketException when connection has been closed
Thank you Rob.
-Chris
On 13 Mar 2013, at 18:02, Rob McKenna wrote:
> Thanks Kurchi, Chris, Dmitry,
>
> I'm planning to fix that testcase and to make the logger final before
> integration.
>
>-Rob
>
> On 13/03/13 17:55, Kurchi Hazra wrote:
>> I looked at the source code changes, and it looks good.
>>
>> Thanks,
>> - Kurchi
>>
>>
>> On 3/13/2013 7:42 AM, Chris Hegarty wrote:
>>> The source code changes look fine to me.
>>>
>>> I'm not sure why you enabled a security manager in the test. I don't think
>>> that it needs one. You can remove the explicit setting of the SM from the
>>> test code, remove the policy file, and the also the jtreg policy tag.
>>> Otherwise looks fine.
>>>
>>> -Chris.
>>>
>>> On 13/03/2013 12:53, Dmitry Samersoff wrote:
Rob,
Looks good for me.
-Dmitry
On 2013-03-13 04:35, Rob McKenna wrote:
> Hi folks,
>
> New webrev at:
>
> http://cr.openjdk.java.net/~robm/8009650/webrev.02/
>
> Apologies for the delay.
>
> -Rob
>
> On 07/03/13 23:19, Rob McKenna wrote:
>> Ah, I see what you mean. Can do.
>>
>> -Rob
>>
>> On 07/03/13 23:13, Dmitry Samersoff wrote:
>>> Rob,
>>>
>>> Sorry for not being clean enough. We have repeated pattern:
>>>
>>> if (logger.isLoggable(PlatformLogger.FINEST)) {
>>> logger.finest("HttpClient.available(): " + msg
>>> }
>>>
>>> so it makes code better readable if we can put it to some common place.
>>>
>>> -Dmitry
>>>
>>> On 2013-03-08 02:31, Rob McKenna wrote:
Hi Dmitry,
I'm not 100% sure what you mean by duplication, the exceptions and
their
messages are distinct. I think it would be best to keep it that way.
-Rob
On 07/03/13 22:00, Dmitry Samersoff wrote:
> Rob,
>
> Is it possible to avoid code duplication?
>
> i.e. do something like this:
>
> int r;
>
> try {
> ...
> } catch (SocketException e) {
> // Comments goes here
> r = -1
> }
>
> if (r == -1){
> if (logger. ...
> available = false;
> }
>
> return available;
>
> -Dmitry
>
>
> On 2013-03-07 20:18, Rob McKenna wrote:
>> Hi folks,
>>
>> This is a slight alteration of the fix contributed by Stuart Douglas.
>> This fix deals with a SocketException caused by getSoTimeout() on a
>> closed connection.
>>
>> http://cr.openjdk.java.net/~robm/8009650/webrev.01/
>>
>> -Rob
>
hg: jdk8/tl/jdk: 8009751: (se) Selector spin when select, close and interestOps(0) invoked at same time (lnx)
Changeset: e33cbbe21419 Author:alanb Date: 2013-03-13 17:58 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e33cbbe21419 8009751: (se) Selector spin when select, close and interestOps(0) invoked at same time (lnx) Reviewed-by: zhouyx, chegar, robm ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java
Re: Request for review: 8009650 - HttpClient available() check throws SocketException when connection has been closed
Thanks Kurchi, Chris, Dmitry,
I'm planning to fix that testcase and to make the logger final before
integration.
-Rob
On 13/03/13 17:55, Kurchi Hazra wrote:
I looked at the source code changes, and it looks good.
Thanks,
- Kurchi
On 3/13/2013 7:42 AM, Chris Hegarty wrote:
The source code changes look fine to me.
I'm not sure why you enabled a security manager in the test. I don't
think that it needs one. You can remove the explicit setting of the
SM from the test code, remove the policy file, and the also the jtreg
policy tag. Otherwise looks fine.
-Chris.
On 13/03/2013 12:53, Dmitry Samersoff wrote:
Rob,
Looks good for me.
-Dmitry
On 2013-03-13 04:35, Rob McKenna wrote:
Hi folks,
New webrev at:
http://cr.openjdk.java.net/~robm/8009650/webrev.02/
Apologies for the delay.
-Rob
On 07/03/13 23:19, Rob McKenna wrote:
Ah, I see what you mean. Can do.
-Rob
On 07/03/13 23:13, Dmitry Samersoff wrote:
Rob,
Sorry for not being clean enough. We have repeated pattern:
if (logger.isLoggable(PlatformLogger.FINEST)) {
logger.finest("HttpClient.available(): " + msg
}
so it makes code better readable if we can put it to some common
place.
-Dmitry
On 2013-03-08 02:31, Rob McKenna wrote:
Hi Dmitry,
I'm not 100% sure what you mean by duplication, the exceptions and
their
messages are distinct. I think it would be best to keep it that
way.
-Rob
On 07/03/13 22:00, Dmitry Samersoff wrote:
Rob,
Is it possible to avoid code duplication?
i.e. do something like this:
int r;
try {
...
} catch (SocketException e) {
// Comments goes here
r = -1
}
if (r == -1){
if (logger. ...
available = false;
}
return available;
-Dmitry
On 2013-03-07 20:18, Rob McKenna wrote:
Hi folks,
This is a slight alteration of the fix contributed by Stuart
Douglas.
This fix deals with a SocketException caused by getSoTimeout()
on a
closed connection.
http://cr.openjdk.java.net/~robm/8009650/webrev.01/
-Rob
Re: Request for review: 8009650 - HttpClient available() check throws SocketException when connection has been closed
I looked at the source code changes, and it looks good.
Thanks,
- Kurchi
On 3/13/2013 7:42 AM, Chris Hegarty wrote:
The source code changes look fine to me.
I'm not sure why you enabled a security manager in the test. I don't
think that it needs one. You can remove the explicit setting of the SM
from the test code, remove the policy file, and the also the jtreg
policy tag. Otherwise looks fine.
-Chris.
On 13/03/2013 12:53, Dmitry Samersoff wrote:
Rob,
Looks good for me.
-Dmitry
On 2013-03-13 04:35, Rob McKenna wrote:
Hi folks,
New webrev at:
http://cr.openjdk.java.net/~robm/8009650/webrev.02/
Apologies for the delay.
-Rob
On 07/03/13 23:19, Rob McKenna wrote:
Ah, I see what you mean. Can do.
-Rob
On 07/03/13 23:13, Dmitry Samersoff wrote:
Rob,
Sorry for not being clean enough. We have repeated pattern:
if (logger.isLoggable(PlatformLogger.FINEST)) {
logger.finest("HttpClient.available(): " + msg
}
so it makes code better readable if we can put it to some common
place.
-Dmitry
On 2013-03-08 02:31, Rob McKenna wrote:
Hi Dmitry,
I'm not 100% sure what you mean by duplication, the exceptions and
their
messages are distinct. I think it would be best to keep it that way.
-Rob
On 07/03/13 22:00, Dmitry Samersoff wrote:
Rob,
Is it possible to avoid code duplication?
i.e. do something like this:
int r;
try {
...
} catch (SocketException e) {
// Comments goes here
r = -1
}
if (r == -1){
if (logger. ...
available = false;
}
return available;
-Dmitry
On 2013-03-07 20:18, Rob McKenna wrote:
Hi folks,
This is a slight alteration of the fix contributed by Stuart
Douglas.
This fix deals with a SocketException caused by getSoTimeout()
on a
closed connection.
http://cr.openjdk.java.net/~robm/8009650/webrev.01/
-Rob
--
-Kurchi
Re: Request for review: 8009650 - HttpClient available() check throws SocketException when connection has been closed
The source code changes look fine to me.
I'm not sure why you enabled a security manager in the test. I don't
think that it needs one. You can remove the explicit setting of the SM
from the test code, remove the policy file, and the also the jtreg
policy tag. Otherwise looks fine.
-Chris.
On 13/03/2013 12:53, Dmitry Samersoff wrote:
Rob,
Looks good for me.
-Dmitry
On 2013-03-13 04:35, Rob McKenna wrote:
Hi folks,
New webrev at:
http://cr.openjdk.java.net/~robm/8009650/webrev.02/
Apologies for the delay.
-Rob
On 07/03/13 23:19, Rob McKenna wrote:
Ah, I see what you mean. Can do.
-Rob
On 07/03/13 23:13, Dmitry Samersoff wrote:
Rob,
Sorry for not being clean enough. We have repeated pattern:
if (logger.isLoggable(PlatformLogger.FINEST)) {
logger.finest("HttpClient.available(): " + msg
}
so it makes code better readable if we can put it to some common place.
-Dmitry
On 2013-03-08 02:31, Rob McKenna wrote:
Hi Dmitry,
I'm not 100% sure what you mean by duplication, the exceptions and
their
messages are distinct. I think it would be best to keep it that way.
-Rob
On 07/03/13 22:00, Dmitry Samersoff wrote:
Rob,
Is it possible to avoid code duplication?
i.e. do something like this:
int r;
try {
...
} catch (SocketException e) {
// Comments goes here
r = -1
}
if (r == -1){
if (logger. ...
available = false;
}
return available;
-Dmitry
On 2013-03-07 20:18, Rob McKenna wrote:
Hi folks,
This is a slight alteration of the fix contributed by Stuart Douglas.
This fix deals with a SocketException caused by getSoTimeout() on a
closed connection.
http://cr.openjdk.java.net/~robm/8009650/webrev.01/
-Rob
Re: Request for review: 8009650 - HttpClient available() check throws SocketException when connection has been closed
Rob,
Looks good for me.
-Dmitry
On 2013-03-13 04:35, Rob McKenna wrote:
> Hi folks,
>
> New webrev at:
>
> http://cr.openjdk.java.net/~robm/8009650/webrev.02/
>
> Apologies for the delay.
>
> -Rob
>
> On 07/03/13 23:19, Rob McKenna wrote:
>> Ah, I see what you mean. Can do.
>>
>> -Rob
>>
>> On 07/03/13 23:13, Dmitry Samersoff wrote:
>>> Rob,
>>>
>>> Sorry for not being clean enough. We have repeated pattern:
>>>
>>> if (logger.isLoggable(PlatformLogger.FINEST)) {
>>> logger.finest("HttpClient.available(): " + msg
>>> }
>>>
>>> so it makes code better readable if we can put it to some common place.
>>>
>>> -Dmitry
>>>
>>> On 2013-03-08 02:31, Rob McKenna wrote:
Hi Dmitry,
I'm not 100% sure what you mean by duplication, the exceptions and
their
messages are distinct. I think it would be best to keep it that way.
-Rob
On 07/03/13 22:00, Dmitry Samersoff wrote:
> Rob,
>
> Is it possible to avoid code duplication?
>
> i.e. do something like this:
>
> int r;
>
> try {
> ...
> } catch (SocketException e) {
> // Comments goes here
> r = -1
> }
>
> if (r == -1){
> if (logger. ...
> available = false;
> }
>
> return available;
>
> -Dmitry
>
>
> On 2013-03-07 20:18, Rob McKenna wrote:
>> Hi folks,
>>
>> This is a slight alteration of the fix contributed by Stuart Douglas.
>> This fix deals with a SocketException caused by getSoTimeout() on a
>> closed connection.
>>
>> http://cr.openjdk.java.net/~robm/8009650/webrev.01/
>>
>> -Rob
>>>
>>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
