Re: DefaultProxySelector socks override
On Apr 2, 5:26pm, kurchi.subhra.ha...@oracle.com (Kurchi Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Also, I should have clarified why I am changing the test. Since now we | are defining the socks non-proxy property - | localhost gets added to the list of non-proxy hosts by default in our | implementation (as is the case with other protocols | too). So "localhost" no more acts as the socksProxyHost. Ah, ok. Makes sense; still the change in the test does not appear to do anything different?!? Am I missing something? christos
Re: DefaultProxySelector socks override
On Apr 2, 5:13pm, kurchi.subhra.ha...@oracle.com (Kurchi Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Hi Christos/Chris, | | Here is a webrev for this change: | http://cr.openjdk.java.net/~khazra/5001942/webrev.00/ LGTM, for DefaultProxySelector.java. The SocksProxyVersion.java change should be under a different commit message and revision since it does not have anything to do with socks; here you are just factoring out the "localhost" name to address resolution, which is nice and worthwhile, but not for the same commit. Thanks, christos
Re: DefaultProxySelector socks override
Also, I should have clarified why I am changing the test. Since now we are defining the socks non-proxy property - localhost gets added to the list of non-proxy hosts by default in our implementation (as is the case with other protocols too). So "localhost" no more acts as the socksProxyHost. On 4/2/2013 5:13 PM, Kurchi Hazra wrote: Hi Christos/Chris, Here is a webrev for this change: http://cr.openjdk.java.net/~khazra/5001942/webrev.00/ Thanks, - Kurchi On 3/27/2013 10:49 AM, chris...@zoulas.com wrote: On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re: DefaultProxySelector socks override | On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: | > | > Sure, I just requested a subscription to net-dev so I might not see the | > first few messages. To clarify: | > | > 1. I will add socks.proxyHost and socks.proxyPort for consistency | >with the other protocols, leaving as is socksProxyHost and | >socksProxyPort for compatibility. | > 2. I will add socks.nonProxyHosts and not socksNonProxyHosts. | > | > Is that what you had in mind? | | Re-checking the code I take back my previous comment. We already have | | socksProxyHost, socksProxyPort, socksProxyVersion | | so your original proposal of 'socksNonProxyHosts' is probably best, and | consistent with existing properties. I concur. Nothing for me to do :-) Best, christos -- -Kurchi
Re: DefaultProxySelector socks override
Hi Christos/Chris, Here is a webrev for this change: http://cr.openjdk.java.net/~khazra/5001942/webrev.00/ Thanks, - Kurchi On 3/27/2013 10:49 AM, chris...@zoulas.com wrote: On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re: DefaultProxySelector socks override | On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: | > | > Sure, I just requested a subscription to net-dev so I might not see the | > first few messages. To clarify: | > | > 1. I will add socks.proxyHost and socks.proxyPort for consistency | > with the other protocols, leaving as is socksProxyHost and | > socksProxyPort for compatibility. | > 2. I will add socks.nonProxyHosts and not socksNonProxyHosts. | > | > Is that what you had in mind? | | Re-checking the code I take back my previous comment. We already have | | socksProxyHost, socksProxyPort, socksProxyVersion | | so your original proposal of 'socksNonProxyHosts' is probably best, and | consistent with existing properties. I concur. Nothing for me to do :-) Best, christos -- -Kurchi
hg: jdk8/tl/jdk: 8004979: java.lang.reflect.Modifier.toString should include "default"
Changeset: b4f68aca1000 Author:darcy Date: 2013-04-02 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4f68aca1000 8004979: java.lang.reflect.Modifier.toString should include "default" Reviewed-by: mduigou ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Modifier.java ! test/java/lang/reflect/Method/GenericStringTest.java
hg: jdk8/tl: 8011342: hgforest.sh : 'python --version' not supported on older python
Changeset: 7320922b694e Author:mduigou Date: 2013-04-02 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7320922b694e 8011342: hgforest.sh : 'python --version' not supported on older python Reviewed-by: wetmore ! common/bin/hgforest.sh
hg: jdk8/tl/jdk: 18 new changesets
Changeset: 624bcb480006 Author:omajid Date: 2013-03-18 10:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624bcb480006 8010030: Allow configure to detect if EC implementation is present Reviewed-by: andrew, dholmes ! makefiles/CompileNativeLibraries.gmk Changeset: cdcd4512c6f1 Author:katleman Date: 2013-03-21 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdcd4512c6f1 Added tag jdk8-b82 for changeset 624bcb480006 ! .hgtags Changeset: 6782f2c46bca Author:wetmore Date: 2013-03-21 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6782f2c46bca 8009517: new code changes causing errors in old build (-Werror) environment Reviewed-by: mduigou ! make/com/sun/org/apache/xml/Makefile ! make/javax/others/Makefile Changeset: ac519af51769 Author:dcherepanov Date: 2013-03-27 08:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac519af51769 Merge Changeset: 8cc500af2454 Author:katleman Date: 2013-03-28 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cc500af2454 Added tag jdk8-b83 for changeset ac519af51769 ! .hgtags Changeset: 07acfb90700b Author:malenkov Date: 2013-03-14 12:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07acfb90700b 8000183: 7163696: JCK Swing interactive test JScrollBarTest0013 fails with Nimbus and GTK L&Fs Reviewed-by: alexsch, serb ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java + test/javax/swing/JScrollBar/7163696/Test7163696.java Changeset: d4e1c5803a59 Author:alexsch Date: 2013-03-15 17:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4e1c5803a59 8009221: [macosx] Two closed/javax/swing regression tests fail on MacOSX. Reviewed-by: serb, alexp + test/javax/swing/JMenu/4515762/bug4515762.java + test/javax/swing/JRootPane/4670486/bug4670486.java ! test/javax/swing/regtesthelpers/Util.java Changeset: 2725b8a783e7 Author:lana Date: 2013-03-15 16:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2725b8a783e7 Merge - make/tools/javazic/Makefile - make/tools/src/build/tools/javazic/BackEnd.java - make/tools/src/build/tools/javazic/Checksum.java - make/tools/src/build/tools/javazic/DayOfWeek.java - make/tools/src/build/tools/javazic/Gen.java - make/tools/src/build/tools/javazic/GenDoc.java - make/tools/src/build/tools/javazic/Main.java - make/tools/src/build/tools/javazic/Mappings.java - make/tools/src/build/tools/javazic/Month.java - make/tools/src/build/tools/javazic/Rule.java - make/tools/src/build/tools/javazic/RuleDay.java - make/tools/src/build/tools/javazic/RuleRec.java - make/tools/src/build/tools/javazic/Simple.java - make/tools/src/build/tools/javazic/Time.java - make/tools/src/build/tools/javazic/Timezone.java - make/tools/src/build/tools/javazic/Zone.java - make/tools/src/build/tools/javazic/ZoneRec.java - make/tools/src/build/tools/javazic/Zoneinfo.java - src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java - src/share/classes/java/util/function/Block.java - src/share/classes/java/util/function/DoubleBlock.java - src/share/classes/java/util/function/IntBlock.java - src/share/classes/java/util/function/LongBlock.java - src/share/classes/sun/security/util/KeyLength.java - test/javax/script/RhinoExceptionTest.java Changeset: 4bf5a5a72664 Author:serb Date: 2013-03-18 22:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bf5a5a72664 8000435: [macosx] Button painting error under Java 7 on Mac Reviewed-by: denis, alexsch ! src/macosx/classes/com/apple/laf/AquaButtonBorder.java ! src/macosx/classes/com/apple/laf/AquaButtonExtendedTypes.java Changeset: af6049edac00 Author:kshefov Date: 2013-03-19 17:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af6049edac00 8009881: TEST_BUG: javax/swing/JTree/8004298/bug8004298.java should be modified Reviewed-by: serb, alexsch ! test/javax/swing/JTree/8004298/bug8004298.java Changeset: 4e15c3e56315 Author:kshefov Date: 2013-03-20 14:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4e15c3e56315 8009880: TEST_BUG: Test java/beans/Introspector/TestTypeResolver.java should be modified again Reviewed-by: malenkov, alexsch ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 87001c7bb678 Author:alitvinov Date: 2013-03-20 20:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87001c7bb678 6550588: java.awt.Desktop cannot open file with Windows UNC filename Reviewed-by: art, uta ! src/windows/classes/sun/awt/windows/WDesktopPeer.java ! src/windows/native/sun/windows/awt_Desktop.cpp + test/java/awt/Desktop/OpenByUNCPathNameTest/OpenByUNCPathNameTest.java Changeset: ef948ef2b58f Author:alexsch Date: 2013-03-21 16:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef948ef2b58f 8007146: [macosx] Setting a display mode crashes JDK under VNC Reviewed-by: serb ! src/macosx/native/sun/aw
hg: jdk8/tl/jaxws: 4 new changesets
Changeset: a1dcc0d83da1 Author:katleman Date: 2013-03-21 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a1dcc0d83da1 Added tag jdk8-b82 for changeset d8d8032d02d7 ! .hgtags Changeset: 54c29eb352e7 Author:katleman Date: 2013-03-28 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/54c29eb352e7 Added tag jdk8-b83 for changeset a1dcc0d83da1 ! .hgtags Changeset: 2476e1f2afa5 Author:lana Date: 2013-03-26 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/2476e1f2afa5 Merge Changeset: 5773e3fc8380 Author:lana Date: 2013-04-01 21:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/5773e3fc8380 Merge
hg: jdk8/tl/hotspot: 53 new changesets
Changeset: 4f7380dca47e Author:katleman Date: 2013-03-21 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4f7380dca47e Added tag jdk8-b82 for changeset 3db4ab0e12f4 ! .hgtags Changeset: 7ae04e71af90 Author:amurillo Date: 2013-03-15 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ae04e71af90 8010105: new hotspot build - hs25-b24 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 39432a1cefdd Author:minqi Date: 2013-03-14 00:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/39432a1cefdd 8003348: SA can not read core file on OS Summary: Macosx uses Mach-O file format for binary files, not ELF format. Currently SA works on core files on other platforms, t his change enables SA work on core file generated on Darwin. Reviewed-by: sla, sspitsyn Contributed-by: yumin...@oracle.com ! agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/os/bsd/Makefile ! agent/src/os/bsd/libproc.h ! agent/src/os/bsd/libproc_impl.c ! agent/src/os/bsd/libproc_impl.h ! agent/src/os/bsd/ps_core.c ! agent/src/os/bsd/symtab.c ! agent/src/os/bsd/symtab.h ! agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java ! agent/src/share/native/sadis.c ! make/bsd/makefiles/saproc.make Changeset: 1fc4d4768b90 Author:coleenp Date: 2013-03-15 17:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1fc4d4768b90 8007725: NPG: Klass::restore_unshareable_info() triggers assert(k->java_mirror() == NULL) Summary: Check for exception during SystemDictionary::resolve_instance_class_or_null() and clean up. Reviewed-by: coleenp, acorn, hseigel, minqi Contributed-by: ioi@oracle.com ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/method.cpp Changeset: 82f49e8e2c28 Author:zgu Date: 2013-03-15 11:53 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/82f49e8e2c28 8009614: nsk/split_verifier/stress/ifelse/ifelse002_30 fails with 'assert((size & (granularity - 1)) == 0) failed: size not aligned to os::vm_allocation_granularity() Summary: Align up vm allocation size to os defined granularity Reviewed-by: dholmes, coleenp ! src/share/vm/memory/metaspace.cpp Changeset: 919a5f9f36a9 Author:zgu Date: 2013-03-15 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/919a5f9f36a9 Merge Changeset: 82ab039b9680 Author:dcubed Date: 2013-03-17 08:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/82ab039b9680 Merge ! src/share/vm/memory/metaspace.cpp Changeset: 117bb0519114 Author:sla Date: 2013-03-19 13:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/117bb0519114 8009456: SA: typeToVtbl of BasicTypeDataBase should not be static Reviewed-by: coleenp, sla Contributed-by: yunda@taobao.com ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Changeset: 686916dc0439 Author:sla Date: 2013-03-19 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/686916dc0439 8009457: SA: A small fix on "scanoops" command in CLHSDB Reviewed-by: sla, coleenp, kmo Contributed-by: yunda@taobao.com ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Changeset: 9960dce2024f Author:kmo Date: 2013-03-14 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9960dce2024f 8010116: Abstract_VM_Version::internal_vm_info_string() should recognize VS2010 and VS2012 Summary: add cases for _MSC_VER == 1600 and 1700 Reviewed-by: zgu ! src/share/vm/runtime/vm_version.cpp Changeset: a40807924950 Author:kmo Date: 2013-03-14 16:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a40807924950 Merge Changeset: f3d486462d36 Author:morris Date: 2013-03-15 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f3d486462d36 Merge Changeset: 96ef09c26978 Author:morris Date: 2013-03-16 07:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96ef09c26978 8009166: [parfait] Null pointer deference in hotspot/src/share/vm/opto/type.cpp Summary: add guarantee() to as_instance_type() Reviewed-by: kvn, twisti ! src/share/vm/opto/type.cpp Changeset: 8b4ce9870fd6 Author:morris Date: 2013-03-16 07:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl
hg: jdk8/tl/langtools: 5 new changesets
Changeset: 22ba3f92d4ae Author:katleman Date: 2013-03-21 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/22ba3f92d4ae Added tag jdk8-b82 for changeset 825da6847791 ! .hgtags Changeset: 35cef52b0023 Author:katleman Date: 2013-03-28 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/35cef52b0023 Added tag jdk8-b83 for changeset 22ba3f92d4ae ! .hgtags Changeset: 28e466e9cd34 Author:lana Date: 2013-03-26 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/28e466e9cd34 Merge - src/share/classes/com/sun/tools/javac/Server.java - src/share/classes/com/sun/tools/jdeps/resources/jdk.properties - src/share/classes/javax/lang/model/type/AnnotatedType.java - test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java Changeset: cfb65ca92082 Author:lana Date: 2013-04-01 21:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cfb65ca92082 Merge - src/share/classes/com/sun/tools/javac/Server.java - src/share/classes/com/sun/tools/jdeps/resources/jdk.properties - src/share/classes/javax/lang/model/type/AnnotatedType.java - test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java Changeset: 46d2f144ebbd Author:lana Date: 2013-04-02 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/46d2f144ebbd Merge
hg: jdk8/tl/corba: 4 new changesets
Changeset: a45bb25a67c7 Author:katleman Date: 2013-03-21 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a45bb25a67c7 Added tag jdk8-b82 for changeset 48e1bc77004d ! .hgtags Changeset: 14f1babaf548 Author:katleman Date: 2013-03-28 10:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/14f1babaf548 Added tag jdk8-b83 for changeset a45bb25a67c7 ! .hgtags Changeset: 7d7a009d5fbd Author:lana Date: 2013-03-26 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7d7a009d5fbd Merge Changeset: 928f8b888deb Author:lana Date: 2013-04-01 21:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/928f8b888deb Merge
Re: RFR: JDK-8007373 Inet6Address serialization incompatibility
On 2 Apr 2013, at 19:39, Alan Bateman wrote: > On 02/04/2013 13:42, Chris Hegarty wrote: >> >> I believe this option should work too. But it is really a trade off between >> simplicity and the more complicated serialPersistentFields. I'm ok with >> either. >> >> I just wanted to mention, that I inadvertently removed this field as >> superfluous cleanup when fixing another bug. Whether the field exists in the >> class, or just the serial form, does not impact on the original fix. The >> problem is that this private field was never needed in the first place, and >> also if added should have been transient. > Yes, it's a bit of a trade-off but I brought it up because I wasn't sure if > it has been looked into. I'm okay with either approach. Thanks Alan, -Chris
Re: RFR: JDK-8007373 Inet6Address serialization incompatibility
On 02/04/2013 13:42, Chris Hegarty wrote: I believe this option should work too. But it is really a trade off between simplicity and the more complicated serialPersistentFields. I'm ok with either. I just wanted to mention, that I inadvertently removed this field as superfluous cleanup when fixing another bug. Whether the field exists in the class, or just the serial form, does not impact on the original fix. The problem is that this private field was never needed in the first place, and also if added should have been transient. Yes, it's a bit of a trade-off but I brought it up because I wasn't sure if it has been looked into. I'm okay with either approach. -Alan
hg: jdk8/tl/jdk: 8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding; ...
Changeset: e6c3b8e74e50 Author:sherman Date: 2013-04-02 10:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6c3b8e74e50 8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding 8008925: Base64.getMimeDecoder().decode() does not ignore padding chars Summary: updated implementation and spec for corner cases. Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java
Re: RFR: JDK-8007373 Inet6Address serialization incompatibility
On 04/02/2013 12:38 PM, Alan Bateman wrote: On 31/03/2013 15:16, Chris Hegarty wrote: Thanks for taking this Mark. It was my change that introduced this incompatibility. The source changes look fine to me. In fact, the removal of scope_ifname_set was not necessary for the original fix, just "bad" clean up. Also, there is no need to reset its default value where declared. The test needs the usual GPL header. We never call exit from a test, but it looks like this only possible during generation of the static byte arrays. -Chris I'm curious if it is really necessary to re-introduce this field. Would there be any issues if it were just remained in the serialized form and written as true when scope_ifname is not null? If there are any issues I believe this option should work too. But it is really a trade off between simplicity and the more complicated serialPersistentFields. I'm ok with either. I just wanted to mention, that I inadvertently removed this field as superfluous cleanup when fixing another bug. Whether the field exists in the class, or just the serial form, does not impact on the original fix. The problem is that this private field was never needed in the first place, and also if added should have been transient. then the proposed change is okay (except for a minor issue with the comment format in readObject). I don't have time to review the test but I assume you have reviewed it (it's a lot bigger than I would have expected). One comment is that there might be an opportunity to get rid of the existing Serialize test in that directory and to rename the new test. Yes, that would be nice. -Chris. -Alan.
Re: RFR: JDK-8007373 Inet6Address serialization incompatibility
On 31/03/2013 15:16, Chris Hegarty wrote: Thanks for taking this Mark. It was my change that introduced this incompatibility. The source changes look fine to me. In fact, the removal of scope_ifname_set was not necessary for the original fix, just "bad" clean up. Also, there is no need to reset its default value where declared. The test needs the usual GPL header. We never call exit from a test, but it looks like this only possible during generation of the static byte arrays. -Chris I'm curious if it is really necessary to re-introduce this field. Would there be any issues if it were just remained in the serialized form and written as true when scope_ifname is not null? If there are any issues then the proposed change is okay (except for a minor issue with the comment format in readObject). I don't have time to review the test but I assume you have reviewed it (it's a lot bigger than I would have expected). One comment is that there might be an opportunity to get rid of the existing Serialize test in that directory and to rename the new test. -Alan.
hg: jdk8/tl/jdk: 8009558: linked_md.c::dll_build_name can get stuck in an infinite loop
Changeset: f1b89d4cce82 Author:sla Date: 2013-04-02 10:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1b89d4cce82 8009558: linked_md.c::dll_build_name can get stuck in an infinite loop Reviewed-by: alanb, sspitsyn ! src/share/back/export/sys.h ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof_md.h ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c
