RFR doclint issues in java.net

[Chris Hegarty]

This is a request for review for some doclint warnings in the java.net 
package. Trivially, the list type should be left to the CSS.


Note: with these changes there are still warnings for two DatagramPacket 
constructors that are missing @throws for SocketException. I do not see 
any reason that these constructors need to throw SE, and I will file a 
separate bug to follow up.


diff -r fd1b5adcfdf0 src/share/classes/java/net/URI.java
--- a/src/share/classes/java/net/URI.java   Wed Jul 24 22:52:01 2013 
+0100
+++ b/src/share/classes/java/net/URI.java   Thu Jul 25 10:56:25 2013 
+0100

@@ -530,7 +530,7 @@ public final class URI
  * href="http://www.ietf.org/rfc/rfc2396.txt";>RFC 2396,
  * Appendix A, except for the following 
deviations: 

  *
- * 
+ * 
  *
  *An empty authority component is permitted as long as 
it is

  *   followed by a non-empty path, a query component, or a fragment
@@ -993,7 +993,7 @@ public final class URI
  *Otherwise the new URI's authority component is copied 
from

  *   this URI, and its path is computed as follows: 
  *
- *   
+ *   
  *
  *  If the given URI's path is absolute then the new 
URI's path

  * is taken from the given URI. 
@@ -1241,7 +1241,7 @@ public final class URI
  *  The host component of a URI, if defined, will have one of the
  * following forms: 
  *
- * 
+ * 
  *
  *A domain name consisting of one or more labels
  *   separated by period characters ('.'), optionally 
followed by

@@ -1495,7 +1495,7 @@ public final class URI
  *
  *  The ordering of URIs is defined as follows: 
  *
- * 
+ * 
  *
  *Two URIs with different schemes are ordered according the
  *   ordering of their schemes, without regard to case. 
@@ -1513,7 +1513,7 @@ public final class URI
  *Two hierarchical URIs with identical schemes are ordered
  *   according to the ordering of their authority components: 
  *
- *   
+ *   
  *
  *  If both authority components are server-based then 
the URIs
  * are ordered according to their user-information components; 
if these



-Chris.

Re: RFR doclint issues in java.net

[Lance Andersen - Oracle]

Good to go
On Jul 25, 2013, at 6:00 AM, Chris Hegarty wrote:

> This is a request for review for some doclint warnings in the java.net 
> package. Trivially, the list type should be left to the CSS.
> 
> Note: with these changes there are still warnings for two DatagramPacket 
> constructors that are missing @throws for SocketException. I do not see any 
> reason that these constructors need to throw SE, and I will file a separate 
> bug to follow up.
> 
> diff -r fd1b5adcfdf0 src/share/classes/java/net/URI.java
> --- a/src/share/classes/java/net/URI.java   Wed Jul 24 22:52:01 2013 +0100
> +++ b/src/share/classes/java/net/URI.java   Thu Jul 25 10:56:25 2013 +0100
> @@ -530,7 +530,7 @@ public final class URI
>  * href="http://www.ietf.org/rfc/rfc2396.txt";>RFC 2396,
>  * Appendix A, except for the following deviations: 
> 
>  *
> - * 
> + * 
>  *
>  *An empty authority component is permitted as long as it is
>  *   followed by a non-empty path, a query component, or a fragment
> @@ -993,7 +993,7 @@ public final class URI
>  *Otherwise the new URI's authority component is copied from
>  *   this URI, and its path is computed as follows: 
>  *
> - *   
> + *   
>  *
>  *  If the given URI's path is absolute then the new URI's path
>  * is taken from the given URI. 
> @@ -1241,7 +1241,7 @@ public final class URI
>  *  The host component of a URI, if defined, will have one of the
>  * following forms: 
>  *
> - * 
> + * 
>  *
>  *A domain name consisting of one or more labels
>  *   separated by period characters ('.'), optionally followed by
> @@ -1495,7 +1495,7 @@ public final class URI
>  *
>  *  The ordering of URIs is defined as follows: 
>  *
> - * 
> + * 
>  *
>  *Two URIs with different schemes are ordered according the
>  *   ordering of their schemes, without regard to case. 
> @@ -1513,7 +1513,7 @@ public final class URI
>  *Two hierarchical URIs with identical schemes are ordered
>  *   according to the ordering of their authority components: 
>  *
> - *   
> + *   
>  *
>  *  If both authority components are server-based then the URIs
>  * are ordered according to their user-information components; if 
> these
> 
> 
> -Chris.

<>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

hg: jdk8/tl/langtools: 3 new changesets

[maurizio . cimadamore]

Changeset: 3155e77d2676
Author:mcimadamore
Date:  2013-07-25 14:47 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3155e77d2676

8020804: javac crashes when speculative attribution infers intersection type 
with array component
Summary: Assertion is causing javac to crash because of lack of support for 
arrays in intersection types
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
+ test/tools/javac/lambda/8020804/T8020804.java

Changeset: b02f28bf7f1c
Author:mcimadamore
Date:  2013-07-25 14:49 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b02f28bf7f1c

8016081: field initialized with lambda in annotation types doesn't compile
Summary: check for annotation attributes should skip over synthetic methods
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Check.java
+ test/tools/javac/lambda/8016081/T8016081.java

Changeset: dae52d74c1fc
Author:mcimadamore
Date:  2013-07-25 14:51 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dae52d74c1fc

8020843: javac crashes on accessibility check with method reference with 
typevar receiver
Summary: method reference overload check doesn't walk through type-variable 
receivers
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/tools/javac/diags/examples/ReportAccessFragment.java
+ test/tools/javac/lambda/8020843/T8020843a.java
+ test/tools/javac/lambda/8020843/T8020843a.out
+ test/tools/javac/lambda/8020843/T8020843b.java
+ test/tools/javac/lambda/8020843/T8020843b.out
! test/tools/javac/lambda/MethodReference28.out

Re: RFR doclint issues in java.net

[Joe Darcy]

FWIW, I've filed a bug against doclint to allow ordered lists of the 
form 


JDK-8021324 [doclint] Doclint need not warn over use of ordered 
lists with styles


In any case, the changes below look fine to go back; if you want to 
leave the  in java.net, that would be fine by me too.


Thanks,

-Joe

On 07/25/2013 03:16 AM, Lance Andersen - Oracle wrote:

Good to go
On Jul 25, 2013, at 6:00 AM, Chris Hegarty wrote:


This is a request for review for some doclint warnings in the java.net package. 
Trivially, the list type should be left to the CSS.

Note: with these changes there are still warnings for two DatagramPacket 
constructors that are missing @throws for SocketException. I do not see any 
reason that these constructors need to throw SE, and I will file a separate bug 
to follow up.

diff -r fd1b5adcfdf0 src/share/classes/java/net/URI.java
--- a/src/share/classes/java/net/URI.java   Wed Jul 24 22:52:01 2013 +0100
+++ b/src/share/classes/java/net/URI.java   Thu Jul 25 10:56:25 2013 +0100
@@ -530,7 +530,7 @@ public final class URI
  * href="http://www.ietf.org/rfc/rfc2396.txt";>RFC 2396,
  * Appendix A, except for the following deviations: 
  *
- * 
+ * 
  *
  *An empty authority component is permitted as long as it is
  *   followed by a non-empty path, a query component, or a fragment
@@ -993,7 +993,7 @@ public final class URI
  *Otherwise the new URI's authority component is copied from
  *   this URI, and its path is computed as follows: 
  *
- *   
+ *   
  *
  *  If the given URI's path is absolute then the new URI's path
  * is taken from the given URI. 
@@ -1241,7 +1241,7 @@ public final class URI
  *  The host component of a URI, if defined, will have one of the
  * following forms: 
  *
- * 
+ * 
  *
  *A domain name consisting of one or more labels
  *   separated by period characters ('.'), optionally followed by
@@ -1495,7 +1495,7 @@ public final class URI
  *
  *  The ordering of URIs is defined as follows: 
  *
- * 
+ * 
  *
  *Two URIs with different schemes are ordered according the
  *   ordering of their schemes, without regard to case. 
@@ -1513,7 +1513,7 @@ public final class URI
  *Two hierarchical URIs with identical schemes are ordered
  *   according to the ordering of their authority components: 
  *
- *   
+ *   
  *
  *  If both authority components are server-based then the URIs
  * are ordered according to their user-information components; if these


-Chris.



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

hg: jdk8/tl/jdk: 2 new changesets

[sean . mullan]

Changeset: a834ab2c1354
Author:mullan
Date:  2013-07-25 10:58 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a834ab2c1354

8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL 
option
Reviewed-by: vinnie

! src/share/classes/java/security/cert/PKIXRevocationChecker.java
! src/share/classes/sun/security/provider/certpath/OCSP.java
! src/share/classes/sun/security/provider/certpath/OCSPResponse.java
! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java
! src/share/classes/sun/security/provider/certpath/ReverseState.java
! src/share/classes/sun/security/provider/certpath/RevocationChecker.java
! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java
! test/java/security/cert/PKIXRevocationChecker/UnitTest.java

Changeset: 22a391706a0b
Author:mullan
Date:  2013-07-25 11:09 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22a391706a0b

Merge

- make/sun/xawt/ToBin.java
- makefiles/sun/awt/X11/ToBin.java
- 
src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties
- 
src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java
- 
src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java
- 
src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java
- 
src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java
- src/share/classes/java/security/acl/package.html
- src/share/classes/java/security/cert/package.html
- src/share/classes/java/security/interfaces/package.html
- src/share/classes/java/security/package.html
- src/share/classes/java/security/spec/package.html
- src/share/classes/java/util/stream/StreamBuilder.java
- src/share/classes/javax/security/auth/callback/package.html
- src/share/classes/javax/security/auth/kerberos/package.html
- src/share/classes/javax/security/auth/login/package.html
- src/share/classes/javax/security/auth/package.html
- src/share/classes/javax/security/auth/spi/package.html
- src/share/classes/javax/security/auth/x500/package.html
- src/share/classes/javax/security/cert/package.html
- src/share/classes/javax/security/sasl/package.html
- src/share/classes/sun/misc/Hashing.java
- src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java
- src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java
! src/share/classes/sun/security/provider/certpath/RevocationChecker.java
- src/solaris/classes/sun/awt/X11/XIconInfo.java
- src/solaris/classes/sun/awt/X11/security-icon-bw16.png
- src/solaris/classes/sun/awt/X11/security-icon-bw24.png
- src/solaris/classes/sun/awt/X11/security-icon-bw32.png
- src/solaris/classes/sun/awt/X11/security-icon-bw48.png
- src/solaris/classes/sun/awt/X11/security-icon-interim16.png
- src/solaris/classes/sun/awt/X11/security-icon-interim24.png
- src/solaris/classes/sun/awt/X11/security-icon-interim32.png
- src/solaris/classes/sun/awt/X11/security-icon-interim48.png
- src/solaris/classes/sun/awt/X11/security-icon-yellow16.png
- src/solaris/classes/sun/awt/X11/security-icon-yellow24.png
- src/solaris/classes/sun/awt/X11/security-icon-yellow32.png
- src/solaris/classes/sun/awt/X11/security-icon-yellow48.png
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties
- test/java/lang/invoke/7196190/MHProxyTest.java
- test/java/util/Collections/EmptySortedSet.java
- test/java/util/Comparators/BasicTest.java
- test/sun/misc/Hashing.java
- test/sun/security/krb5/auto/ReplayCache.java

hg: jdk8/tl/jdk: 8021408: Fix misc doclint issues in java.util and java.io

[joe . darcy]

Changeset: 21120e3682ef
Author:darcy
Date:  2013-07-25 09:59 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21120e3682ef

8021408: Fix misc doclint issues in java.util and java.io
Reviewed-by: dholmes, chegar, psandoz

! src/share/classes/java/io/ObjectInputStream.java
! src/share/classes/java/io/ObjectOutputStream.java
! src/share/classes/java/util/jar/Attributes.java
! src/share/classes/java/util/jar/JarEntry.java
! src/share/classes/java/util/jar/JarFile.java
! src/share/classes/java/util/stream/StreamSupport.java

Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

[Kurchi Subhra Hazra]

Hi,

Did anyone have a chance to look at this?

Thanks,
Kurchi


On Thu, Jul 18, 2013 at 4:26 PM, Kurchi Hazra <
kurchi.subhra.ha...@oracle.com> wrote:

> Hi Michael,
>
>I added some comments as to what is the purpose of the latches and
> barriers. Those comments alongwith the
> comments describing the purpose of the handlers should make the
> synchronization logic more clear. Let me know what
> you think: 
> http://cr.openjdk.java.net/~**khazra/8017779/webrev.01/
>
> Thanks,
> Kurchi
>
> On 7/17/2013 2:07 PM, Kurchi Hazra wrote:
>
>>
>> On 7/17/2013 12:27 AM, Michael McMahon wrote:
>>
>>> On 16/07/13 20:11, Kurchi Hazra wrote:
>>>
 Hi,
  We have observed that test/java/net/Authenticator/**B4769350.java
 fails intermittently. Although not reproducible always,
 the bug could be in the test/sun/net/www/httptest library that this
 test uses. I have rewritten the test to use
 com.sun.net.httpserver instead since we anyway want to move away from
 using the httptest library.

 I have used CyclicBarriers to mimic TestHttpServer.rendezvous() and
 CountDownLatches to
 mimic TestHttpServer.**waitForCondition() and hopefully preserved the
 rest of the logic in the test.
 I have not seen the test failing after these changes.

 Bug: 
 http://bugs.sun.com/view_bug.**do?bug_id=8017779
 Webrev: 
 http://cr.openjdk.java.net/~**khazra/8017779/webrev.00/

 Thanks,
 Kurchi


>>> Kurchi,
>>>
>>> Since this is a fairly complicated test, and it's great to see it being
>>> rewritten,
>>> is there any possibility of adding some commentary that explains the
>>> purpose
>>> of the synchronization code. For instance, I can't see the purpose of
>>> the call
>>> on line 163 as it just blocks a thread that has already completed its
>>> work
>>>
>>> Michael
>>>
>>
>> Hi Michael,
>>
>>   I have just preserved whatever logic the test originally had. The
>> specific instance you point out waits
>> for the T1b() handle to be executed for case 0 before moving forward. But
>> I guess it is hard to understand in a
>> glance and I'll add some more comments and get back with a new webrev.
>>
>> Thanks,
>> Kurchi
>>
>
> --
> -Kurchi
>
>

hg: jdk8/tl/jdk: 8021417: Fix doclint issues in java.util.concurrent

[chris . hegarty]

Changeset: 690dcbaa69b7
Author:chegar
Date:  2013-07-25 19:37 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690dcbaa69b7

8021417: Fix doclint issues in java.util.concurrent
Reviewed-by: chegar, lancea
Contributed-by: Doug Lea 

! src/share/classes/java/util/concurrent/AbstractExecutorService.java
! src/share/classes/java/util/concurrent/ExecutorService.java
! src/share/classes/java/util/concurrent/Executors.java
! src/share/classes/java/util/concurrent/ForkJoinPool.java
! src/share/classes/java/util/concurrent/ForkJoinTask.java
! src/share/classes/java/util/concurrent/ScheduledExecutorService.java
! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java
! src/share/classes/java/util/concurrent/TimeUnit.java
! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java

hg: jdk8/tl/jdk: 8021421: More doclint fixes in java.net

[chris . hegarty]

Changeset: 9cd5159fa870
Author:chegar
Date:  2013-07-25 19:45 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cd5159fa870

8021421: More doclint fixes in java.net
Reviewed-by: lancea, darcy

! src/share/classes/java/net/URI.java

hg: jdk8/tl/jdk: 2 new changesets

[sean . mullan]

Changeset: 1744a32d3db3
Author:mullan
Date:  2013-07-25 20:12 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1744a32d3db3

8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo
Reviewed-by: xuelei

! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java
! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java

Changeset: 4100ab44ba4f
Author:mullan
Date:  2013-07-25 20:30 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4100ab44ba4f

Merge

hg: jdk8/tl/jdk: 8021429: Fix lint warnings in java.lang.ref

[joe . darcy]

Changeset: 86a827321c39
Author:darcy
Date:  2013-07-25 20:03 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86a827321c39

8021429: Fix lint warnings in java.lang.ref
Reviewed-by: lancea, mduigou, alanb

! src/share/classes/java/lang/ref/FinalReference.java
! src/share/classes/java/lang/ref/Finalizer.java
! src/share/classes/java/lang/ref/Reference.java
! src/share/classes/java/lang/ref/ReferenceQueue.java