Re: ProblemList updating request for JDK-7079145: java/net/ipv6tests/UdpTest.java

2013-10-24 Thread Eric Wang

Thanks Alan & Chris for review and pushing code.

-Eric
On 2013/10/24 20:59, Chris Hegarty wrote:

The changes, to remove this test from the problem list, look fine to me.

I see that JDK-7079145 has been closed. We should probably re-open it, 
and use it to push these changes.


I can sponsor this change for you.

-Chris.

On 10/24/2013 03:58 AM, Eric Wang wrote:

Hi,

This is a review request to remove the test
java/net/ipv6tests/UdpTest.java from ProblemList.txt. The test tracked
by JDK-7079145  is
hung if linux kernel is 2.6.18.
By upgrading the kernel to higher version 2.6.32, the problem doesn't 
exist.

http://cr.openjdk.java.net/~ewang/7079145/webrev.00/


Thanks,
Eric





HttpURLConnection with IPv6 link-local address

2013-10-24 Thread Bruno Harbulot
Hello,

I've been trying to use HttpURLConnection to connect to a web server using
its IPv6 link-local address.

There are two issues with this:

- HttpURLConnection work with URLs with the official % syntax (only the
informal one) for the scope ID (normally required for link-local addresses).

  Indeed, http://[fe80::a00:27ff::%eth0]/ (for example) can be used
to send a request, but http://[fe80::a00:27ff::%25eth0]/ will not
send a request at all ("java.net.SocketException: Network is
unreachable...").
  The difference is in the encoding of % (which separates the actual IP
address from the scope ID).
  RFC 6874 (Section 2) says, "According to URI syntax [RFC3986], "%" is
always treated as an escape character in a URI, so, according to the
established URI syntax [RFC3986] any occurrences of literal "%" symbols in
a URI MUST be percent-encoded and represented in the form "%25"."

- HttpURLConnection sends the scope ID in the Host header, i.e. "Host:
[fe80::a00:27ff::%eth0]" instead of "Host:
[fe80::a00:27ff::]".

  Unfortunately, this doesn't seem to be allowed by RFC 4007, and this
causes Apache Httpd to return a 400 error status.
  (There are more details in this Apache Httpd issue:
https://issues.apache.org/bugzilla/show_bug.cgi?id=35122#c4 )

  The only workaround I've found was to set the Host header manually, but
this also requires enabling "sun.net.http.allowRestrictedHeaders".


These problems are present in the latest Java 7 release and in the Java 8
early release.

I'm not sure if this has already been reported or discussed. If not, would
it be possible to address it in future releases?

Best wishes,

Bruno.


hg: jdk8/tl/jdk: 8026929: remove accelerators from policytool resources

2013-10-24 Thread weijun . wang
Changeset: e9ec0ca5bab1
Author:weijun
Date:  2013-10-25 08:38 +0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e9ec0ca5bab1

8026929: remove accelerators from policytool resources
Reviewed-by: alexp, weijun
Contributed-by: Leif Samuelsson 

! src/share/classes/sun/security/tools/policytool/PolicyTool.java
! src/share/classes/sun/security/tools/policytool/Resources.java



hg: jdk8/tl/jdk: 8025003: Base64 should be less strict with padding

2013-10-24 Thread xueming . shen
Changeset: e7bdb2fcc7bc
Author:sherman
Date:  2013-10-24 11:12 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7bdb2fcc7bc

8025003: Base64 should be less strict with padding
Summary: updated spec and implementation of mime decoder to be lenient for 
padding
Reviewed-by: alanb

! src/share/classes/java/util/Base64.java
! test/java/util/Base64/Base64GetEncoderTest.java
! test/java/util/Base64/TestBase64.java
! test/java/util/Base64/TestBase64Golden.java



hg: jdk8/tl/jdk: 8023862: deprecate HTTP proxying from RMI

2013-10-24 Thread stuart . marks
Changeset: 808b9ef4f667
Author:smarks
Date:  2013-10-24 10:13 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/808b9ef4f667

8023862: deprecate HTTP proxying from RMI
Reviewed-by: mchung

! src/share/classes/java/rmi/server/RMISocketFactory.java
! src/share/classes/java/rmi/server/package.html
! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java
+ test/sun/rmi/transport/proxy/DisableHttpDefaultValue.java



hg: jdk8/tl/jdk: 8019646: Clarify javadoc contract of LambdaMetafactory

2013-10-24 Thread brian . goetz
Changeset: 5fa2fd782993
Author:briangoetz
Date:  2013-10-24 13:06 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fa2fd782993

8019646: Clarify javadoc contract of LambdaMetafactory
Reviewed-by: briangoetz, rfield
Contributed-by: dan.sm...@oracle.com

! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java
! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
! src/share/classes/java/lang/invoke/LambdaMetafactory.java



hg: jdk8/tl/jdk: 8024521: (process) Async close issues with Process InputStream

2013-10-24 Thread rob . mckenna
Changeset: e2ec05b2ed94
Author:igerasim
Date:  2013-10-23 15:37 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2ec05b2ed94

8024521: (process) Async close issues with Process InputStream
Reviewed-by: psandoz, martin, alanb, robm

! src/solaris/classes/java/lang/UNIXProcess.java.bsd
! src/solaris/classes/java/lang/UNIXProcess.java.linux
+ test/java/lang/Runtime/exec/CloseRace.java



Re: ProblemList updating request for JDK-7079145: java/net/ipv6tests/UdpTest.java

2013-10-24 Thread Chris Hegarty

The changes, to remove this test from the problem list, look fine to me.

I see that JDK-7079145 has been closed. We should probably re-open it, 
and use it to push these changes.


I can sponsor this change for you.

-Chris.

On 10/24/2013 03:58 AM, Eric Wang wrote:

Hi,

This is a review request to remove the test
java/net/ipv6tests/UdpTest.java from ProblemList.txt. The test tracked
by JDK-7079145  is
hung if linux kernel is 2.6.18.
By upgrading the kernel to higher version 2.6.32, the problem doesn't exist.
http://cr.openjdk.java.net/~ewang/7079145/webrev.00/


Thanks,
Eric



hg: jdk8/tl/jdk: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

2013-10-24 Thread alan . bateman
Changeset: 700d62b8d9cc
Author:alanb
Date:  2013-10-24 13:24 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/700d62b8d9cc

8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is 
Serializable
Reviewed-by: rriggs, psandoz, chegar
Contributed-by: d...@cs.oswego.edu, alan.bate...@oracle.com

! src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java
! src/share/classes/java/util/concurrent/atomic/DoubleAdder.java
! src/share/classes/java/util/concurrent/atomic/LongAccumulator.java
! src/share/classes/java/util/concurrent/atomic/LongAdder.java
+ test/java/util/concurrent/atomic/Serial.java



Re: ProblemList updating request for JDK-7079145: java/net/ipv6tests/UdpTest.java

2013-10-24 Thread Alan Bateman

On 24/10/2013 03:59, Eric Wang wrote:

On 2013/10/24 10:57, Eric Wang wrote:

Hi,

This is a review request to remove the test 
java/net/ipv6tests/UdpTest.java from ProblemList.txt. The test 
tracked by JDK-7079145 
 is hung if linux 
kernel is 2.6.18.
By upgrading the kernel to higher version 2.6.32, the problem doesn't 
exist.


Thanks,
Eric

Sorry, forgot to update the webrev:
http://cr.openjdk.java.net/~ewang/7079145/webrev.00/ 

It's good to liberate this test. From what I can tell, 2.6.16 was 2006 
so I wouldn't expect too many people to be testing on that kernel nowadays.


-Alan.


hg: jdk8/tl/jdk: 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads

2013-10-24 Thread staffan . larsen
Changeset: e6bc0dca294b
Author:sla
Date:  2013-10-15 12:53 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6bc0dca294b

8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are 
unexpected background threads
Reviewed-by: sla, allwin
Contributed-by: mikael.a...@oracle.com

! test/com/sun/jdi/MethodEntryExitEvents.java
! test/com/sun/jdi/MethodExitReturnValuesTest.java