[9] RFR of 8129510: java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java should exclude testing the Teredo tunneling interface on Windows

2015-06-22 Thread Brian Burkhalter 
Please review this test-only change at your convenience.

Issue:  https://bugs.openjdk.java.net/browse/JDK-8129510
Patch:  see diff below

The analysis in the comments on 
https://bugs.openjdk.java.net/browse/JDK-8042902 suggests that excluding 
testing of Teredo tunneling in this test might be appropriate and would produce 
a reliable test, hence this patch. Assuming that this is acceptable, the test 
should pass consistently and other issue could resolved as “Cannot Reproduce.”

Alternatively, the issue at hand may be inappropriate and applying the included 
diff could mask a real problem. If this latter is the consensus then this issue 
will be resolved as “Not an Issue."

Thanks,

Brian

— diff —

--- a/test/java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java
+++ b/test/java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -49,6 +49,8 @@
 
 static boolean failed;
 
+static boolean isWindows = 
System.getProperty("os.name").startsWith("Windows");
+
 public static final int LOOPBACK_SCOPE_ID = 0;
 
 public static final byte[] IN6ADDR_ANY_INIT = { (byte) 0x00, (byte) 0x00,
@@ -175,6 +177,13 @@
 for (Enumeration e = NetworkInterface
 .getNetworkInterfaces(); e.hasMoreElements();) {
 NetworkInterface netIF = e.nextElement();
+// Skip (Windows)Teredo Tunneling Pseudo-Interface
+if (isWindows) {
+String dName = netIF.getDisplayName();
+if (dName != null && dName.contains("Teredo")) {
+continue;
+}
+}
 for (Enumeration iadrs = netIF.getInetAddresses(); 
iadrs
 .hasMoreElements();) {
 InetAddress iadr = iadrs.nextElement();

Fwd: [9] RFR of 8129499: Structure of java/rmi/activation/rmidViaInheritedChannel tests masks exception

2015-06-22 Thread Brian Burkhalter 
Sorry: posted to wrong list.

Re-direct this thread to: 
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/034223.html

Begin forwarded message:

> From: Brian Burkhalter 
> Subject: [9] RFR of 8129499: Structure of 
> java/rmi/activation/rmidViaInheritedChannel tests masks exception
> Date: June 22, 2015 at 1:03:07 PM PDT
> To: net-dev@openjdk.java.net
> 
> Please review at your convenience.
> 
> Issue:https://bugs.openjdk.java.net/browse/JDK-8129499
> Patch:http://cr.openjdk.java.net/~bpb/8129499/webrev.00/
> 
> Summary: The instance variable ‘rmid’ is never initialized due to some error 
> which occurs before the statement which would initialize it but it is 
> dereferenced in the finally block which causes any exception within the try 
> block to be suppressed.
> 
> This issue blocks obtaining further information from tests runs with respect 
> to https://bugs.openjdk.java.net/browse/JDK-8077668.
> 
> Thanks,
> 
> Brian

[9] RFR of 8129499: Structure of java/rmi/activation/rmidViaInheritedChannel tests masks exception

2015-06-22 Thread Brian Burkhalter 
Please review at your convenience.

Issue:  https://bugs.openjdk.java.net/browse/JDK-8129499
Patch:  http://cr.openjdk.java.net/~bpb/8129499/webrev.00/

Summary: The instance variable ‘rmid’ is never initialized due to some error 
which occurs before the statement which would initialize it but it is 
dereferenced in the finally block which causes any exception within the try 
block to be suppressed.

This issue blocks obtaining further information from tests runs with respect to 
https://bugs.openjdk.java.net/browse/JDK-8077668.

Thanks,

Brian